unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mike Delago <michaeldelago98@gmail.com>
To: 68569@debbugs.gnu.org
Cc: Mike Delago <michaeldelago98@gmail.com>
Subject: [bug#68569] [PATCH v2 0/2] gnu: borgmatic: Update to 1.8.6
Date: Sun, 21 Jan 2024 15:07:19 -0500	[thread overview]
Message-ID: <cover.1705867641.git.michaeldelago98@gmail.com> (raw)
In-Reply-To: <cover.1705586561.git.michaeldelago98@gmail.com>

Hey Maxim, 

This revision of the patchset should have corrected the
things you've noted.

> Nitpick: I prefer to list inputs in the order of native, inputs,
> propagated.  Was the above order produced by the pypi importer?

Yes - the manifest came largely from the pypi importer. The
`native-inputs` block was added in order to cover the
"dev-requirements.txt"[0] file in the upstream repo. This was needed in
order for tests to pass.

Corrected in this revision to the patch.


> This is too verbose for a synopsis...
> That sounds like marketing talk...

Good catch - this was the default value from the page on pypi.

Both the description and the synopsis should be corrected for this
patch, but please let me know if they don't contain sufficient
information. 

> Please punctuate your comments (including periods).

Done, thanks

> Github says bsd-2.  Could you check?

This has been corrected

Thanks for your review, please let me know if I missed anything else

[0] - https://github.com/caronc/apprise/blob/master/dev-requirements.txt

---
Best, 
Mike Delago

Mike Delago (2):
  gnu: Add python-apprise.
  gnu: borgmatic: Update to 1.8.6.

 gnu/packages/backup.scm     | 61 +++++++++++++++++++------------------
 gnu/packages/python-xyz.scm | 38 +++++++++++++++++++++++
 2 files changed, 70 insertions(+), 29 deletions(-)


base-commit: 48b5e885182738fe28bed2d1b45e91be95dce67c
-- 
2.41.0





  parent reply	other threads:[~2024-01-21 20:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-18 14:20 [bug#68569] [PATCH 0/2] gnu: borgmatic: Update to 1.8.6 Mike Delago
2024-01-18 14:32 ` [bug#68569] [PATCH 1/2] gnu: Add python-apprise Mike Delago
2024-01-21  4:57   ` Maxim Cournoyer
2024-01-18 14:32 ` [bug#68569] [PATCH 2/2] gnu: borgmatic: Update to 1.8.6 Mike Delago
2024-01-21  4:59   ` Maxim Cournoyer
2024-01-21 20:07 ` Mike Delago [this message]
2024-01-21 20:07   ` [bug#68569] [PATCH v2 1/2] gnu: Add python-apprise Mike Delago
2024-01-21 20:07   ` [bug#68569] [PATCH v2 2/2] gnu: borgmatic: Update to 1.8.6 Mike Delago

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1705867641.git.michaeldelago98@gmail.com \
    --to=michaeldelago98@gmail.com \
    --cc=68569@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).