From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id CJaVCGWkrGV2XAAA62LTzQ:P1 (envelope-from ) for ; Sun, 21 Jan 2024 05:58:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id CJaVCGWkrGV2XAAA62LTzQ (envelope-from ) for ; Sun, 21 Jan 2024 05:58:13 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=RwAcaRlx; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1705813093; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=jKqtWhnyMICuSKWhAQoc9HnoKGBslwFp/ktu4+n6w1U=; b=PP18wMiZFmYLQz8WdBLd5hxHeJ5zbWQngehM4A+YPkIz6cnkPq3sP6+/a80d6B6ee6tSIQ vbdtQppVcRbNsKx5XrCDruA/Vc4BkEFRA22EX8I8Tu5MubVQnU8xa7b+4lklnotshrMhJ6 23/sSVnvqHfBKUV0yfxHB8poXIVXxDimTpgL7l+yFJ7WaL1ZDNpOaUyd5ejm7247Ny2wkP pD4RBTgGqfNMTzHEM71wZbA9kTIn6W0AsBuvLr78b/KYeBCGY+NdlujWCxB1P3IJoryCPG 55eS6DOtEReFW/Rp1Yr5df4k3M0AozOmGaCi7V2D5b1jMqFZ6HuP9OKTZ3cf/g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=RwAcaRlx; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1705813093; a=rsa-sha256; cv=none; b=MKKS057L7cfwzuKrUDBxSawgWcfUr/r+BCiFO+I7MKDKFv56091lKgxjdeEbIMNteXvTwq 9nTdm4ihMk8eL2W2i63P6YwVnzxp/7gkKsgLzdwQwJZm+tKQa6UgKVi1mSMaB7UljA8U0w grLTjXUCB+B69LjtJsxUxZZsz77c1fY7PmzPkZlGCAz+B7O7j63BDO+B0YYVHAPx8wnGRR O+Lp2Qc+uYHvV4IUVjb2AKOq+Y79fTN90pJSGlVxisaK7oMixAGEn02cEa6eVWfDgwnVVi BSIsbr/8EdinjKM7n5xDZ2pgpccijfdR+KE8Je9clnUmc2WxvUWWjAYD8VL1FA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D170266574 for ; Sun, 21 Jan 2024 05:58:12 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rRPuE-00009I-2q; Sat, 20 Jan 2024 23:58:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRPuB-00008z-Hp for guix-patches@gnu.org; Sat, 20 Jan 2024 23:57:59 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rRPuB-0005kt-0I for guix-patches@gnu.org; Sat, 20 Jan 2024 23:57:59 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rRPuE-00077w-6e for guix-patches@gnu.org; Sat, 20 Jan 2024 23:58:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68569] [PATCH 1/2] gnu: Add python-apprise. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 21 Jan 2024 04:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68569 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mike Delago Cc: 68569@debbugs.gnu.org Received: via spool by 68569-submit@debbugs.gnu.org id=B68569.170581304227350 (code B ref 68569); Sun, 21 Jan 2024 04:58:02 +0000 Received: (at 68569) by debbugs.gnu.org; 21 Jan 2024 04:57:22 +0000 Received: from localhost ([127.0.0.1]:36317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRPtZ-000774-LK for submit@debbugs.gnu.org; Sat, 20 Jan 2024 23:57:22 -0500 Received: from mail-qv1-xf2a.google.com ([2607:f8b0:4864:20::f2a]:57609) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRPtX-00076p-7f for 68569@debbugs.gnu.org; Sat, 20 Jan 2024 23:57:20 -0500 Received: by mail-qv1-xf2a.google.com with SMTP id 6a1803df08f44-680fdf7d52fso15941566d6.3 for <68569@debbugs.gnu.org>; Sat, 20 Jan 2024 20:57:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705813030; x=1706417830; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=jKqtWhnyMICuSKWhAQoc9HnoKGBslwFp/ktu4+n6w1U=; b=RwAcaRlxG4qE4eD+27ASUNROyXF15uDg2q8ca+9RLPJv9ObuUHTyLSo3BadsOmQz7Y zGHkRMsslJ6Xf+T8sNlkoj0HQNBBXvex+kn3TZUhzpunm+UyF6MlEPMNzIPnXlfDd7C/ 7sdYw6tgpluxP0tdCqL6m1RluQMxdugjrUtnz9uODRIu/8B/IpYQHU2/fTq/k7J/5L2r cvxDur6i4HXErTzv/IhKBHhOKjDmlm1FO4X0PNbZi9EeyU7e0wZa93QMwJ04dsmam08C XQwAE2B0XawTGchf7SM2gP6gOh59Nwfk6GnwWoKtji3GfBerxlqaYdW84OSQAT+JjZXg Cdqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705813030; x=1706417830; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jKqtWhnyMICuSKWhAQoc9HnoKGBslwFp/ktu4+n6w1U=; b=UMaIPEBIpwK62IxCocQxUHFxQnAyuTTMEC3rvRMzpA2QH96o5e/EckiMDl2uDWBJsk p6Fnn6+HMyUrZsZRAfOqGToQpkHOZ0KpD828pai/nR+g0Mo3rPDBWLARPsEnbTuzGuMq x9xF5Pdj83bQ7wHUC4kH26ESTbnvpozj2I4vphfWZ82WvtSxt1tCUatEQ8fXk8dZRdBw L8nKMnH0qB7vw03rkxFfzzSV2BKOcuxjOnV2EDGbzIUiGv227IlXfgPTBzqStFJZ/qXt gR5Mczst9VqZD4XBXxxOaOiPLDZpxIuJErSa9dh5OM55z78DkrYqFACRBpvBrDQnrb7k ctBA== X-Gm-Message-State: AOJu0Yz0yrvQs+OiUU5BcfaeYNIp8eFTr62BV+RdOR3um/MtEzL3oCp7 Z5LUajalRO/3lIjIlOivSP6IgVWyHyer+3/djaSub3KrerulNyikEXRqFwTD9ng= X-Google-Smtp-Source: AGHT+IFRoGvRFE8Gkqx+YdrCfUlof77/1x7IRuVuA9OzySJum7LC48mWah49cMZ8d0lEiSaJaKQ5ig== X-Received: by 2002:a0c:db06:0:b0:685:d99e:117f with SMTP id d6-20020a0cdb06000000b00685d99e117fmr2047785qvk.60.1705813029890; Sat, 20 Jan 2024 20:57:09 -0800 (PST) Received: from hurd (dsl-10-128-232.b2b2c.ca. [72.10.128.232]) by smtp.gmail.com with ESMTPSA id ld27-20020a056214419b00b0067f90426698sm1210919qvb.23.2024.01.20.20.57.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Jan 2024 20:57:09 -0800 (PST) From: Maxim Cournoyer In-Reply-To: <236d62db2eb224c0ae8ee7ea0fabecbb4dc4c929.1705586561.git.michaeldelago98@gmail.com> (Mike Delago's message of "Thu, 18 Jan 2024 09:32:07 -0500") References: <236d62db2eb224c0ae8ee7ea0fabecbb4dc4c929.1705586561.git.michaeldelago98@gmail.com> Date: Sat, 20 Jan 2024 23:57:08 -0500 Message-ID: <87cytvb7x7.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 2.32 X-Spam-Score: 2.32 X-Migadu-Queue-Id: D170266574 X-Migadu-Scanner: mx12.migadu.com X-TUID: a2CykJtySEq3 Hi! Mike Delago writes: > * gnu/packages/python-xyz.scm (python-apprise): New variable. > > Change-Id: I24659780121e3d428002f504a459bea442790a7b > --- > gnu/packages/python-xyz.scm | 36 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > > diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm > index aebbae1521..aecebb1dde 100644 > --- a/gnu/packages/python-xyz.scm > +++ b/gnu/packages/python-xyz.scm > @@ -14364,6 +14364,42 @@ (define-public python-appdirs > should be stored on various operating systems.") > (license license:expat))) > > +(define-public python-apprise > + (package > + (name "python-apprise") > + (version "1.7.1") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "apprise" version)) > + (sha256 > + (base32 "0nkfv0pyn13lqdr3g3r1dhhnqxkjiayf9pny4m254w04al49shwd")) > + ;; MacOS tests are failing when attempting to mock terminal-notifier calls > + ;; We don't need to test for MacOS support, and removing this file causes > + ;; tests to succeed Please punctuate your comments (including periods). > + (modules '((guix build utils))) > + (snippet '(begin > + (delete-file-recursively "test/test_plugin_macosx.py"))))) > + (build-system pyproject-build-system) > + (propagated-inputs (list python-certifi > + python-click > + python-markdown > + python-pyyaml > + python-requests > + python-requests-oauthlib)) > + (native-inputs (list python-babel > + python-coverage > + python-flake8 > + python-pytest > + python-pytest-cov > + python-pytest-mock > + python-pytest-xdist)) Nitpick: I prefer to list inputs in the order of native, inputs, propagated. Was the above order produced by the pypi importer? > + (home-page "https://github.com/caronc/apprise") > + (synopsis "Push Notifications that work with just about every platform!") This is too verbose for a synopsis. Synopses should describe in a few words what the package *is*, such as "Push notification library and utility" (no trailing period here). > + (description > + "Push Notifications that work with just about every platform!") That sounds like marketing talk. Keep it dry and factual, synthesizing the interesting technical bits from their description text available from . > + (license license:bsd-3))) Github says bsd-2. Could you check? Other than that, it looks good to me. Could you please send a v2 with the requested changes? -- Thanks, Maxim