unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 37553@debbugs.gnu.org
Subject: [bug#37553] [PATCH] inferior: Change to use the (guix repl) module.
Date: Tue, 01 Oct 2019 10:56:05 +0200	[thread overview]
Message-ID: <87blv0sv2y.fsf@gnu.org> (raw)
In-Reply-To: <20190929155728.27777-1-mail@cbaines.net> (Christopher Baines's message of "Sun, 29 Sep 2019 16:57:28 +0100")

Hi,

Christopher Baines <mail@cbaines.net> skribis:

> Rather than (guix scripts repl), from which the machine-repl procedure was
> removed in [1].
>
> 1: 92a4087bf4862d5ba9b77111eba3c68c2a1c4679
>
> * guix/inferior.scm (inferior-pipe): Load (guix repl) rather than (guix
> scripts repl).
> ---
>  guix/inferior.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/guix/inferior.scm b/guix/inferior.scm
> index dcbc954432..d6d2053ab8 100644
> --- a/guix/inferior.scm
> +++ b/guix/inferior.scm
> @@ -136,8 +136,8 @@ it's an old Guix."
>                        (object->string
>                         `(begin
>                            (primitive-load ,(search-path %load-path
> -                                                        "guix/scripts/repl.scm"))
> -                          ((@ (guix scripts repl) machine-repl))))))
> +                                                        "guix/repl.scm"))
> +                          ((@ (guix repl) machine-repl))))))
>          pipe)))

This one LGTM!

(Note that this code is only used when spawning an inferior for a
revision that dates back to before ‘guix repl’ existed, so before July
2018.)

Thanks,
Ludo’.

  reply	other threads:[~2019-10-01  8:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-29 13:01 [bug#37553] [PATCH] inferior: Change to using guix-repl Christopher Baines
2019-09-29 15:20 ` [bug#37553] [PATCH] inferior: Change to use the (guix repl) module Christopher Baines
2019-09-29 15:57 ` Christopher Baines
2019-10-01  8:56   ` Ludovic Courtès [this message]
2019-10-01 19:26     ` bug#37553: " Christopher Baines
2019-10-02  9:30       ` [bug#37553] " Ludovic Courtès
2019-10-06  8:46         ` Christopher Baines
2019-10-06  8:58           ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87blv0sv2y.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=37553@debbugs.gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).