From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:59145)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iFDxw-0004yo-0k
 for guix-patches@gnu.org; Tue, 01 Oct 2019 04:57:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iFDxu-0003kp-TK
 for guix-patches@gnu.org; Tue, 01 Oct 2019 04:57:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:52039)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iFDxu-0003kS-Do
 for guix-patches@gnu.org; Tue, 01 Oct 2019 04:57:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iFDxu-0007Sb-BR
 for guix-patches@gnu.org; Tue, 01 Oct 2019 04:57:02 -0400
Subject: [bug#37553] [PATCH] inferior: Change to use the (guix repl) module.
Resent-Message-ID: <handler.37553.B37553.156992017028598@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190929130128.18484-1-mail@cbaines.net>
 <20190929155728.27777-1-mail@cbaines.net>
Date: Tue, 01 Oct 2019 10:56:05 +0200
In-Reply-To: <20190929155728.27777-1-mail@cbaines.net> (Christopher Baines's
 message of "Sun, 29 Sep 2019 16:57:28 +0100")
Message-ID: <87blv0sv2y.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 37553@debbugs.gnu.org

Hi,

Christopher Baines <mail@cbaines.net> skribis:

> Rather than (guix scripts repl), from which the machine-repl procedure was
> removed in [1].
>
> 1: 92a4087bf4862d5ba9b77111eba3c68c2a1c4679
>
> * guix/inferior.scm (inferior-pipe): Load (guix repl) rather than (guix
> scripts repl).
> ---
>  guix/inferior.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/guix/inferior.scm b/guix/inferior.scm
> index dcbc954432..d6d2053ab8 100644
> --- a/guix/inferior.scm
> +++ b/guix/inferior.scm
> @@ -136,8 +136,8 @@ it's an old Guix."
>                        (object->string
>                         `(begin
>                            (primitive-load ,(search-path %load-path
> -                                                        "guix/scripts/re=
pl.scm"))
> -                          ((@ (guix scripts repl) machine-repl))))))
> +                                                        "guix/repl.scm"))
> +                          ((@ (guix repl) machine-repl))))))
>          pipe)))

This one LGTM!

(Note that this code is only used when spawning an inferior for a
revision that dates back to before =E2=80=98guix repl=E2=80=99 existed, so =
before July
2018.)

Thanks,
Ludo=E2=80=99.