From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 37553-done@debbugs.gnu.org
Subject: bug#37553: [PATCH] inferior: Change to use the (guix repl) module.
Date: Tue, 01 Oct 2019 20:26:56 +0100 [thread overview]
Message-ID: <87tv8sp8qn.fsf@cbaines.net> (raw)
In-Reply-To: <87blv0sv2y.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1513 bytes --]
Ludovic Courtès <ludo@gnu.org> writes:
> Hi,
>
> Christopher Baines <mail@cbaines.net> skribis:
>
>> Rather than (guix scripts repl), from which the machine-repl procedure was
>> removed in [1].
>>
>> 1: 92a4087bf4862d5ba9b77111eba3c68c2a1c4679
>>
>> * guix/inferior.scm (inferior-pipe): Load (guix repl) rather than (guix
>> scripts repl).
>> ---
>> guix/inferior.scm | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/guix/inferior.scm b/guix/inferior.scm
>> index dcbc954432..d6d2053ab8 100644
>> --- a/guix/inferior.scm
>> +++ b/guix/inferior.scm
>> @@ -136,8 +136,8 @@ it's an old Guix."
>> (object->string
>> `(begin
>> (primitive-load ,(search-path %load-path
>> - "guix/scripts/repl.scm"))
>> - ((@ (guix scripts repl) machine-repl))))))
>> + "guix/repl.scm"))
>> + ((@ (guix repl) machine-repl))))))
>> pipe)))
>
> This one LGTM!
Great :) I've pushed it as 2cd599f005bb91ae120a66824b8efbac81a27a69.
> (Note that this code is only used when spawning an inferior for a
> revision that dates back to before ‘guix repl’ existed, so before July
> 2018.)
Yep, I've been experimenting with loading older revisions in to the Guix
Data Service, and this is one of the issues I came across.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
next prev parent reply other threads:[~2019-10-01 19:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-29 13:01 [bug#37553] [PATCH] inferior: Change to using guix-repl Christopher Baines
2019-09-29 15:20 ` [bug#37553] [PATCH] inferior: Change to use the (guix repl) module Christopher Baines
2019-09-29 15:57 ` Christopher Baines
2019-10-01 8:56 ` Ludovic Courtès
2019-10-01 19:26 ` Christopher Baines [this message]
2019-10-02 9:30 ` Ludovic Courtès
2019-10-06 8:46 ` Christopher Baines
2019-10-06 8:58 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tv8sp8qn.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=37553-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).