From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:48885) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZO0U-0000l8-WF for guix-patches@gnu.org; Mon, 25 Nov 2019 18:43:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZO0T-000327-Uk for guix-patches@gnu.org; Mon, 25 Nov 2019 18:43:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:43976) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iZO0T-000323-RL for guix-patches@gnu.org; Mon, 25 Nov 2019 18:43:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iZO0T-0007Za-Ps for guix-patches@gnu.org; Mon, 25 Nov 2019 18:43:01 -0500 Subject: [bug#37886] [PATCH] gnu: Add ipcalc. Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87zhhqyy6y.fsf@gmail.com> Date: Tue, 26 Nov 2019 00:42:32 +0100 In-Reply-To: <87zhhqyy6y.fsf@gmail.com> (Mathieu Othacehe's message of "Thu, 24 Oct 2019 17:12:37 +0200") Message-ID: <87a78jttef.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Daniel =?UTF-8?Q?Sch=C3=A4fer?= Cc: 37886@debbugs.gnu.org, Mathieu Othacehe Hello Daniel, Did you have a chance to look into the suggestions Mathieu made? See . Thanks in advance! :-) Ludo=E2=80=99. Mathieu Othacehe skribis: > Hello Daniel, > >> here's my first patch to guix - please let me know whether everything's = okay. >> It adds the ipcalc package which can calculate IP ranges. Example: > > Welcome to Guix :) This first patch looks fine, I just have two remarks. > >> new file mode 100644 >> index 0000000000..5f83389b25 >> --- /dev/null >> +++ b/gnu/packages/ipcalc.scm > > I think you can use the existing networking.scm for this tool. > >> + (description "ipcalc takes an IP address and netmask and calculates= the >> + resulting broadcast, network, Cisco wildcard mask, and= host >> + range. By giving a second netmask, you can design sub= nets and >> + supernets. It is also intended to be a teaching tool = and >> + presents the subnetting results as easy-to-understand = binary >> + values.") > > The indentation is not correct here. You can use M-q if you are using > emacs or indent.el script otherwise (see: > https://guix.gnu.org/manual/en/html_node/Formatting-Code.html). > > Can you please send an updated patch? > > Thanks, > > Mathieu