From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:44650) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEvoB-0007V9-49 for guix-patches@gnu.org; Thu, 19 Mar 2020 10:06:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jEvoA-0000A5-7V for guix-patches@gnu.org; Thu, 19 Mar 2020 10:06:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37462) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jEvoA-00009x-4T for guix-patches@gnu.org; Thu, 19 Mar 2020 10:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jEvo9-0007bV-Q5 for guix-patches@gnu.org; Thu, 19 Mar 2020 10:06:01 -0400 Subject: [bug#40083] [PATCH] gnu: Add blktrace. Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Thu, 19 Mar 2020 15:04:59 +0100 In-Reply-To: (Vincent Legoll's message of "Sun, 15 Mar 2020 22:47:06 +0100") Message-ID: <87a74c5tkk.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Vincent Legoll Cc: 40083@debbugs.gnu.org --=-=-= Content-Type: text/plain Hi! Vincent Legoll skribis: > Dunno what to do about the packaged .py scripts, Should I patch the > shebang ? ("#! /usr/bin/env python") after adding python to inputs ? Just do something like this: --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index d19c20d056..0822748968 100644 --- a/gnu/packages/linux.scm +++ b/gnu/packages/linux.scm @@ -4036,7 +4036,8 @@ applications.") #:phases (modify-phases %standard-phases (delete 'configure)))) ; no configure script (inputs - `(("libaio" ,libaio))) + `(("libaio" ,libaio) + ("python" ,python-wrapper))) ;for 'bno_plot.py' (synopsis "Block layer IO tracing mechanism") (description "Blktrace is a block layer IO tracing mechanism which provides detailed information about request queue operations to user space. It extracts --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable and the .py files will be automatically patched. However, =E2=80=98bno_plot.py=E2=80=99 refers to /bin/rm and gnuplot, and t= hese references should probably be replaced with absolute file names. Could you take a look and send an updated patch? Thanks, Ludo=E2=80=99. --=-=-=--