unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <marius@gnu.org>
To: Josh Marshall <joshua.r.marshall.1991@gmail.com>
Cc: 41345-done@debbugs.gnu.org
Subject: [bug#41345] 000-update-python-argon2-cffi.patch
Date: Mon, 25 May 2020 23:35:42 +0200	[thread overview]
Message-ID: <87a71v7l5d.fsf@gnu.org> (raw)
In-Reply-To: <CAFkJGRciGh8irJ+H_qAEshZDxH8i9of_R_KK1WqkjaepRKJ7OQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1137 bytes --]

Josh Marshall <joshua.r.marshall.1991@gmail.com> writes:

> When reading https://guix.gnu.org/manual/en/guix.html#Submitting-Patches
> I do not see guidance on this particular aspect of sending patches.
> What do I need to alter, and should those details be added to the
> manual?

It's not very prominent, but it's there:

  Please write commit logs in the ChangeLog format (see Change Logs in
  GNU Coding Standards); you can check the commit history for examples.

With a link to the GNU Coding Standards document:

  https://www.gnu.org/prep/standards/standards.html#Change-Logs

Perhaps we could include a condensed version as it borders on TL;DR.

>  git commit -am "Updating python-argon2-cffi to 20.1.0"

If you omit the -m, git will open your $EDITOR where you can contemplate
on how best to communicate what the patch does, and write over multiple
lines.  There are helper functions in Emacs to fill out the boring
"* gnu/packages/file-name.scm (variable):" part of the commit message.

When unsure, I recommend running "git log the-file.scm" and look at
previous commit messages for inspiration.

Thanks for persevering!  :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2020-05-25 21:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-17  4:20 [bug#41345] 000-update-python-argon2-cffi.patch Josh Marshall
2020-05-20 21:01 ` Marius Bakke
2020-05-20 21:07   ` Josh Marshall
2020-05-25 11:55     ` Josh Marshall
2020-05-25 14:59       ` bug#41345: 000-update-python-argon2-cffi.patch Marius Bakke
2020-05-25 16:13         ` [bug#41345] 000-update-python-argon2-cffi.patch Josh Marshall
2020-05-25 21:35           ` Marius Bakke [this message]
2020-05-25 22:39             ` Josh Marshall
2020-05-30 13:12               ` Marius Bakke
2020-05-30 16:49                 ` Josh Marshall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a71v7l5d.fsf@gnu.org \
    --to=marius@gnu.org \
    --cc=41345-done@debbugs.gnu.org \
    --cc=joshua.r.marshall.1991@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).