From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8B9OM0s6zF45YwAA0tVLHw (envelope-from ) for ; Mon, 25 May 2020 21:36:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id KPYlL0s6zF7rUwAAB5/wlQ (envelope-from ) for ; Mon, 25 May 2020 21:36:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4D319940D35 for ; Mon, 25 May 2020 21:36:11 +0000 (UTC) Received: from localhost ([::1]:45822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdKlW-0004bN-Ae for larch@yhetil.org; Mon, 25 May 2020 17:36:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36172) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdKlO-0004b3-NG for guix-patches@gnu.org; Mon, 25 May 2020 17:36:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59333) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jdKlO-0001KL-C0 for guix-patches@gnu.org; Mon, 25 May 2020 17:36:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jdKlO-00082s-8R for guix-patches@gnu.org; Mon, 25 May 2020 17:36:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41345] 000-update-python-argon2-cffi.patch Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 25 May 2020 21:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41345 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Josh Marshall Cc: 41345-done@debbugs.gnu.org Received: via spool by 41345-done@debbugs.gnu.org id=D41345.159044255330911 (code D ref 41345); Mon, 25 May 2020 21:36:02 +0000 Received: (at 41345-done) by debbugs.gnu.org; 25 May 2020 21:35:53 +0000 Received: from localhost ([127.0.0.1]:42646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdKlF-00082V-0U for submit@debbugs.gnu.org; Mon, 25 May 2020 17:35:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdKlD-000827-FN for 41345-done@debbugs.gnu.org; Mon, 25 May 2020 17:35:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58033) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdKl8-0001Ih-5l; Mon, 25 May 2020 17:35:46 -0400 Received: from ti0006q161-2604.bb.online.no ([84.202.68.75]:39152 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jdKl7-0005I9-JN; Mon, 25 May 2020 17:35:45 -0400 From: Marius Bakke In-Reply-To: References: <87o8qi9v8i.fsf@devup.no> <87lflg6owx.fsf@gnu.org> Date: Mon, 25 May 2020 23:35:42 +0200 Message-ID: <87a71v7l5d.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -3.11 X-TUID: z/OAzci8f/Nv --=-=-= Content-Type: text/plain Josh Marshall writes: > When reading https://guix.gnu.org/manual/en/guix.html#Submitting-Patches > I do not see guidance on this particular aspect of sending patches. > What do I need to alter, and should those details be added to the > manual? It's not very prominent, but it's there: Please write commit logs in the ChangeLog format (see Change Logs in GNU Coding Standards); you can check the commit history for examples. With a link to the GNU Coding Standards document: https://www.gnu.org/prep/standards/standards.html#Change-Logs Perhaps we could include a condensed version as it borders on TL;DR. > git commit -am "Updating python-argon2-cffi to 20.1.0" If you omit the -m, git will open your $EDITOR where you can contemplate on how best to communicate what the patch does, and write over multiple lines. There are helper functions in Emacs to fill out the boring "* gnu/packages/file-name.scm (variable):" part of the commit message. When unsure, I recommend running "git log the-file.scm" and look at previous commit messages for inspiration. Thanks for persevering! :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7MOi4ACgkQoqBt8qM6 VPrbfQf9HwteyLx3AXTPPQglkNRkP7jBr7aADJRRBxYutnwlE0FkSKKZwScnq/Bl y2D4cLao3FuMViuWofAIY43qLbKGT+xrxemC5uF+35lGYsTB40519o05jpAeC+3Z YCxS4ZSC5ESY+BanEw52MxwzBepcEmv/Y9GdWaz8/0JXKYcxXtwYCN3vJtN1MwvP d6VXc3yilT70ygQdHRjnyAl2TUkgp5cH6ePg0OB7Y+CFzjFTnZWBvTN2mtwzkIKQ BObhyObLlEt65nwRnA8nexE8LiBP8D9BAfg62OoUt8Fz5eVTTf3u24ymrTkPqVXM L3CXnln2y6GgBsfkPttQgPn8oKn5Lw== =Yh17 -----END PGP SIGNATURE----- --=-=-=--