unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Josh Marshall <joshua.r.marshall.1991@gmail.com>
To: Marius Bakke <marius@gnu.org>
Cc: 41345-done@debbugs.gnu.org
Subject: [bug#41345] 000-update-python-argon2-cffi.patch
Date: Mon, 25 May 2020 12:13:00 -0400	[thread overview]
Message-ID: <CAFkJGRciGh8irJ+H_qAEshZDxH8i9of_R_KK1WqkjaepRKJ7OQ@mail.gmail.com> (raw)
In-Reply-To: <87lflg6owx.fsf@gnu.org>

Here is what I'm doing:
```
git commit -am "Updating python-argon2-cffi to 20.1.0"
git format-patch master
git send-email --to=guix-patches@gnu.org
--subject="000-update-python-argon2-cffi.patch"
0001-Updating-python-argon2-cffi-to-20.1.0.patch
```

When reading https://guix.gnu.org/manual/en/guix.html#Submitting-Patches
I do not see guidance on this particular aspect of sending patches.
What do I need to alter, and should those details be added to the
manual?

On Mon, May 25, 2020 at 10:59 AM Marius Bakke <marius@gnu.org> wrote:
>
> Josh Marshall <joshua.r.marshall.1991@gmail.com> writes:
>
> > Resubmitted the patch more properly made.  Looks like it didn't continue
> > this thread.  How do I close this?
>
> It still did not have a commit message though:
>
> https://git.savannah.gnu.org/cgit/guix.git/log/gnu/packages?id=9813805b30dad444984111d5413b8ab7356f7908
>
> Note how it differs from other package updates, in particular lacking
> the '* gnu/packages/file.scm (variable):' line, as well as the "gnu: "
> prefix.  No big deal, but try to follow the convention next time.
>
> In any case you can close bugs by appending -done to the issue ID, like
> I've done in this message.  Thanks!




  reply	other threads:[~2020-05-25 16:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-17  4:20 [bug#41345] 000-update-python-argon2-cffi.patch Josh Marshall
2020-05-20 21:01 ` Marius Bakke
2020-05-20 21:07   ` Josh Marshall
2020-05-25 11:55     ` Josh Marshall
2020-05-25 14:59       ` bug#41345: 000-update-python-argon2-cffi.patch Marius Bakke
2020-05-25 16:13         ` Josh Marshall [this message]
2020-05-25 21:35           ` [bug#41345] 000-update-python-argon2-cffi.patch Marius Bakke
2020-05-25 22:39             ` Josh Marshall
2020-05-30 13:12               ` Marius Bakke
2020-05-30 16:49                 ` Josh Marshall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFkJGRciGh8irJ+H_qAEshZDxH8i9of_R_KK1WqkjaepRKJ7OQ@mail.gmail.com \
    --to=joshua.r.marshall.1991@gmail.com \
    --cc=41345-done@debbugs.gnu.org \
    --cc=marius@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).