From: "Ludovic Courtès" <ludo@gnu.org>
To: zimoun <zimon.toutoune@gmail.com>
Cc: 45893@debbugs.gnu.org
Subject: [bug#45893] [PATCH 0/2] DRAFT: Hint for options.
Date: Tue, 19 Jan 2021 18:38:01 +0100 [thread overview]
Message-ID: <87a6t4hlom.fsf_-_@gnu.org> (raw)
In-Reply-To: <20210116002634.10401-3-zimon.toutoune@gmail.com> (zimoun's message of "Sat, 16 Jan 2021 01:26:34 +0100")
zimoun <zimon.toutoune@gmail.com> skribis:
> * guix/ui.scm (run-guix-command): Add command hint.
[...]
> + (fold (lambda (name res)
> + (if (string-null? res)
> + (string-append "@code{" name "}")
> + (string-append "@code{" name "}, " res)))
> + ""
> + (string-closest (symbol->string guess) command-names)))
Hmm I thought ‘string-closest’ would return a single string, but
actually it returns a list of strings?
You cannot append strings together like this as this can break i18n.
The proper way would be to write:
"Do you mean one of these: ~a?"
but then, thinking about it, wouldn’t it be more natural to suggest a
single command rather than several?
Also, it seems to me that there’s always at least one hit, is that
correct? We should make sure that strings above a certain distance are
ignored, in which case there’s no hint to display.
Thanks!
Next up is package names, right? :-)
Ludo’.
next prev parent reply other threads:[~2021-01-19 17:54 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 16:37 [bug#45893] [PATCH 0/2] DRAFT: Hint for options zimoun
2021-01-15 16:39 ` [bug#45893] [PATCH 1/2] scripts: search, show: Replace 'args-fold*' by 'parse-command-line' zimoun
2021-01-15 16:39 ` [bug#45893] [PATCH 2/2] guix: scripts: Add hint for option typo zimoun
2021-01-19 17:20 ` [bug#45893] [PATCH 0/2] DRAFT: Hint for options Ludovic Courtès
2021-01-19 17:35 ` zimoun
2021-01-16 0:09 ` [bug#45893] [PATCH v2 0/3] DRAFT: Hint command line typo zimoun
2021-01-16 0:26 ` [bug#45893] [PATCH v2 1/3] scripts: search, show: Replace 'args-fold*' by 'parse-command-line' zimoun
2021-01-16 0:26 ` [bug#45893] [PATCH v2 2/3] guix: scripts: Add hint for option typo zimoun
2021-01-19 17:31 ` [bug#45893] [PATCH 0/2] DRAFT: Hint for options Ludovic Courtès
2021-01-16 0:26 ` [bug#45893] [PATCH v2 3/3] ui: Add command hint zimoun
2021-01-19 17:38 ` Ludovic Courtès [this message]
2021-01-19 18:01 ` [bug#45893] [PATCH 0/2] DRAFT: Hint for options zimoun
2021-01-26 20:53 ` Ludovic Courtès
2021-01-26 21:27 ` zimoun
2021-01-19 23:59 ` [bug#45893] Hint for package name: too slow! zimoun
2021-01-20 9:49 ` [bug#45893] Hint for package name: full matrix iteration zimoun
2021-01-26 21:00 ` [bug#45893] [PATCH 0/2] DRAFT: Hint for options Ludovic Courtès
2021-01-26 21:44 ` zimoun
2021-01-27 22:09 ` Ludovic Courtès
2021-01-19 21:28 ` [bug#45893] [PATCH v3 1/3] utils: Add string distance zimoun
2021-01-19 21:28 ` [bug#45893] [PATCH v3 2/3] guix: scripts: Add hint for option typo zimoun
2021-01-19 21:28 ` [bug#45893] [PATCH v3 3/3] ui: Add hint for command typo zimoun
2021-01-26 21:18 ` [bug#45893] [PATCH 0/2] DRAFT: Hint for options Ludovic Courtès
2021-01-26 21:20 ` Ludovic Courtès
2021-01-26 22:05 ` zimoun
2021-02-03 11:28 ` bug#45893: " Ludovic Courtès
2021-02-03 12:15 ` [bug#45893] " zimoun
[not found] ` <YBxQxSO57N4kV4N0@jasmine.lan>
[not found] ` <86tuqrbjxr.fsf@gmail.com>
2021-02-04 23:08 ` [bug#45893] Typo helper doesn't always know which command is missing zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6t4hlom.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=45893@debbugs.gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).