From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id UOfVGuEcB2B4XAAA0tVLHw (envelope-from ) for ; Tue, 19 Jan 2021 17:54:41 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id gO+XFuEcB2BvdAAA1q6Kng (envelope-from ) for ; Tue, 19 Jan 2021 17:54:41 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A2FC29403C5 for ; Tue, 19 Jan 2021 17:54:40 +0000 (UTC) Received: from localhost ([::1]:45668 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1vDB-0001jq-Nb for larch@yhetil.org; Tue, 19 Jan 2021 12:54:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33896) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1uy6-0007cN-Ti for guix-patches@gnu.org; Tue, 19 Jan 2021 12:39:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39951) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l1uy6-0000uZ-Jt for guix-patches@gnu.org; Tue, 19 Jan 2021 12:39:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l1uy6-0001wq-HB for guix-patches@gnu.org; Tue, 19 Jan 2021 12:39:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45893] [PATCH 0/2] DRAFT: Hint for options. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 19 Jan 2021 17:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45893 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Received: via spool by 45893-submit@debbugs.gnu.org id=B45893.16110779007440 (code B ref 45893); Tue, 19 Jan 2021 17:39:02 +0000 Received: (at 45893) by debbugs.gnu.org; 19 Jan 2021 17:38:20 +0000 Received: from localhost ([127.0.0.1]:51497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1uxQ-0001vv-9h for submit@debbugs.gnu.org; Tue, 19 Jan 2021 12:38:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1uxO-0001vj-Li for 45893@debbugs.gnu.org; Tue, 19 Jan 2021 12:38:18 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56985) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1uxJ-0000op-Er; Tue, 19 Jan 2021 12:38:13 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=48090 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l1ux9-0008KX-E8; Tue, 19 Jan 2021 12:38:12 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <865z3xlp2y.fsf@gmail.com> <20210116002634.10401-1-zimon.toutoune@gmail.com> <20210116002634.10401-3-zimon.toutoune@gmail.com> Date: Tue, 19 Jan 2021 18:38:01 +0100 In-Reply-To: <20210116002634.10401-3-zimon.toutoune@gmail.com> (zimoun's message of "Sat, 16 Jan 2021 01:26:34 +0100") Message-ID: <87a6t4hlom.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45893@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.85 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: A2FC29403C5 X-Spam-Score: -2.85 X-Migadu-Scanner: scn1.migadu.com X-TUID: KpVEpCYrwydz zimoun skribis: > * guix/ui.scm (run-guix-command): Add command hint. [...] > + (fold (lambda (name res) > + (if (string-null? res) > + (string-append "@code{" name "}") > + (string-append "@code{" name "}, " res))) > + "" > + (string-closest (symbol->string guess) command-names))) Hmm I thought =E2=80=98string-closest=E2=80=99 would return a single string= , but actually it returns a list of strings? You cannot append strings together like this as this can break i18n. The proper way would be to write: "Do you mean one of these: ~a?" but then, thinking about it, wouldn=E2=80=99t it be more natural to suggest= a single command rather than several? Also, it seems to me that there=E2=80=99s always at least one hit, is that correct? We should make sure that strings above a certain distance are ignored, in which case there=E2=80=99s no hint to display. Thanks! Next up is package names, right? :-) Ludo=E2=80=99.