From: "Ludovic Courtès" <ludo@gnu.org>
To: zimoun <zimon.toutoune@gmail.com>
Cc: 45893@debbugs.gnu.org
Subject: [bug#45893] [PATCH 0/2] DRAFT: Hint for options.
Date: Tue, 19 Jan 2021 18:31:25 +0100 [thread overview]
Message-ID: <87eeighlzm.fsf_-_@gnu.org> (raw)
In-Reply-To: <20210116002634.10401-2-zimon.toutoune@gmail.com> (zimoun's message of "Sat, 16 Jan 2021 01:26:33 +0100")
zimoun <zimon.toutoune@gmail.com> skribis:
> * guix/utils.scm (levenshtein-distance): New procedure.
> (string-closest): New procedure.
> * guix/scripts.scm (option-hint): New procedure.
> (parse-command-line): Add 'option-hint'.
Yay!
> +(define (option-hint guess options)
> + "Return the closest long-name from name based on Levenshtein distance."
> + (define (options->long-names options)
> + (fold (lambda (name res)
> + (match name
> + ((? char?) res)
> + ((? string?) (cons name res))))
> + '()
> + (fold append '() (map option-names options))))
I think this can be simplified a bit:
options->long-names = (filter string? (append-map option-names options))
> + (fold (lambda (name res)
> + (if (string-null? res)
> + (string-append "@code{" name "}")
> + (string-append "@code{" name "}, " res)))
> + ""
> + (string-closest guess (options->long-names options))))
> +
> (define (args-fold* args options unrecognized-option-proc operand-proc . seeds)
> "A wrapper on top of `args-fold' that does proper user-facing error
> reporting."
> @@ -149,6 +167,9 @@ parameter of 'args-fold'."
> ;; Actual parsing takes place here.
> (apply args-fold* args options
> (lambda (opt name arg . rest)
> + (display-hint
> + (format #f (G_ "Do you mean ~a?~%")
> + (option-hint name options)))
> (leave (G_ "~A: unrecognized option~%") name))
> argument-handler
> seeds))
[...]
> +(define (levenshtein-distance s1 s2)
> + "Compute the Levenshtein distance between two strings."
Maybe call it ‘string-distance’?
> + ;; Naive implemenation
> + (define loop
> + (memoize
> + (lambda (as bt)
Instead of (memoize (lambda …)), you can write:
(mlambda (str1 str2) …)
> + (match as
> + ('() (length bt))
The pattern for the empty list is (), not '().
How about making this addition to (guix utils) a commit of its own, and
to add a small test in tests/utils.scm?
> +(define (string-closest trial tests)
> + "Return the list from TESTS the closest from the string TRIAL based on
> +Levenshtein distance."
Maybe something like: “Return the string from TESTS that is the closest
from TRIAL, according to 'string-distance'.”
> + (match (fold (lambda (test res)
> + (let ((dist (levenshtein-distance trial test)))
> + (match res
> + ((val lst)
> + (if (< dist val)
> + (list dist (list test))
> + (if (= dist val)
> + (list dist (cons test lst))
> + res)))
> + (_ (list dist (list test))))))
> + '()
> + tests)
> + ((_ rest ...) (match rest ((head _ ...) head)))))
You can simplify this a bit by using ‘fold2’, which allows you to pass
two seeds instead of one:
(fold2 (lambda (test closest shortest-distance)
…)
"" +inf.0
tests)
It returns two values and the first one is the string.
Ludo’.
next prev parent reply other threads:[~2021-01-19 17:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 16:37 [bug#45893] [PATCH 0/2] DRAFT: Hint for options zimoun
2021-01-15 16:39 ` [bug#45893] [PATCH 1/2] scripts: search, show: Replace 'args-fold*' by 'parse-command-line' zimoun
2021-01-15 16:39 ` [bug#45893] [PATCH 2/2] guix: scripts: Add hint for option typo zimoun
2021-01-19 17:20 ` [bug#45893] [PATCH 0/2] DRAFT: Hint for options Ludovic Courtès
2021-01-19 17:35 ` zimoun
2021-01-16 0:09 ` [bug#45893] [PATCH v2 0/3] DRAFT: Hint command line typo zimoun
2021-01-16 0:26 ` [bug#45893] [PATCH v2 1/3] scripts: search, show: Replace 'args-fold*' by 'parse-command-line' zimoun
2021-01-16 0:26 ` [bug#45893] [PATCH v2 2/3] guix: scripts: Add hint for option typo zimoun
2021-01-19 17:31 ` Ludovic Courtès [this message]
2021-01-16 0:26 ` [bug#45893] [PATCH v2 3/3] ui: Add command hint zimoun
2021-01-19 17:38 ` [bug#45893] [PATCH 0/2] DRAFT: Hint for options Ludovic Courtès
2021-01-19 18:01 ` zimoun
2021-01-26 20:53 ` Ludovic Courtès
2021-01-26 21:27 ` zimoun
2021-01-19 23:59 ` [bug#45893] Hint for package name: too slow! zimoun
2021-01-20 9:49 ` [bug#45893] Hint for package name: full matrix iteration zimoun
2021-01-26 21:00 ` [bug#45893] [PATCH 0/2] DRAFT: Hint for options Ludovic Courtès
2021-01-26 21:44 ` zimoun
2021-01-27 22:09 ` Ludovic Courtès
2021-01-19 21:28 ` [bug#45893] [PATCH v3 1/3] utils: Add string distance zimoun
2021-01-19 21:28 ` [bug#45893] [PATCH v3 2/3] guix: scripts: Add hint for option typo zimoun
2021-01-19 21:28 ` [bug#45893] [PATCH v3 3/3] ui: Add hint for command typo zimoun
2021-01-26 21:18 ` [bug#45893] [PATCH 0/2] DRAFT: Hint for options Ludovic Courtès
2021-01-26 21:20 ` Ludovic Courtès
2021-01-26 22:05 ` zimoun
2021-02-03 11:28 ` bug#45893: " Ludovic Courtès
2021-02-03 12:15 ` [bug#45893] " zimoun
[not found] ` <YBxQxSO57N4kV4N0@jasmine.lan>
[not found] ` <86tuqrbjxr.fsf@gmail.com>
2021-02-04 23:08 ` [bug#45893] Typo helper doesn't always know which command is missing zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eeighlzm.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=45893@debbugs.gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).