From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: Christopher Howard <christopher@librehacker.com>
Cc: 51113@debbugs.gnu.org, jgart <jgart@dismail.de>,
51424-done@debbugs.gnu.org,
Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: [bug#51113] bug#51424: snooze: malformed installation path
Date: Wed, 27 Oct 2021 00:13:47 +0200 [thread overview]
Message-ID: <87a6ivl8u0.fsf@nckx> (raw)
In-Reply-To: <a3e7b60abcd46d1ac4e09168b52ae5f337f81c2b.camel@librehacker.com>
[-- Attachment #1: Type: text/plain, Size: 913 bytes --]
Christopher, jgart, Nicolas,
Christopher Howard 写道：
> the path to the binary is malformed:
Indeed it was.
DESTDIR does not mean ‘final destination’; it's meant as a
temporary install-time ‘staging’ directory whose contents are
expected to move back to / later. For example, ‘make install
DESTDIR=/tmp/my-package-manager-output && cd
/tmp/my-package-manager-output && tar cf foo.pkg .’. Guix does
not use this packaging method.
Setting DESTDIR in Guix is almost always a bug. The few places in
Guix where it is used are using it as a hack around buggy build
systems. It just happens to work (because, well, the build
system's buggy).
When reviewing patches, I find the ‘tree’ command very useful to
immediately spot such weirdness. Much more so than ‘ls -R’.
YMMV.
Fixed in commit 89d8417b371f3918f0508bbc561675ec100a6add.
Thanks!
T G-R
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]
next parent reply other threads:[~2021-10-26 22:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <a3e7b60abcd46d1ac4e09168b52ae5f337f81c2b.camel@librehacker.com>
2021-10-26 22:13 ` Tobias Geerinckx-Rice via Guix-patches via [this message]
2021-10-27 0:03 ` [bug#51113] bug#51424: snooze: malformed installation path jgart via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6ivl8u0.fsf@nckx \
--to=guix-patches@gnu.org \
--cc=51113@debbugs.gnu.org \
--cc=51424-done@debbugs.gnu.org \
--cc=christopher@librehacker.com \
--cc=jgart@dismail.de \
--cc=mail@nicolasgoaziou.fr \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).