unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: jgart via Guix-patches via <guix-patches@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: Christopher Howard <christopher@librehacker.com>,
	51113@debbugs.gnu.org, 51424-done@debbugs.gnu.org,
	Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: [bug#51113] bug#51424: snooze: malformed installation path
Date: Tue, 26 Oct 2021 20:03:22 -0400	[thread overview]
Message-ID: <20211026200322.GB9051@gac.attlocal.net> (raw)
In-Reply-To: <87a6ivl8u0.fsf@nckx>

On Wed, 27 Oct 2021 00:13:47 +0200 Tobias Geerinckx-Rice <me@tobias.gr> wrote:
> Christopher, jgart, Nicolas,
> 
> Christopher Howard 写道:
> > the path to the binary is malformed:
> 
> Indeed it was.
> 
> DESTDIR does not mean ‘final destination’; it's meant as a 
> temporary install-time ‘staging’ directory whose contents are 
> expected to move back to / later.  For example, ‘make install 
> DESTDIR=/tmp/my-package-manager-output && cd 
> /tmp/my-package-manager-output && tar cf foo.pkg .’.  Guix does 
> not use this packaging method.
> 
> Setting DESTDIR in Guix is almost always a bug.  The few places in 
> Guix where it is used are using it as a hack around buggy build 
> systems.  It just happens to work (because, well, the build 
> system's buggy).
> 
> Fixed in commit 89d8417b371f3918f0508bbc561675ec100a6add.
> 
> Thanks!
> 
> T G-R

> When reviewing patches, I find the ‘tree’ command very useful to 
> immediately spot such weirdness.  Much more so than ‘ls -R’. 
> YMMV.

I use nnn or another file manager like broot sometimes but this one escaped me.

Thanks for fixing that. I was actually going to send a patch fix for it but had 
not found the time. I noticed it after the patch was accepted.

Thanks!

all best,

jgart




      reply	other threads:[~2021-10-27  0:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <a3e7b60abcd46d1ac4e09168b52ae5f337f81c2b.camel@librehacker.com>
2021-10-26 22:13 ` [bug#51113] bug#51424: snooze: malformed installation path Tobias Geerinckx-Rice via Guix-patches via
2021-10-27  0:03   ` jgart via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211026200322.GB9051@gac.attlocal.net \
    --to=guix-patches@gnu.org \
    --cc=51113@debbugs.gnu.org \
    --cc=51424-done@debbugs.gnu.org \
    --cc=christopher@librehacker.com \
    --cc=jgart@dismail.de \
    --cc=mail@nicolasgoaziou.fr \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).