From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 59661-done@debbugs.gnu.org
Subject: bug#59661: [PATCH 0/3] Add e2fsprogs to %base-packages-utils.
Date: Mon, 05 Dec 2022 11:44:50 -0500 [thread overview]
Message-ID: <878rjl6br1.fsf_-_@gmail.com> (raw)
In-Reply-To: <877cz7m62b.fsf_-_@gnu.org> ("Ludovic Courtès"'s message of "Sun, 04 Dec 2022 18:28:44 +0100")
Hi,
Ludovic Courtès <ludo@gnu.org> writes:
> Ludovic Courtès <ludo@gnu.org> skribis:
>
>> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>>
>>> * gnu/system/install.scm (%installer-disk-utilities): Add e2fsprogs.
>>
>> LGTM!
>>
>> e2fsprogs binaries are indeed missing from $PATH in
>> guix-system-install-1.4.0rc1.*.iso; I’ll cherry-pick it on
>> ‘version-1.4.0’.
>>
>> What I don’t get is that our manual installation tests should have
>> caught this issue because they use ‘mkfs.ext4’ and expect to have it in
>> $PATH. I’ll take a look…
>
> Got it: Mathieu worked around it in
> 0f66ef9aa99d2043abccbc80d858bdeca57534ac by explicitly adding e2fsprogs
> and the installation system used by the tests:
>
> commit 0f66ef9aa99d2043abccbc80d858bdeca57534ac
> Author: Mathieu Othacehe <othacehe@gnu.org>
> Date: Fri Sep 30 15:19:36 2022 +0200
>
> tests: install: Fix iso-image-installer test.
>
> This is a follow-up of: 45eac6cdf5c8d9d7b0c564b105c790d2d2007799.
> It fixes the following error:
>
> + mkfs.ext4 -L my-root /dev/vda2
> sh: line 12: mkfs.ext4: command not found
>
> * gnu/tests/install.scm (%test-iso-image-installer): Add e2fsprogs to the
> appended packages.
>
> We should be able to revert this commit once the installer provides
> e2fsprogs by default.
I applied this series, reverted 0f66ef9aa99d2043abccbc80d858bdeca57534ac
as suggested above, ran:
--8<---------------cut here---------------start------------->8---
make check-system TESTS=iso-image-installer
--8<---------------cut here---------------end--------------->8---
And pushed!
Closing.
--
Thanks,
Maxim
next prev parent reply other threads:[~2022-12-05 16:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 19:18 [bug#59661] [PATCH 0/3] Add e2fsprogs to %base-packages-utils Maxim Cournoyer
2022-11-28 20:01 ` [bug#59661] [PATCH 1/3] system: Rename and move %base-packages-disk-utilities Maxim Cournoyer
2022-11-28 20:01 ` [bug#59661] [PATCH 2/3] install: Add missing e2fsprogs utility Maxim Cournoyer
2022-11-28 20:01 ` [bug#59661] [PATCH 3/3] system: Add e2fsprogs to %base-packages-utils Maxim Cournoyer
2022-12-04 4:43 ` [bug#59661] [PATCH v2 1/3] system: Rename and move %base-packages-disk-utilities Maxim Cournoyer
2022-12-04 4:43 ` [bug#59661] [PATCH v2 2/3] install: Add missing e2fsprogs utility Maxim Cournoyer
2022-12-04 16:34 ` Ludovic Courtès
2022-12-04 17:28 ` [bug#59661] [PATCH 0/3] Add e2fsprogs to %base-packages-utils Ludovic Courtès
2022-12-05 16:44 ` Maxim Cournoyer [this message]
2022-12-04 4:43 ` [bug#59661] [PATCH v2 3/3] system: " Maxim Cournoyer
2022-12-04 16:36 ` Ludovic Courtès
2022-12-04 16:20 ` [bug#59661] [PATCH v2 1/3] system: Rename and move %base-packages-disk-utilities Ludovic Courtès
2022-12-04 21:38 ` Maxim Cournoyer
2022-12-05 15:32 ` [bug#59661] [PATCH 0/3] Add e2fsprogs to %base-packages-utils Ludovic Courtès
2022-12-05 10:36 ` [bug#59661] [PATCH v2 1/3] system: Rename and move %base-packages-disk-utilities Efraim Flashner
2022-12-05 15:30 ` Maxim Cournoyer
2022-12-05 15:34 ` [bug#59661] [PATCH 0/3] Add e2fsprogs to %base-packages-utils Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rjl6br1.fsf_-_@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=59661-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).