From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id MPDmNCggjmMnUQAAbAwnHQ (envelope-from ) for ; Mon, 05 Dec 2022 17:45:28 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id yEf3NCggjmOhNwEA9RJhRA (envelope-from ) for ; Mon, 05 Dec 2022 17:45:28 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A4AF32151C for ; Mon, 5 Dec 2022 17:45:28 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2EaY-0006nm-89; Mon, 05 Dec 2022 11:45:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2EaV-0006km-Gp for guix-patches@gnu.org; Mon, 05 Dec 2022 11:45:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p2EaV-0007a8-4P for guix-patches@gnu.org; Mon, 05 Dec 2022 11:45:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p2EaU-0005FC-Vk for guix-patches@gnu.org; Mon, 05 Dec 2022 11:45:02 -0500 Subject: bug#59661: [PATCH 0/3] Add e2fsprogs to %base-packages-utils. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Mon, 05 Dec 2022 16:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 59661 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: moreinfo patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 59661-done@debbugs.gnu.org Mail-Followup-To: 59661@debbugs.gnu.org, maxim.cournoyer@gmail.com, maxim.cournoyer@gmail.com Received: via spool by 59661-done@debbugs.gnu.org id=D59661.167025869920000 (code D ref 59661); Mon, 05 Dec 2022 16:45:02 +0000 Received: (at 59661-done) by debbugs.gnu.org; 5 Dec 2022 16:44:59 +0000 Received: from localhost ([127.0.0.1]:37126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2EaR-0005CW-DD for submit@debbugs.gnu.org; Mon, 05 Dec 2022 11:44:59 -0500 Received: from mail-qk1-f170.google.com ([209.85.222.170]:37629) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2EaP-0005CO-R9 for 59661-done@debbugs.gnu.org; Mon, 05 Dec 2022 11:44:58 -0500 Received: by mail-qk1-f170.google.com with SMTP id x18so5417676qki.4 for <59661-done@debbugs.gnu.org>; Mon, 05 Dec 2022 08:44:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=l+8Yb34DPcZsost6NhXmk2NoV0RSXNz/XEWIqFvWp5U=; b=T+/sNJ1dsEYGgPl65A0+0aXM4TxgPaTf1ZIx1bRtTxvUxnFXG5t2dfpL0nVIj8q87w 90wkLiCukRGIB2Z1sAsIUtFtaUI0O1HP3sIEkOgtit65ozktsR/c1S5B/03bML8tKpl1 fZ0R6DAOvAyFsAVbYMVd8+tdFNCCIcvSekkzuokQF889zUKxO/2gA+wQW91GT3bsfSOT Iske0bFwNK2oVqMf0npk72n0MKapfIVBOX/Ue5EsGtah3fyHIWBbIzgIX+LXIuIJzZky xpCR6PcHc1bJdaA3/IWeb7rcWNjL1/yJWo9tJ+rMJiaxjgLaw//MBUH++3MIX9SIJJFN kyDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=l+8Yb34DPcZsost6NhXmk2NoV0RSXNz/XEWIqFvWp5U=; b=QH0guvsTn0Ih8Gw+n1UAVz4S+Kjd/LSRT4Zt2W3ROE0hG+rqcnJ3e3D8tNaFNYzK9J g+/WSbmXOgXjRulQN6DgDrBBRSnJdbytwT4hoEXdiApP+fxPLMdCnW6aEY3Z6OtFHeZY D2rcdTEyMN0Mt4oxsqy5yNEikmbv5CQHkW7tlTYKV331JY7WBZSOLvzsJC56olrLvc5a yf6JypJMMpgj2yVGIWEyNGVRVMIY36C0tA+5eft/+uV/PcP/KKYB5Uan4x4W6ysuRE2k BNOG+FOxQ6MN9U0npISE0Aq/QJv+6JPHms99n9Em1IXl7gWWvHryIKGbpNc6rcvm6GC+ IzCg== X-Gm-Message-State: ANoB5pk/m+yi2K7RxTOfXbUeOtJEPKXBgnoLDqAJOu1ohVP9I1oZfd1x ouPNHL1uJsKy99UGDNSPGe6gqlYpVa4= X-Google-Smtp-Source: AA0mqf56wIFhZz0P44fkTFYRo2rorX7HvlA3Ke1ccVWCYULtgx+lZ4fVaRz8hjOiXTTPOYvJMZE4bQ== X-Received: by 2002:a05:620a:a5e:b0:6ef:166e:f070 with SMTP id j30-20020a05620a0a5e00b006ef166ef070mr56606551qka.56.1670258692187; Mon, 05 Dec 2022 08:44:52 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1003]) by smtp.gmail.com with ESMTPSA id do22-20020a05620a2b1600b006fcc3858044sm6517220qkb.86.2022.12.05.08.44.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Dec 2022 08:44:51 -0800 (PST) From: Maxim Cournoyer References: <20221204044347.23147-1-maxim.cournoyer@gmail.com> <20221204044347.23147-2-maxim.cournoyer@gmail.com> <87wn77m8kw.fsf@gnu.org> <877cz7m62b.fsf_-_@gnu.org> Date: Mon, 05 Dec 2022 11:44:50 -0500 In-Reply-To: <877cz7m62b.fsf_-_@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sun, 04 Dec 2022 18:28:44 +0100") Message-ID: <878rjl6br1.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670258728; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=l+8Yb34DPcZsost6NhXmk2NoV0RSXNz/XEWIqFvWp5U=; b=rWaN5RnY8WeCeGIIq0ZJKJ0bbQKlZQ/NknHNoW8ykRc4WZgSQAsfTDsmvQU40WZPGdqLs5 Y2mHYhlr2tQa6oD4PQEPdpGRRhD9QtQjGdvcjyTR9NuivXfT9cJMlm3foBeyBnJPZW+iX/ RvF371lSNGxK53uZZASKEQH79mid/NstQV5oVdGs3N1ruqUVy6iQj684SA6sRVdLfzIcZY sVy0fSHjyEAJ0/o75gxxCg86h76lEppTbA+lbpZnfQbpwTdRkB4hmzSu5caJgC3njuZQ+C ROPqSnkwn8hbl08rQsCa2gbDABuqW5PbhR9WVJXGVws4+1THcaLhEw9mC/MeRQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670258728; a=rsa-sha256; cv=none; b=qU4Vz6Ux7W7+9Um7F/GNr2dkz99vbygwdKwOva6N9uTdQYRoH8wibKNfk0m99ztSXbQ6Vk 95UW1nfocObMqfP+SCey6Z9k6NURa5SaGBbJwF509AIJFlwYheN1va9/U4YdjZqJCUNHep dMZJ8aAqlUNb4xB5Zyn6E1yaYiWGtxD2Yp7Z1acu76OO+wBcYX+X6Ql2vNEjywyJpyeUk0 CkiI/tCMl1FszbIovs3q2w3Bk6TzP6xUWnvnJMVwPd56SsPHoYFr16BDpNSxjLUdJLbebq KO2vcBlcU3K8G1TerxUDIgUg5zBQWnjKAZXXo2a4E79nZeYt3kVmxzj6pHV8cQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="T+/sNJ1d"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.23 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="T+/sNJ1d"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A4AF32151C X-Spam-Score: 5.23 X-Migadu-Scanner: scn0.migadu.com X-TUID: Rl3r5mg1N18N Hi, Ludovic Court=C3=A8s writes: > Ludovic Court=C3=A8s skribis: > >> Maxim Cournoyer skribis: >> >>> * gnu/system/install.scm (%installer-disk-utilities): Add e2fsprogs. >> >> LGTM! >> >> e2fsprogs binaries are indeed missing from $PATH in >> guix-system-install-1.4.0rc1.*.iso; I=E2=80=99ll cherry-pick it on >> =E2=80=98version-1.4.0=E2=80=99. >> >> What I don=E2=80=99t get is that our manual installation tests should ha= ve >> caught this issue because they use =E2=80=98mkfs.ext4=E2=80=99 and expec= t to have it in >> $PATH. I=E2=80=99ll take a look=E2=80=A6 > > Got it: Mathieu worked around it in > 0f66ef9aa99d2043abccbc80d858bdeca57534ac by explicitly adding e2fsprogs > and the installation system used by the tests: > > commit 0f66ef9aa99d2043abccbc80d858bdeca57534ac > Author: Mathieu Othacehe > Date: Fri Sep 30 15:19:36 2022 +0200 > > tests: install: Fix iso-image-installer test. > > This is a follow-up of: 45eac6cdf5c8d9d7b0c564b105c790d2d2007799. > It fixes the following error: > > + mkfs.ext4 -L my-root /dev/vda2 > sh: line 12: mkfs.ext4: command not found > > * gnu/tests/install.scm (%test-iso-image-installer): Add e2fsprogs = to the > appended packages. > > We should be able to revert this commit once the installer provides > e2fsprogs by default. I applied this series, reverted 0f66ef9aa99d2043abccbc80d858bdeca57534ac as suggested above, ran: --8<---------------cut here---------------start------------->8--- make check-system TESTS=3Diso-image-installer --8<---------------cut here---------------end--------------->8--- And pushed! Closing. --=20 Thanks, Maxim