unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 59661@debbugs.gnu.org, Efraim Flashner <efraim@flashner.co.il>
Subject: [bug#59661] [PATCH v2 1/3] system: Rename and move %base-packages-disk-utilities.
Date: Sun, 04 Dec 2022 17:20:42 +0100	[thread overview]
Message-ID: <875yernns5.fsf@gnu.org> (raw)
In-Reply-To: <20221204044347.23147-1-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Sat, 3 Dec 2022 23:43:45 -0500")

Hi,

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> Rationale: It is only used in INSTALLATION-OS and doesn't make sense to be
> used in another context, given that file systems now automatically pull their
> dependencies since commit 45eac6cdf5c8d9d7b0c564b105c790d2d2007799 (services:
> Add file system utilities to profile).
>
> * gnu/system.scm (%base-packages-disk-utilities): Deprecate and rename to...
> * gnu/system/install.scm (%installer-disk-utilities): ... this.
> (installation-os) [packages]: Adjust accordingly.

Efraim, this variable was added in
e6e076281e62518056987e9ddd3d96fccab20475 and used in
4170af491c8bc3b0a5308116a26e758d8ff245c5; do you think it’s okay to
remove now?  (It LGTM, but I’d like to make sure we don’t create churn.)

> +(define-deprecated %base-packages-disk-utilities #f '())

‘#f’ here would lead to weird deprecation messages.  I’d make it:

  (define-deprecated %base-packages-disk-utilities %base-packages '())

This is not quite accurate but it should convey the idea.

Thanks,
Ludo’.




  parent reply	other threads:[~2022-12-04 16:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-28 19:18 [bug#59661] [PATCH 0/3] Add e2fsprogs to %base-packages-utils Maxim Cournoyer
2022-11-28 20:01 ` [bug#59661] [PATCH 1/3] system: Rename and move %base-packages-disk-utilities Maxim Cournoyer
2022-11-28 20:01   ` [bug#59661] [PATCH 2/3] install: Add missing e2fsprogs utility Maxim Cournoyer
2022-11-28 20:01   ` [bug#59661] [PATCH 3/3] system: Add e2fsprogs to %base-packages-utils Maxim Cournoyer
2022-12-04  4:43 ` [bug#59661] [PATCH v2 1/3] system: Rename and move %base-packages-disk-utilities Maxim Cournoyer
2022-12-04  4:43   ` [bug#59661] [PATCH v2 2/3] install: Add missing e2fsprogs utility Maxim Cournoyer
2022-12-04 16:34     ` Ludovic Courtès
2022-12-04 17:28       ` [bug#59661] [PATCH 0/3] Add e2fsprogs to %base-packages-utils Ludovic Courtès
2022-12-05 16:44         ` bug#59661: " Maxim Cournoyer
2022-12-04  4:43   ` [bug#59661] [PATCH v2 3/3] system: " Maxim Cournoyer
2022-12-04 16:36     ` Ludovic Courtès
2022-12-04 16:20   ` Ludovic Courtès [this message]
2022-12-04 21:38     ` [bug#59661] [PATCH v2 1/3] system: Rename and move %base-packages-disk-utilities Maxim Cournoyer
2022-12-05 15:32       ` [bug#59661] [PATCH 0/3] Add e2fsprogs to %base-packages-utils Ludovic Courtès
2022-12-05 10:36     ` [bug#59661] [PATCH v2 1/3] system: Rename and move %base-packages-disk-utilities Efraim Flashner
2022-12-05 15:30       ` Maxim Cournoyer
2022-12-05 15:34       ` [bug#59661] [PATCH 0/3] Add e2fsprogs to %base-packages-utils Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875yernns5.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=59661@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).