From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpzSR-0005ce-MT for guix-patches@gnu.org; Thu, 07 Sep 2017 12:15:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dpzSI-0003Uz-5p for guix-patches@gnu.org; Thu, 07 Sep 2017 12:15:11 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:45845) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dpzSI-0003Ui-2B for guix-patches@gnu.org; Thu, 07 Sep 2017 12:15:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dpzSH-0003II-Pm for guix-patches@gnu.org; Thu, 07 Sep 2017 12:15:01 -0400 Subject: [bug#27905] changes for openmpi Resent-Message-ID: From: Dave Love References: <87zibja1of.fsf@i-ulialbion.it.manchester.ac.uk> <87h8x1t0op.fsf@gnu.org> <87d17aznix.fsf@albion.it.manchester.ac.uk> <873782xzxb.fsf@inria.fr> Date: Thu, 07 Sep 2017 17:14:43 +0100 In-Reply-To: <873782xzxb.fsf@inria.fr> ("Ludovic \=\?iso-8859-1\?Q\?Court\=E8s\?\= \=\?iso-8859-1\?Q\?\=22's\?\= message of "Mon, 4 Sep 2017 17:10:24 +0200") Message-ID: <877exaqydo.fsf@albion.it.manchester.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 27905@debbugs.gnu.org Ludovic Court=C3=A8s writes: >>> Also, I assume that this is functionally equivalent to Open MPI=E2=80= =99s >>> built-in Valgrind support, is it? >> >> This is probably moot. It isn't entirely equivalent but, more >> importantly, the builtin support apparently doesn't have the performance >> hit which was documented; I haven't checked experimentally. See this >> thread, though not all my questions were answered: >> . >> >> The wrapper library may still be relevant for mpich-y MPIs, if they get >> used -- I don't know. > > OK. > > So to me that means we can apply the patch below and be done with it. > Fine with you? No, I now think it shouldn't be changed, since the valgrind integration is supposed not to impose a significant speed penalty, and I can remove valgrind from the closure simply. I'll send a new patch later. > Thanks, > Ludo=E2=80=99. > > > diff --git a/gnu/packages/mpi.scm b/gnu/packages/mpi.scm > index 93157e269..ded9d4fda 100644 > --- a/gnu/packages/mpi.scm > +++ b/gnu/packages/mpi.scm > @@ -36,8 +36,7 @@ > #:use-module (gnu packages xml) > #:use-module (gnu packages perl) > #:use-module (gnu packages ncurses) > - #:use-module (gnu packages pkg-config) > - #:use-module (gnu packages valgrind)) > + #:use-module (gnu packages pkg-config)) >=20=20 > (define-public hwloc > (package > @@ -126,8 +125,7 @@ bind processes, and much more.") > `(("hwloc" ,hwloc "lib") > ("gfortran" ,gfortran) > ("libfabric" ,libfabric) > - ("rdma-core" ,rdma-core) > - ("valgrind" ,valgrind))) > + ("rdma-core" ,rdma-core))) > (native-inputs > `(("pkg-config" ,pkg-config) > ("perl" ,perl))) > @@ -142,8 +140,6 @@ bind processes, and much more.") > ;; it reduces the closure size considerably. > "--disable-vt" >=20=20 > - ,(string-append "--with-valgrind=3D" > - (assoc-ref %build-inputs "val= grind")) > ,(string-append "--with-hwloc=3D" > (assoc-ref %build-inputs "hwl= oc"))) > #:phases (modify-phases %standard-phases