From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:57805)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFf8W-0004bc-Bi
 for guix-patches@gnu.org; Sat, 21 Mar 2020 10:30:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFf8V-0001Hs-FS
 for guix-patches@gnu.org; Sat, 21 Mar 2020 10:30:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:41805)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jFf8V-0001H1-Bt
 for guix-patches@gnu.org; Sat, 21 Mar 2020 10:30:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFf8V-0000q9-5e
 for guix-patches@gnu.org; Sat, 21 Mar 2020 10:30:03 -0400
Subject: bug#40143: [PATCH] gnu: git: Return #t in install-man-pages phase.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.40143.D40143.15848010013192.done@debbugs.gnu.org>
References: <20200320092005.22388-1-brice@waegenei.re>
 <20200320105406.42ba348b@scratchpost.org> <87blor3y5h.fsf@gmail.com>
From: Mathieu Othacehe <m.othacehe@gmail.com>
In-reply-to: <87blor3y5h.fsf@gmail.com>
Date: Sat, 21 Mar 2020 15:29:52 +0100
Message-ID: <877dzdkcgv.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Brice Waegeneire <brice@waegenei.re>
Cc: Danny Milosavljevic <dannym@scratchpost.org>, 40143-close@debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer@gmail.com>


Hello Brice,

> Danny Milosavljevic <dannym@scratchpost.org> writes:
>
>> invoke already returns #t, so there's no technical bug.
>>
>> That said, maybe for clarity?  Not sure...

I agree with Danny and Maxim here, we already return a boolean, or
raise an exception in case of error, so I think we are fine :)

Closing this bug,

Thanks,

Mathieu