* [bug#39786] [PATCH] Add dragonfly-reverb.
@ 2020-02-25 15:20 Alexandros Theodotou
[not found] ` <handler.39786.B.158264402116627.ack@debbugs.gnu.org>
2020-03-21 16:46 ` [bug#39786] [PATCH] Add dragonfly-reverb Nicolas Goaziou
0 siblings, 2 replies; 5+ messages in thread
From: Alexandros Theodotou @ 2020-02-25 15:20 UTC (permalink / raw)
To: 39786
[-- Attachment #1.1: Type: text/plain, Size: 181 bytes --]
Hi,
This patch adds dragonfly reverb, a popular reverb plugin.
Unfortunately it doesn't have an install target so I resorted to
copying the files manually.
Thanks,
Alex
[-- Attachment #1.2: 0001-gnu-Add-dragonfly-reverb.patch --]
[-- Type: text/x-patch, Size: 3195 bytes --]
From 579ca84415b1ab63102896e3717454a13d18ae5d Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex@zrythm.org>
Date: Tue, 25 Feb 2020 15:17:10 +0000
Subject: [PATCH] gnu: Add dragonfly-reverb
* gnu/packages/music.scm (dragonfly-reverb): New variable.
---
gnu/packages/music.scm | 65 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 65 insertions(+)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 16e69840df..4d9ad04fe9 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -5189,3 +5189,68 @@ featureful and easy to use. It offers unlimited automation options, LV2
plugin support, JACK support and chord assistance.")
(home-page "https://www.zrythm.org")
(license license:agpl3+)))
+
+(define-public dragonfly-reverb
+ (package
+ (name "dragonfly-reverb")
+ (version "2.0.0")
+ (source
+ (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://github.com/michaelwillis/dragonfly-reverb.git")
+ (commit version)
+ ;; bundles a specific commit of the DISTRHO plugin framework
+ (recursive? #t)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "1qrbv4kk5v6ynx424h1i54qj0w8v6vpw81b759jawxvzzprpgq72"))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:tests? #f ; no check target
+ #:make-flags (list "CC=gcc")
+ #:phases
+ (modify-phases %standard-phases
+ (delete 'configure) ; no configure target
+ (replace 'install ; no install target
+ (lambda* (#:key inputs outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (bin (string-append out "/bin"))
+ (vst (string-append out "/lib/vst"))
+ (lv2 (string-append out "/lib/lv2")))
+ (mkdir-p bin)
+ (mkdir-p vst)
+ (mkdir-p lv2)
+
+ ;; Install VST
+ (for-each
+ (lambda (file)
+ (install-file file vst))
+ (find-files "bin" "\\-vst.so$"))
+
+ ;; Install LV2
+ (for-each
+ (lambda (file)
+ (copy-recursively file (string-append lv2 "/"
+ (basename file))))
+ (find-files "bin" "\\.lv2$" #:directories? #t))
+
+ ;; Install standalone
+ (install-file "bin/DragonflyRoomReverb" bin)
+ (install-file "bin/DragonflyHallReverb" bin)
+ #t))))))
+ (inputs
+ `(("jack" ,jack-1)
+ ("libx11" ,libx11)
+ ("mesa" ,mesa)))
+ (native-inputs
+ `(("lv2" ,lv2)
+ ("pkg-config" ,pkg-config)))
+ (synopsis "Concert hall reverb and room reverb effects")
+ (description
+ "Dragonfly Reverb is a bundle of two free audio effects: a concert
+hall reverb and a room reverb. Both are available as VST and LV2 plugins,
+as well as JACK standalone applications.")
+ (home-page "https://michaelwillis.github.io/dragonfly-reverb/")
+ (license license:gpl3+)))
--
2.25.1
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply related [flat|nested] 5+ messages in thread[parent not found: <handler.39786.B.158264402116627.ack@debbugs.gnu.org>]
* [bug#39786] Acknowledgement ([PATCH] Add dragonfly-reverb.)
[not found] ` <handler.39786.B.158264402116627.ack@debbugs.gnu.org>
@ 2020-02-26 21:49 ` Alexandros Theodotou
0 siblings, 0 replies; 5+ messages in thread
From: Alexandros Theodotou @ 2020-02-26 21:49 UTC (permalink / raw)
To: 39786
[-- Attachment #1.1: Type: text/plain, Size: 595 bytes --]
I have removed VST because it is not really necessary. This now only
outputs LV2 and standalone versions.
To test that the plugin works, you can run the following if you already
have JACK running:
LV2_PATH=/gnu/store/xbhdmal9ybvw8yrynmimmj0z9cg2v6aj-dragonfly-reverb-
2.0.0/lib/lv2 jalv.gtk3 urn:dragonfly:room
LV2_PATH=/gnu/store/xbhdmal9ybvw8yrynmimmj0z9cg2v6aj-dragonfly-reverb-2.0.0/lib/lv2 jalv.gtk3 https://github.com/michaelwillis/dragonfly-reverb
If you don't have JACK running (most likely case), you can run a dummy
server temporarily with `jackd -ddummy`.
Thanks,
Alex
[-- Attachment #1.2: 0001-gnu-Add-dragonfly-reverb.patch --]
[-- Type: text/x-patch, Size: 2904 bytes --]
From 619221725965d5046161ca4c49cc214d25744245 Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex@zrythm.org>
Date: Tue, 25 Feb 2020 15:17:10 +0000
Subject: [PATCH] gnu: Add dragonfly-reverb
* gnu/packages/music.scm (dragonfly-reverb): New variable.
---
gnu/packages/music.scm | 55 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 55 insertions(+)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 16e69840df..21825ef333 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -5189,3 +5189,58 @@ featureful and easy to use. It offers unlimited automation options, LV2
plugin support, JACK support and chord assistance.")
(home-page "https://www.zrythm.org")
(license license:agpl3+)))
+
+(define-public dragonfly-reverb
+ (package
+ (name "dragonfly-reverb")
+ (version "2.0.0")
+ (source
+ (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://github.com/michaelwillis/dragonfly-reverb.git")
+ (commit version)
+ ;; bundles a specific commit of the DISTRHO plugin framework
+ (recursive? #t)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "1qrbv4kk5v6ynx424h1i54qj0w8v6vpw81b759jawxvzzprpgq72"))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:tests? #f ; no check target
+ #:make-flags (list "CC=gcc")
+ #:phases
+ (modify-phases %standard-phases
+ (delete 'configure) ; no configure target
+ (replace 'install ; no install target
+ (lambda* (#:key inputs outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (bin (string-append out "/bin"))
+ (lv2 (string-append out "/lib/lv2")))
+ (mkdir-p bin)
+ (mkdir-p lv2)
+ ;; Install LV2
+ (for-each
+ (lambda (file)
+ (copy-recursively file (string-append lv2 "/"
+ (basename file))))
+ (find-files "bin" "\\.lv2$" #:directories? #t))
+ ;; Install standalone
+ (install-file "bin/DragonflyRoomReverb" bin)
+ (install-file "bin/DragonflyHallReverb" bin)
+ #t))))))
+ (inputs
+ `(("jack" ,jack-1)
+ ("libx11" ,libx11)
+ ("mesa" ,mesa)))
+ (native-inputs
+ `(("lv2" ,lv2)
+ ("pkg-config" ,pkg-config)))
+ (synopsis "Concert hall reverb and room reverb effects")
+ (description
+ "Dragonfly Reverb is a bundle of two free audio effects: a concert
+hall reverb and a room reverb. Both are available as LV2 plugins as well
+as JACK standalone applications.")
+ (home-page "https://michaelwillis.github.io/dragonfly-reverb/")
+ (license license:gpl3+)))
--
2.25.1
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#39786] [PATCH] Add dragonfly-reverb.
2020-02-25 15:20 [bug#39786] [PATCH] Add dragonfly-reverb Alexandros Theodotou
[not found] ` <handler.39786.B.158264402116627.ack@debbugs.gnu.org>
@ 2020-03-21 16:46 ` Nicolas Goaziou
2020-03-21 19:09 ` Alexandros Theodotou
1 sibling, 1 reply; 5+ messages in thread
From: Nicolas Goaziou @ 2020-03-21 16:46 UTC (permalink / raw)
To: Alexandros Theodotou; +Cc: 39786
Hello,
Alexandros Theodotou <alex@zrythm.org> writes:
> This patch adds dragonfly reverb, a popular reverb plugin.
Thank you!
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out"))
> + (bin (string-append out "/bin"))
> + (vst (string-append out "/lib/vst"))
> + (lv2 (string-append out "/lib/lv2")))
> + (mkdir-p bin)
> + (mkdir-p vst)
> + (mkdir-p lv2)
> +
> + ;; Install VST
> + (for-each
> + (lambda (file)
> + (install-file file vst))
> + (find-files "bin" "\\-vst.so$"))
Since you use `install-file' you don't need to `mkdir-p' beforehand,
i.e., you can drop (mkdir-p vst) above.
> + ;; Install standalone
> + (install-file "bin/DragonflyRoomReverb" bin)
> + (install-file "bin/DragonflyHallReverb" bin)
Ditto, you can drop (mkdir-p bin).
> + #t))))))
> + (inputs
> + `(("jack" ,jack-1)
> + ("libx11" ,libx11)
> + ("mesa" ,mesa)))
> + (native-inputs
> + `(("lv2" ,lv2)
> + ("pkg-config" ,pkg-config)))
> + (synopsis "Concert hall reverb and room reverb effects")
> + (description
> + "Dragonfly Reverb is a bundle of two free audio effects: a concert
> +hall reverb and a room reverb. Both are available as VST and LV2 plugins,
You need to add two spaces after full stops.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 5+ messages in thread* [bug#39786] [PATCH] Add dragonfly-reverb.
2020-03-21 16:46 ` [bug#39786] [PATCH] Add dragonfly-reverb Nicolas Goaziou
@ 2020-03-21 19:09 ` Alexandros Theodotou
2020-03-21 20:55 ` bug#39786: " Nicolas Goaziou
0 siblings, 1 reply; 5+ messages in thread
From: Alexandros Theodotou @ 2020-03-21 19:09 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: 39786
[-- Attachment #1.1: Type: text/plain, Size: 1951 bytes --]
Hi,
Thanks for the feedback.
Attaching the updated patch. I also removed some unneeded dependencies.
Thanks,
Alex
2020-03-21 (土) の 17:46 +0100 に Nicolas Goaziou さんは書きました:
> Hello,
>
> Alexandros Theodotou <alex@zrythm.org> writes:
>
> > This patch adds dragonfly reverb, a popular reverb plugin.
>
> Thank you!
>
> > + (lambda* (#:key inputs outputs #:allow-other-keys)
> > + (let* ((out (assoc-ref outputs "out"))
> > + (bin (string-append out "/bin"))
> > + (vst (string-append out "/lib/vst"))
> > + (lv2 (string-append out "/lib/lv2")))
> > + (mkdir-p bin)
> > + (mkdir-p vst)
> > + (mkdir-p lv2)
> > +
> > + ;; Install VST
> > + (for-each
> > + (lambda (file)
> > + (install-file file vst))
> > + (find-files "bin" "\\-vst.so$"))
>
> Since you use `install-file' you don't need to `mkdir-p' beforehand,
> i.e., you can drop (mkdir-p vst) above.
>
> > + ;; Install standalone
> > + (install-file "bin/DragonflyRoomReverb" bin)
> > + (install-file "bin/DragonflyHallReverb" bin)
>
> Ditto, you can drop (mkdir-p bin).
>
> > + #t))))))
> > + (inputs
> > + `(("jack" ,jack-1)
> > + ("libx11" ,libx11)
> > + ("mesa" ,mesa)))
> > + (native-inputs
> > + `(("lv2" ,lv2)
> > + ("pkg-config" ,pkg-config)))
> > + (synopsis "Concert hall reverb and room reverb effects")
> > + (description
> > + "Dragonfly Reverb is a bundle of two free audio effects: a
> > concert
> > +hall reverb and a room reverb. Both are available as VST and LV2
> > plugins,
>
> You need to add two spaces after full stops.
>
> Could you send an updated patch?
>
> Regards,
>
[-- Attachment #1.2: 0001-gnu-Add-dragonfly-reverb.patch --]
[-- Type: text/x-patch, Size: 2824 bytes --]
From 194140d3bb34df369c585968c5ee2c93a4b41f15 Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex@zrythm.org>
Date: Tue, 25 Feb 2020 15:17:10 +0000
Subject: [PATCH] gnu: Add dragonfly-reverb
* gnu/packages/music.scm (dragonfly-reverb): New variable.
---
gnu/packages/music.scm | 52 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 52 insertions(+)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 16e69840df..1bdd905f77 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -5189,3 +5189,55 @@ featureful and easy to use. It offers unlimited automation options, LV2
plugin support, JACK support and chord assistance.")
(home-page "https://www.zrythm.org")
(license license:agpl3+)))
+
+(define-public dragonfly-reverb
+ (package
+ (name "dragonfly-reverb")
+ (version "2.0.0")
+ (source
+ (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://github.com/michaelwillis/dragonfly-reverb.git")
+ (commit version)
+ ;; bundles a specific commit of the DISTRHO plugin framework
+ (recursive? #t)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "1qrbv4kk5v6ynx424h1i54qj0w8v6vpw81b759jawxvzzprpgq72"))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:tests? #f ; no check target
+ #:make-flags (list "CC=gcc")
+ #:phases
+ (modify-phases %standard-phases
+ (delete 'configure) ; no configure target
+ (replace 'install ; no install target
+ (lambda* (#:key inputs outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (bin (string-append out "/bin"))
+ (lv2 (string-append out "/lib/lv2")))
+ ;; Install LV2
+ (for-each
+ (lambda (file)
+ (copy-recursively file (string-append lv2 "/"
+ (basename file))))
+ (find-files "bin" "\\.lv2$" #:directories? #t))
+ ;; Install standalone
+ (install-file "bin/DragonflyRoomReverb" bin)
+ (install-file "bin/DragonflyHallReverb" bin)
+ #t))))))
+ (inputs
+ `(("jack" ,jack-1)
+ ("libx11" ,libx11)
+ ("mesa" ,mesa)))
+ (native-inputs
+ `(("pkg-config" ,pkg-config)))
+ (synopsis "Concert hall reverb and room reverb effects")
+ (description
+ "Dragonfly Reverb is a bundle of two free audio effects: a concert
+hall reverb and a room reverb. Both are available as LV2 plugins as well
+as JACK standalone applications.")
+ (home-page "https://michaelwillis.github.io/dragonfly-reverb/")
+ (license license:gpl3+)))
--
2.25.1
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply related [flat|nested] 5+ messages in thread* bug#39786: [PATCH] Add dragonfly-reverb.
2020-03-21 19:09 ` Alexandros Theodotou
@ 2020-03-21 20:55 ` Nicolas Goaziou
0 siblings, 0 replies; 5+ messages in thread
From: Nicolas Goaziou @ 2020-03-21 20:55 UTC (permalink / raw)
To: Alexandros Theodotou; +Cc: 39786-done
Hello,
Alexandros Theodotou <alex@zrythm.org> writes:
> Attaching the updated patch. I also removed some unneeded
> dependencies.
Thank you! I applied your patch, with the following changes :
> +(define-public dragonfly-reverb
I fixed the indentation, which was a bit off,
> + (lambda* (#:key inputs outputs #:allow-other-keys)
I removed `inputs' as it was not needed.
> + (synopsis "Concert hall reverb and room reverb effects")
> + (description
> + "Dragonfly Reverb is a bundle of two free audio effects: a concert
> +hall reverb and a room reverb. Both are available as LV2 plugins as well
> +as JACK standalone applications.")
> + (home-page "https://michaelwillis.github.io/dragonfly-reverb/")
I moved `home-page' above `synopsis'.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-21 20:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-25 15:20 [bug#39786] [PATCH] Add dragonfly-reverb Alexandros Theodotou
[not found] ` <handler.39786.B.158264402116627.ack@debbugs.gnu.org>
2020-02-26 21:49 ` [bug#39786] Acknowledgement ([PATCH] Add dragonfly-reverb.) Alexandros Theodotou
2020-03-21 16:46 ` [bug#39786] [PATCH] Add dragonfly-reverb Nicolas Goaziou
2020-03-21 19:09 ` Alexandros Theodotou
2020-03-21 20:55 ` bug#39786: " Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).