unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Alexandros Theodotou <alex@zrythm.org>
Cc: 39786-done@debbugs.gnu.org
Subject: bug#39786: [PATCH] Add dragonfly-reverb.
Date: Sat, 21 Mar 2020 21:55:33 +0100	[thread overview]
Message-ID: <87v9mx77i2.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <458932661ece13a229a0ca6e29d6decab90f044e.camel@zrythm.org> (Alexandros Theodotou's message of "Sat, 21 Mar 2020 19:09:48 +0000")

Hello,

Alexandros Theodotou <alex@zrythm.org> writes:

> Attaching the updated patch. I also removed some unneeded
> dependencies.

Thank you! I applied your patch, with the following changes :

> +(define-public dragonfly-reverb

I fixed the indentation, which was a bit off,

> +           (lambda* (#:key inputs outputs #:allow-other-keys)

I removed `inputs' as it was not needed.

> +    (synopsis "Concert hall reverb and room reverb effects")
> +    (description
> +     "Dragonfly Reverb is a bundle of two free audio effects: a concert
> +hall reverb and a room reverb.  Both are available as LV2 plugins as well
> +as JACK standalone applications.")
> +    (home-page "https://michaelwillis.github.io/dragonfly-reverb/")

I moved `home-page' above `synopsis'.

Regards,

-- 
Nicolas Goaziou

      reply	other threads:[~2020-03-21 20:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-25 15:20 [bug#39786] [PATCH] Add dragonfly-reverb Alexandros Theodotou
     [not found] ` <handler.39786.B.158264402116627.ack@debbugs.gnu.org>
2020-02-26 21:49   ` [bug#39786] Acknowledgement ([PATCH] Add dragonfly-reverb.) Alexandros Theodotou
2020-03-21 16:46 ` [bug#39786] [PATCH] Add dragonfly-reverb Nicolas Goaziou
2020-03-21 19:09   ` Alexandros Theodotou
2020-03-21 20:55     ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9mx77i2.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=39786-done@debbugs.gnu.org \
    --cc=alex@zrythm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).