From: "Ludovic Courtès" <ludo@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: Mathieu Othacehe <othacehe@gnu.org>, 43101@debbugs.gnu.org
Subject: [bug#43101] [PATCH v2] Add version number in release ISO
Date: Mon, 31 Aug 2020 14:12:25 +0200 [thread overview]
Message-ID: <877dtfdnfa.fsf@gnu.org> (raw)
In-Reply-To: <20200830215230.3dd526fd@tachikoma.lepiller.eu> (Julien Lepiller's message of "Sun, 30 Aug 2020 21:52:30 +0200")
Hi!
Julien Lepiller <julien@lepiller.eu> skribis:
> From a502fa70b0230d3f91ddf05410f24a1f4fcad521 Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien@lepiller.eu>
> Date: Sat, 29 Aug 2020 15:34:56 +0200
> Subject: [PATCH 1/3] guix: system: Add `--label' option.
>
> * guix/scripts/system.scm (%options): Add `--label'.
> (system-derivation-for-action): Take a #:label key to set volume ID.
> (perform-action): Take a #:label key.
> (%default-options): Add default label value.
> (process-action): Pass label value from command-line to perform-action.
> ---
> doc/guix.texi | 4 +++-
> guix/scripts/system.scm | 27 ++++++++++++++++++++++-----
Please mention the doc/guix.texi changes as well in the log. :-)
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -28836,7 +28836,9 @@ the @option{--image-size} option is ignored in the case of
> @code{docker-image}.
>
> You can specify the root file system type by using the
> -@option{--file-system-type} option. It defaults to @code{ext4}.
> +@option{--file-system-type} option. It defaults to @code{ext4}. When its
> +value is @code{iso9660}, the @option{--label} option can be used to specify
> +a volume ID with @code{disk-image}.
Could you also add an @item for --label, just like we have for the other
options?
I’m also fine with what Mathieu suggests.
OK for me with changes along these lines!
Thank you,
Ludo’.
prev parent reply other threads:[~2020-08-31 12:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 13:44 [bug#43101] [PATCH] Add version number in release ISO Julien Lepiller
2020-08-30 13:47 ` Ludovic Courtès
2020-08-30 14:35 ` Julien Lepiller
2020-08-30 15:05 ` Mathieu Othacehe
2020-08-30 15:11 ` Julien Lepiller
2020-08-30 19:52 ` [bug#43101] [PATCH v2] " Julien Lepiller
2020-08-31 6:18 ` Mathieu Othacehe
2020-08-31 14:13 ` bug#43101: " Julien Lepiller
2020-09-03 11:10 ` [bug#43101] " Mathieu Othacehe
2020-09-03 12:10 ` Julien Lepiller
2020-08-31 12:12 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dtfdnfa.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=43101@debbugs.gnu.org \
--cc=julien@lepiller.eu \
--cc=othacehe@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).