From: Julien Lepiller <julien@lepiller.eu>
To: 43101-done@debbugs.gnu.org
Subject: bug#43101: [PATCH v2] Add version number in release ISO
Date: Mon, 31 Aug 2020 16:13:46 +0200 [thread overview]
Message-ID: <20200831161346.5ed7ac86@tachikoma.lepiller.eu> (raw)
In-Reply-To: <87r1rnibi3.fsf@gnu.org>
Le Mon, 31 Aug 2020 08:18:44 +0200,
Mathieu Othacehe <othacehe@gnu.org> a écrit :
> Hey Julien,
>
> Thanks for the v2 :)
>
> > (inherit iso9660-image)
> > - (operating-system installation-os))))
> > + (operating-system installation-os)
> > + (partitions (match (image-partitions
> > iso9660-image)
> > + ((boot others ...)
> > + (cons
> > + (partition
> > + (inherit boot)
> > + (label (string-append "GUIX_"
> > system "_"
> > +
> > %guix-version)))
> > + others)))))))
>
> We could maybe factorize this in something like:
>
> --8<---------------cut here---------------start------------->8---
> (define (image-with-label image label)
> ...)
> --8<---------------cut here---------------end--------------->8---
>
> that would be put in (gnu system image).
>
> Otherwise, looks fine to me :)
>
> Thanks again,
>
> Mathieu
Pushed as 036f23f053ee6bd34c6d387debb4a9166561dd02 to
7b2ac4768721ccab1782daad99a7cb1be0ed01ee, thank you!
next prev parent reply other threads:[~2020-08-31 14:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 13:44 [bug#43101] [PATCH] Add version number in release ISO Julien Lepiller
2020-08-30 13:47 ` Ludovic Courtès
2020-08-30 14:35 ` Julien Lepiller
2020-08-30 15:05 ` Mathieu Othacehe
2020-08-30 15:11 ` Julien Lepiller
2020-08-30 19:52 ` [bug#43101] [PATCH v2] " Julien Lepiller
2020-08-31 6:18 ` Mathieu Othacehe
2020-08-31 14:13 ` Julien Lepiller [this message]
2020-09-03 11:10 ` Mathieu Othacehe
2020-09-03 12:10 ` Julien Lepiller
2020-08-31 12:12 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831161346.5ed7ac86@tachikoma.lepiller.eu \
--to=julien@lepiller.eu \
--cc=43101-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).