From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id OCFLBlbpTF+WLwAA0tVLHw (envelope-from ) for ; Mon, 31 Aug 2020 12:13:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uMgTAlbpTF8efwAAB5/wlQ (envelope-from ) for ; Mon, 31 Aug 2020 12:13:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 56D1394077C for ; Mon, 31 Aug 2020 12:13:09 +0000 (UTC) Received: from localhost ([::1]:50598 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCigN-0005gx-Q0 for larch@yhetil.org; Mon, 31 Aug 2020 08:13:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35174) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCigI-0005gr-Rx for guix-patches@gnu.org; Mon, 31 Aug 2020 08:13:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40231) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kCigI-0000k8-Io for guix-patches@gnu.org; Mon, 31 Aug 2020 08:13:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kCigI-0004pu-EI for guix-patches@gnu.org; Mon, 31 Aug 2020 08:13:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43101] [PATCH v2] Add version number in release ISO Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 31 Aug 2020 12:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43101 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: Mathieu Othacehe , 43101@debbugs.gnu.org Received: via spool by 43101-submit@debbugs.gnu.org id=B43101.159887595518557 (code B ref 43101); Mon, 31 Aug 2020 12:13:02 +0000 Received: (at 43101) by debbugs.gnu.org; 31 Aug 2020 12:12:35 +0000 Received: from localhost ([127.0.0.1]:51777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCifr-0004pE-9Z for submit@debbugs.gnu.org; Mon, 31 Aug 2020 08:12:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCifo-0004ow-QA for 43101@debbugs.gnu.org; Mon, 31 Aug 2020 08:12:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55111) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCifj-0000gK-Jz; Mon, 31 Aug 2020 08:12:27 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=36058 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kCifi-0007cr-HB; Mon, 31 Aug 2020 08:12:26 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200829154445.5512d99a@tachikoma.lepiller.eu> <87d038i6uf.fsf@gnu.org> <904ADAD9-76B7-4C7F-A0DF-39CEB6E3477D@lepiller.eu> <87v9h0p420.fsf@gnu.org> <20200830215230.3dd526fd@tachikoma.lepiller.eu> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 15 Fructidor an 228 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 31 Aug 2020 14:12:25 +0200 In-Reply-To: <20200830215230.3dd526fd@tachikoma.lepiller.eu> (Julien Lepiller's message of "Sun, 30 Aug 2020 21:52:30 +0200") Message-ID: <877dtfdnfa.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: /zQKZI9pNzjH Hi! Julien Lepiller skribis: > From a502fa70b0230d3f91ddf05410f24a1f4fcad521 Mon Sep 17 00:00:00 2001 > From: Julien Lepiller > Date: Sat, 29 Aug 2020 15:34:56 +0200 > Subject: [PATCH 1/3] guix: system: Add `--label' option. > > * guix/scripts/system.scm (%options): Add `--label'. > (system-derivation-for-action): Take a #:label key to set volume ID. > (perform-action): Take a #:label key. > (%default-options): Add default label value. > (process-action): Pass label value from command-line to perform-action. > --- > doc/guix.texi | 4 +++- > guix/scripts/system.scm | 27 ++++++++++++++++++++++----- Please mention the doc/guix.texi changes as well in the log. :-) > --- a/doc/guix.texi > +++ b/doc/guix.texi > @@ -28836,7 +28836,9 @@ the @option{--image-size} option is ignored in th= e case of > @code{docker-image}. >=20=20 > You can specify the root file system type by using the > -@option{--file-system-type} option. It defaults to @code{ext4}. > +@option{--file-system-type} option. It defaults to @code{ext4}. When i= ts > +value is @code{iso9660}, the @option{--label} option can be used to spec= ify > +a volume ID with @code{disk-image}. Could you also add an @item for --label, just like we have for the other options? I=E2=80=99m also fine with what Mathieu suggests. OK for me with changes along these lines! Thank you, Ludo=E2=80=99.