From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42939)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eYsTn-0005tX-8S
	for guix-patches@gnu.org; Tue, 09 Jan 2018 06:54:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eYsTi-0006um-D3
	for guix-patches@gnu.org; Tue, 09 Jan 2018 06:54:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:33479)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eYsTi-0006uU-8g
	for guix-patches@gnu.org; Tue, 09 Jan 2018 06:54:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eYsTi-0004OX-1P
	for guix-patches@gnu.org; Tue, 09 Jan 2018 06:54:02 -0500
Subject: [bug#29932] [PATCH 0/2] Clean up operating-system-kernel-arguments.
Resent-Message-ID: <handler.29932.B29932.151549880016831@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180101132200.26157-1-dannym@scratchpost.org>
	<878td8k8f5.fsf@gnu.org> <20180109092133.3f740ba3@scratchpost.org>
	<87incbxvlq.fsf@gnu.org> <20180109113438.38341a07@scratchpost.org>
Date: Tue, 09 Jan 2018 12:53:16 +0100
In-Reply-To: <20180109113438.38341a07@scratchpost.org> (Danny Milosavljevic's
	message of "Tue, 9 Jan 2018 11:34:38 +0100")
Message-ID: <87608bw8nn.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 29932@debbugs.gnu.org

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> Hi Ludo,
>
>>   #~(string-append "--system=3D" #$os)
>>=20
>> where =E2=80=98os=E2=80=99 is an <operating-system>.  It automatically c=
omputes its
>> derivation.  Thus, no need to explicitly call
>> =E2=80=98operating-system-derivation=E2=80=99 and pass =E2=80=9Csystem.d=
rv=E2=80=9D arguments around.
>
> Ah!  Good to know.
>
>> So we=E2=80=99d just need a slight adjustment to =E2=80=98bootable-kerne=
l-arguments=E2=80=99 (so
>> that it takes the root device from the given OS object) and then rename
>> it to =E2=80=98operating-system-kernel-arguments=E2=80=99.
>
> bootable-kernel-arguments is also used by the "parameters" file serialize=
r.

Good point, so probably we need to keep it as-is internally.  For user
consumption though, we can expose =E2=80=98operating-system-kernel-argument=
s=E2=80=99
(or whatever we call it.)

> Also, the user that is modifying a <operating-system> instance (for examp=
le marionette-operating-system adding "panic=3D1") would erronously use ope=
rating-system-kernel-arguments in order to get the previous instance's argu=
ments, resulting in the "--root", "--load" etc being prepended twice, no?
>
> The user might want to pass some kernel arguments which have nothing to d=
o with Guix (which <operating-system>'s "kernel-arguments" is for) and then=
 GuixSD needs some extra arguments to be able to boot the actual system (wh=
ich can be found entirely automatically - nice!).

Oh wait, now I realize that =E2=80=98operating-system-kernel-arguments=E2=
=80=99 is
already taken.  :-)

So another name suggestion would be:
=E2=80=98operating-system-essential-kernel-arguments=E2=80=99.  Thoughts?

Sorry for the confusion!

Ludo=E2=80=99.