unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: Christopher Baines <mail@cbaines.net>
Cc: 41022@debbugs.gnu.org
Subject: [bug#41022] [PATCH core-updates] gnu: python-gst: Fix build with Python 3.8.
Date: Sat, 02 May 2020 15:41:10 +0200	[thread overview]
Message-ID: <875zde4fpl.fsf@devup.no> (raw)
In-Reply-To: <87lfmamq6v.fsf@cbaines.net>

[-- Attachment #1: Type: text/plain, Size: 2345 bytes --]

Christopher Baines <mail@cbaines.net> writes:

> Marius Bakke <mbakke@fastmail.com> writes:
>
>> Christopher Baines <mail@cbaines.net> writes:
>>
>>> Add a patch based on an upstream commit [1].
>>>
>>> 1: 10707f437f2fc3632067c6a0efa4432f7ebaf362
>>>
>>> * gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch: New file.
>>> * gnu/local.mk (dist_patch_DATA): Add it.
>>> * gnu/packages/gstreamer.scm (python-gst)[source]: Use the patch.
>>
>> [...]
>>
>>> diff --git a/gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch b/gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch
>>> new file mode 100644
>>> index 0000000000..49f41e0c03
>>> --- /dev/null
>>> +++ b/gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch
>>> @@ -0,0 +1,41 @@
>>> +From 10707f437f2fc3632067c6a0efa4432f7ebaf362 Mon Sep 17 00:00:00 2001
>>> +From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= <sebastian@centricular.com>
>>> +Date: Fri, 13 Dec 2019 10:46:20 +0200
>>> +Subject: [PATCH] Fix build with Python 3.8 by also checking for
>>> + python-3.X-embed.pc
>>> +
>>> +Since Python 3.8 the normal checks don't include the Python libraries
>>> +anymore and linking of the gst-python module would fail.
>>> +
>>> +See also https://github.com/mesonbuild/meson/issues/5629
>>> +
>>> +Fixes https://gitlab.freedesktop.org/gstreamer/gst-python/issues/28
>>> +---
>>> + meson.build | 11 +++++++++--
>>> + 1 file changed, 9 insertions(+), 2 deletions(-)
>>
>> Instead of the git patch format, can you add a short comment at the top
>> along with links to the upstream commit and issue like we usually do?
>
> I usually avoid messing with patches, they're often uncooperative. Would
> something I this do?

Anything before the "diff ..." line is treated as comments/noop by the
patch utility (actually you can add comments between the @@ lines too).

> Fix build with Python 3.8 by also checking for python-3.X-embed.pc. Since
> Python 3.8 the normal checks don't include the Python libraries anymore and
> linking of the gst-python module would fail.
>
> See also https://github.com/mesonbuild/meson/issues/5629
> Fixes https://gitlab.freedesktop.org/gstreamer/gst-python/issues/28
>
> Patch based on upstream commit:
>
> https://gitlab.freedesktop.org/gstreamer/gst-python/-/commit/10707f437f2fc3632067c6a0efa4432f7ebaf362

Perfect, thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2020-05-02 13:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-02 11:03 [bug#41022] [PATCH core-updates] gnu: python-gst: Fix build with Python 3.8 Christopher Baines
2020-05-02 11:26 ` Marius Bakke
2020-05-02 13:17   ` Christopher Baines
2020-05-02 13:41     ` Marius Bakke [this message]
2020-05-02 14:50       ` bug#41022: " Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875zde4fpl.fsf@devup.no \
    --to=mbakke@fastmail.com \
    --cc=41022@debbugs.gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).