Christopher Baines writes: > Marius Bakke writes: > >> Christopher Baines writes: >> >>> Add a patch based on an upstream commit [1]. >>> >>> 1: 10707f437f2fc3632067c6a0efa4432f7ebaf362 >>> >>> * gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch: New file. >>> * gnu/local.mk (dist_patch_DATA): Add it. >>> * gnu/packages/gstreamer.scm (python-gst)[source]: Use the patch. >> >> [...] >> >>> diff --git a/gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch b/gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch >>> new file mode 100644 >>> index 0000000000..49f41e0c03 >>> --- /dev/null >>> +++ b/gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch >>> @@ -0,0 +1,41 @@ >>> +From 10707f437f2fc3632067c6a0efa4432f7ebaf362 Mon Sep 17 00:00:00 2001 >>> +From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= >>> +Date: Fri, 13 Dec 2019 10:46:20 +0200 >>> +Subject: [PATCH] Fix build with Python 3.8 by also checking for >>> + python-3.X-embed.pc >>> + >>> +Since Python 3.8 the normal checks don't include the Python libraries >>> +anymore and linking of the gst-python module would fail. >>> + >>> +See also https://github.com/mesonbuild/meson/issues/5629 >>> + >>> +Fixes https://gitlab.freedesktop.org/gstreamer/gst-python/issues/28 >>> +--- >>> + meson.build | 11 +++++++++-- >>> + 1 file changed, 9 insertions(+), 2 deletions(-) >> >> Instead of the git patch format, can you add a short comment at the top >> along with links to the upstream commit and issue like we usually do? > > I usually avoid messing with patches, they're often uncooperative. Would > something I this do? Anything before the "diff ..." line is treated as comments/noop by the patch utility (actually you can add comments between the @@ lines too). > Fix build with Python 3.8 by also checking for python-3.X-embed.pc. Since > Python 3.8 the normal checks don't include the Python libraries anymore and > linking of the gst-python module would fail. > > See also https://github.com/mesonbuild/meson/issues/5629 > Fixes https://gitlab.freedesktop.org/gstreamer/gst-python/issues/28 > > Patch based on upstream commit: > > https://gitlab.freedesktop.org/gstreamer/gst-python/-/commit/10707f437f2fc3632067c6a0efa4432f7ebaf362 Perfect, thanks!