From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id cEjVK694rV4QUwAA0tVLHw (envelope-from ) for ; Sat, 02 May 2020 13:42:07 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id JVqbArp4rV73TAAAbx9fmQ (envelope-from ) for ; Sat, 02 May 2020 13:42:18 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5AD9E940A37 for ; Sat, 2 May 2020 13:42:15 +0000 (UTC) Received: from localhost ([::1]:38806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUsPH-0002dL-HB for larch@yhetil.org; Sat, 02 May 2020 09:42:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jUsP8-0002XH-15 for guix-patches@gnu.org; Sat, 02 May 2020 09:42:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jUsP4-0003jD-JF for guix-patches@gnu.org; Sat, 02 May 2020 09:42:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40054) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jUsP4-0003j8-6N for guix-patches@gnu.org; Sat, 02 May 2020 09:42:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jUsP4-00055F-4Z for guix-patches@gnu.org; Sat, 02 May 2020 09:42:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41022] [PATCH core-updates] gnu: python-gst: Fix build with Python 3.8. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 02 May 2020 13:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41022 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 41022@debbugs.gnu.org Received: via spool by 41022-submit@debbugs.gnu.org id=B41022.158842689019501 (code B ref 41022); Sat, 02 May 2020 13:42:02 +0000 Received: (at 41022) by debbugs.gnu.org; 2 May 2020 13:41:30 +0000 Received: from localhost ([127.0.0.1]:51600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUsOT-00054L-QJ for submit@debbugs.gnu.org; Sat, 02 May 2020 09:41:30 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:38083) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUsOO-000543-PX for 41022@debbugs.gnu.org; Sat, 02 May 2020 09:41:24 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id F0DEA2EE; Sat, 2 May 2020 09:41:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 02 May 2020 09:41:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=VNLKrrB82g5Ejry50OyZo0nZU9 3tEX4Dp5BOHES2j2k=; b=NRV05eoIilL6YEZaGKOU7R8hx8/Gm3EKPGfH7MzZEI UouglZS9sK51+up/yPTEsW+CAmROGDKjpi52ywjjLxEFyuHJotPk4NTg/PHk2V3z kRNRYhBnruVLfafCEnBsfM0tpCWNW+iq811ewrhr34y8JvJo1I/BdazTD6kBvju3 0Ju/0YNvdfeWivLru8Bxf2X8W+UNMrnLGaBZ7TxToY9+h7AELLGhLZeDbSjJON/j XYdTXDGmTVto1FlmTpMLulzBQcy3NfxpLRJWiKiQrAhOthf4neEfLfAZTmjv1cAi /bZGemafb3R+RQltnFa20GpTJ5H7TnO+ofh0hEuH6scw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=VNLKrr B82g5Ejry50OyZo0nZU93tEX4Dp5BOHES2j2k=; b=Q+kD2dAsKPh3JmsY7HYWzK IyYimeXcNz6dvfn5jcWgze4OC1OjmMGn+HEhddF0epPdyO3QcgAcMT9Ry6rllZRO cZSWftBamwrabx+IlH5iLrlqT6YVqh1GHZohtTr2xT6VAEJZKogvjO6foug9Gziy RNmPYtQkkwqzLCzmiJuc2WoyUQxebgUBAqUFp5fWHFHCZ06jTUw16oPV0Q5i9z9H 7iCO0h17tI8WNsWMgjD9NuQ/y6OPFHmI1R+2HVqGQ0PfSizOlweXj5X1YKq+ZPVq mUaqNjNgThCUHX4KFApZ/K5SBGXf355gRc7R/ENxCI3ETwHaikWPfpWySiUmbl2Q == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrieelgdeihecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufgjfhgffffkgggtsehgtderre dtredtnecuhfhrohhmpeforghrihhushcuuegrkhhkvgcuoehmsggrkhhkvgesfhgrshht mhgrihhlrdgtohhmqeenucggtffrrghtthgvrhhnpeduudegudfgheethfeukefffeetle efgfffgeduveeljefgtdfhudefleffffegieenucffohhmrghinhepghhithhhuhgsrdgt ohhmpdhfrhgvvgguvghskhhtohhprdhorhhgnecukfhppeekgedrvddtvddrieekrdejhe enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmsggr khhkvgesfhgrshhtmhgrihhlrdgtohhm X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id 2A10E328005A; Sat, 2 May 2020 09:41:13 -0400 (EDT) From: Marius Bakke In-Reply-To: <87lfmamq6v.fsf@cbaines.net> References: <20200502110314.30403-1-mail@cbaines.net> <87ees24lyr.fsf@devup.no> <87lfmamq6v.fsf@cbaines.net> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Sat, 02 May 2020 15:41:10 +0200 Message-ID: <875zde4fpl.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 X-Spam-Score: -2.01 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=fastmail.com header.s=fm2 header.b=NRV05eoI; dkim=fail (rsa verify failed) header.d=messagingengine.com header.s=fm2 header.b=Q+kD2dAs; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fastmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Scan-Result: default: False [-2.01 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.49498580718065]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; FREEMAIL_FROM(0.00)[fastmail.com]; DWL_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.15), country: US(-0.00), ip: 2001:470:142::17(-0.49)]; R_DKIM_REJECT(1.00)[fastmail.com:s=fm2,messagingengine.com:s=fm2]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; RCPT_COUNT_TWO(0.00)[2]; DKIM_TRACE(0.00)[fastmail.com:-,messagingengine.com:-]; MAILLIST(-0.20)[mailman]; SIGNED_PGP(-2.00)[]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_IN_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; TAGGED_FROM(0.00)[larch=yhetil.org]; FROM_NEQ_ENVFROM(0.00)[mbakke@fastmail.com,guix-patches-bounces@gnu.org]; ARC_NA(0.00)[]; URIBL_BLOCKED(0.00)[fastmail.com:email,centricular.com:email,gitlab.freedesktop.org:url,cbaines.net:email,meson.build:url]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; HAS_LIST_UNSUB(-0.01)[]; RCVD_COUNT_SEVEN(0.00)[11]; FORGED_SENDER_MAILLIST(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[fastmail.com : SPF not aligned (relaxed),none] X-TUID: 9/DigFGcY5li --=-=-= Content-Type: text/plain Christopher Baines writes: > Marius Bakke writes: > >> Christopher Baines writes: >> >>> Add a patch based on an upstream commit [1]. >>> >>> 1: 10707f437f2fc3632067c6a0efa4432f7ebaf362 >>> >>> * gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch: New file. >>> * gnu/local.mk (dist_patch_DATA): Add it. >>> * gnu/packages/gstreamer.scm (python-gst)[source]: Use the patch. >> >> [...] >> >>> diff --git a/gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch b/gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch >>> new file mode 100644 >>> index 0000000000..49f41e0c03 >>> --- /dev/null >>> +++ b/gnu/packages/patches/python-gst-fix-build-with-python-3.8.patch >>> @@ -0,0 +1,41 @@ >>> +From 10707f437f2fc3632067c6a0efa4432f7ebaf362 Mon Sep 17 00:00:00 2001 >>> +From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= >>> +Date: Fri, 13 Dec 2019 10:46:20 +0200 >>> +Subject: [PATCH] Fix build with Python 3.8 by also checking for >>> + python-3.X-embed.pc >>> + >>> +Since Python 3.8 the normal checks don't include the Python libraries >>> +anymore and linking of the gst-python module would fail. >>> + >>> +See also https://github.com/mesonbuild/meson/issues/5629 >>> + >>> +Fixes https://gitlab.freedesktop.org/gstreamer/gst-python/issues/28 >>> +--- >>> + meson.build | 11 +++++++++-- >>> + 1 file changed, 9 insertions(+), 2 deletions(-) >> >> Instead of the git patch format, can you add a short comment at the top >> along with links to the upstream commit and issue like we usually do? > > I usually avoid messing with patches, they're often uncooperative. Would > something I this do? Anything before the "diff ..." line is treated as comments/noop by the patch utility (actually you can add comments between the @@ lines too). > Fix build with Python 3.8 by also checking for python-3.X-embed.pc. Since > Python 3.8 the normal checks don't include the Python libraries anymore and > linking of the gst-python module would fail. > > See also https://github.com/mesonbuild/meson/issues/5629 > Fixes https://gitlab.freedesktop.org/gstreamer/gst-python/issues/28 > > Patch based on upstream commit: > > https://gitlab.freedesktop.org/gstreamer/gst-python/-/commit/10707f437f2fc3632067c6a0efa4432f7ebaf362 Perfect, thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl6teHYACgkQoqBt8qM6 VPq9qAgAkCHyNOOQdTzhjyApcc8hjM9mMRiQv/P/P5Dl/2eoKTNem6C2yiGFUxnA NdoG2MxpOB+qOxBGyS67pgPwcireEkdZO9niL5hCYErg/UnNjf5kdNNbkqXzLgzR +4Gvk0ZvBkz/4ts7txb7lygtisarSG8w2hlazesYEop1p34/jjRU86lQrdhQHE79 VDfv5rSdRC26Gt7FpJx3SOR+tPeHoF0tOYVGdHRRt6HExcHB0GBzGbcyDW4Du1nO pPCDGc4022men6iOIyeAs0g2AfNd9XTeQdZf+7HSKDx6FlF1q1DWFfHnE4750ZO+ gmc4IlpnFvlwCbgYhREy9T2d7vWeDw== =GP5y -----END PGP SIGNATURE----- --=-=-=--