* [bug#41863] [PATCH] services: Fix gdm-autologin pam service.
@ 2020-06-14 23:24 Alex Griffin via Guix-patches via
2020-10-02 17:54 ` Marius Bakke
0 siblings, 1 reply; 4+ messages in thread
From: Alex Griffin via Guix-patches via @ 2020-06-14 23:24 UTC (permalink / raw)
To: 41863; +Cc: 35674@debbugs.gnu.org, 40411@debbugs.gnu.org
[-- Attachment #1: Type: text/plain, Size: 224 bytes --]
This patch fixes GDM's auto-login feature.
See the discussions in #35674 and #40411. It works for me, but I don't want to just commit it because I don't really understand PAM. (Then again, who does?)
--
Alex Griffin
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-services-Fix-gdm-autologin-pam-service.patch --]
[-- Type: text/x-patch; name=0001-services-Fix-gdm-autologin-pam-service.patch, Size: 1249 bytes --]
From 2d07fab70a4051189e013a20a95cfbb08c904803 Mon Sep 17 00:00:00 2001
From: Alex Griffin <a@ajgrf.com>
Date: Sun, 14 Jun 2020 17:58:47 -0500
Subject: [PATCH] services: Fix gdm-autologin pam service.
* gnu/services/xorg.scm (gdm-pam-service): Mark pam_gdm.so optional.
---
gnu/services/xorg.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gnu/services/xorg.scm b/gnu/services/xorg.scm
index ca39994516..4590709187 100644
--- a/gnu/services/xorg.scm
+++ b/gnu/services/xorg.scm
@@ -7,6 +7,7 @@
;;; Copyright © 2019 Tim Gesthuizen <tim.gesthuizen@yahoo.de>
;;; Copyright © 2020 shtwzrd <shtwzrd@protonmail.com>
;;; Copyright © 2020 Jakub Kądziołka <kuba@kadziolka.net>
+;;; Copyright © 2020 Alex Griffin <a@ajgrf.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -925,7 +926,7 @@ the GNOME desktop environment.")
(inherit (unix-pam-service "gdm-autologin"
#:login-uid? #t))
(auth (list (pam-entry
- (control "[success=ok default=1]")
+ (control "optional")
(module (file-append (gdm-configuration-gdm config)
"/lib/security/pam_gdm.so")))
(pam-entry
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#41863] [PATCH] services: Fix gdm-autologin pam service.
2020-06-14 23:24 [bug#41863] [PATCH] services: Fix gdm-autologin pam service Alex Griffin via Guix-patches via
@ 2020-10-02 17:54 ` Marius Bakke
[not found] ` <esiIK42C7dlyX-1gfPsm-QlMoNbvNRFGAu_P5c2NqhmvqRH6pEXMCW1Tn0jV1gl0ssz613thLFqoeURPuUpcKs8gmy0OSzo-S4MQcIIVcHg=@ajgrf.com>
0 siblings, 1 reply; 4+ messages in thread
From: Marius Bakke @ 2020-10-02 17:54 UTC (permalink / raw)
To: Alex Griffin, 41863; +Cc: 35674@debbugs.gnu.org, 40411@debbugs.gnu.org
[-- Attachment #1: Type: text/plain, Size: 774 bytes --]
Alex Griffin via Guix-patches via <guix-patches@gnu.org> writes:
> This patch fixes GDM's auto-login feature.
>
> See the discussions in #35674 and #40411. It works for me, but I don't want to just commit it because I don't really understand PAM. (Then again, who does?)
[...]
> @@ -925,7 +926,7 @@ the GNOME desktop environment.")
> (inherit (unix-pam-service "gdm-autologin"
> #:login-uid? #t))
> (auth (list (pam-entry
> - (control "[success=ok default=1]")
> + (control "optional")
This is one of the alternatives Timothy proposed in #35674 back in May
last year(!). As long as GDM still rejects wrong or blank passwords, I
think it is good to go.
It would be good to get it in 1.2.0. :-)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#41863] [PATCH] services: Fix gdm-autologin pam service.
[not found] ` <esiIK42C7dlyX-1gfPsm-QlMoNbvNRFGAu_P5c2NqhmvqRH6pEXMCW1Tn0jV1gl0ssz613thLFqoeURPuUpcKs8gmy0OSzo-S4MQcIIVcHg=@ajgrf.com>
@ 2020-10-07 19:12 ` Alex Griffin via Guix-patches via
2020-10-07 19:13 ` bug#41863: " Alex Griffin via Guix-patches via
0 siblings, 1 reply; 4+ messages in thread
From: Alex Griffin via Guix-patches via @ 2020-10-07 19:12 UTC (permalink / raw)
To: 41863@debbugs.gnu.org
Fixed in commit d8258177fe.
--
Alex Griffin
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Wednesday, October 7th, 2020 at 7:11 PM, Alex Griffin <a@ajgrf.com> wrote:
> Fixed in commit d8258177fe.
>
> --
> Alex Griffin
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>
> On Friday, October 2nd, 2020 at 5:54 PM, Marius Bakke marius@gnu.org wrote:
>
> > Alex Griffin via Guix-patches via writes:
> >
> > > This patch fixes GDM's auto-login feature.
> >
> > > See the discussions in #35674 and #40411. It works for me, but I don't want to just commit it because I don't really understand PAM. (Then again, who does?)
> >
> > [...]
> >
> > > @@ -925,7 +926,7 @@ the GNOME desktop environment.")
> >
> > > (inherit (unix-pam-service "gdm-autologin"
> >
> > > #:login-uid? #t))
> >
> > > (auth (list (pam-entry
> >
> > > - (control "[success=ok default=1]")
> >
> > > - (control "optional")
> >
> > This is one of the alternatives Timothy proposed in #35674 back in May
> >
> > last year(!). As long as GDM still rejects wrong or blank passwords, I
> >
> > think it is good to go.
> >
> > It would be good to get it in 1.2.0. :-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#41863: [PATCH] services: Fix gdm-autologin pam service.
2020-10-07 19:12 ` Alex Griffin via Guix-patches via
@ 2020-10-07 19:13 ` Alex Griffin via Guix-patches via
0 siblings, 0 replies; 4+ messages in thread
From: Alex Griffin via Guix-patches via @ 2020-10-07 19:13 UTC (permalink / raw)
To: 41863-done@debbugs.gnu.org
Fixed in commit d8258177fe.
--
Alex Griffin
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Wednesday, October 7th, 2020 at 7:12 PM, Alex Griffin <a@ajgrf.com> wrote:
> Fixed in commit d8258177fe.
>
> --
> Alex Griffin
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>
> On Wednesday, October 7th, 2020 at 7:11 PM, Alex Griffin a@ajgrf.com wrote:
>
> > Fixed in commit d8258177fe.
> >
> > --
> >
> > Alex Griffin
> >
> > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> >
> > On Friday, October 2nd, 2020 at 5:54 PM, Marius Bakke marius@gnu.org wrote:
> >
> > > Alex Griffin via Guix-patches via writes:
> > >
> > > > This patch fixes GDM's auto-login feature.
> > >
> > > > See the discussions in #35674 and #40411. It works for me, but I don't want to just commit it because I don't really understand PAM. (Then again, who does?)
> > >
> > > [...]
> > >
> > > > @@ -925,7 +926,7 @@ the GNOME desktop environment.")
> > >
> > > > (inherit (unix-pam-service "gdm-autologin"
> > >
> > > > #:login-uid? #t))
> > >
> > > > (auth (list (pam-entry
> > >
> > > > - (control "[success=ok default=1]")
> > >
> > > > - (control "optional")
> > >
> > > This is one of the alternatives Timothy proposed in #35674 back in May
> > >
> > > last year(!). As long as GDM still rejects wrong or blank passwords, I
> > >
> > > think it is good to go.
> > >
> > > It would be good to get it in 1.2.0. :-)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-07 19:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-14 23:24 [bug#41863] [PATCH] services: Fix gdm-autologin pam service Alex Griffin via Guix-patches via
2020-10-02 17:54 ` Marius Bakke
[not found] ` <esiIK42C7dlyX-1gfPsm-QlMoNbvNRFGAu_P5c2NqhmvqRH6pEXMCW1Tn0jV1gl0ssz613thLFqoeURPuUpcKs8gmy0OSzo-S4MQcIIVcHg=@ajgrf.com>
2020-10-07 19:12 ` Alex Griffin via Guix-patches via
2020-10-07 19:13 ` bug#41863: " Alex Griffin via Guix-patches via
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).