unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Alex Griffin via Guix-patches via <guix-patches@gnu.org>
To: 41863@debbugs.gnu.org
Cc: "35674@debbugs.gnu.org" <35674@debbugs.gnu.org>,
	"40411@debbugs.gnu.org" <40411@debbugs.gnu.org>
Subject: [bug#41863] [PATCH] services: Fix gdm-autologin pam service.
Date: Sun, 14 Jun 2020 23:24:56 +0000	[thread overview]
Message-ID: <-CkK6xCmE4SCUTOS1nupxqCONmgZkMEUjRUNRiBXxpuT9bRhVj74k6fTGlkQg4xu8r6BAWNhSpod7a0vH4ufBiNT1GR_fxHbc0U5Vqr-xMw=@ajgrf.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

This patch fixes GDM's auto-login feature.

See the discussions in #35674 and #40411. It works for me, but I don't want to just commit it because I don't really understand PAM. (Then again, who does?)

--
Alex Griffin

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-services-Fix-gdm-autologin-pam-service.patch --]
[-- Type: text/x-patch; name=0001-services-Fix-gdm-autologin-pam-service.patch, Size: 1249 bytes --]

From 2d07fab70a4051189e013a20a95cfbb08c904803 Mon Sep 17 00:00:00 2001
From: Alex Griffin <a@ajgrf.com>
Date: Sun, 14 Jun 2020 17:58:47 -0500
Subject: [PATCH] services: Fix gdm-autologin pam service.

* gnu/services/xorg.scm (gdm-pam-service): Mark pam_gdm.so optional.
---
 gnu/services/xorg.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/services/xorg.scm b/gnu/services/xorg.scm
index ca39994516..4590709187 100644
--- a/gnu/services/xorg.scm
+++ b/gnu/services/xorg.scm
@@ -7,6 +7,7 @@
 ;;; Copyright © 2019 Tim Gesthuizen <tim.gesthuizen@yahoo.de>
 ;;; Copyright © 2020 shtwzrd <shtwzrd@protonmail.com>
 ;;; Copyright © 2020 Jakub Kądziołka <kuba@kadziolka.net>
+;;; Copyright © 2020 Alex Griffin <a@ajgrf.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -925,7 +926,7 @@ the GNOME desktop environment.")
     (inherit (unix-pam-service "gdm-autologin"
                                #:login-uid? #t))
     (auth (list (pam-entry
-                 (control "[success=ok default=1]")
+                 (control "optional")
                  (module (file-append (gdm-configuration-gdm config)
                                       "/lib/security/pam_gdm.so")))
                 (pam-entry
-- 
2.26.2


             reply	other threads:[~2020-06-14 23:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-14 23:24 Alex Griffin via Guix-patches via [this message]
2020-10-02 17:54 ` [bug#41863] [PATCH] services: Fix gdm-autologin pam service Marius Bakke
     [not found]   ` <esiIK42C7dlyX-1gfPsm-QlMoNbvNRFGAu_P5c2NqhmvqRH6pEXMCW1Tn0jV1gl0ssz613thLFqoeURPuUpcKs8gmy0OSzo-S4MQcIIVcHg=@ajgrf.com>
2020-10-07 19:12     ` Alex Griffin via Guix-patches via
2020-10-07 19:13       ` bug#41863: " Alex Griffin via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='-CkK6xCmE4SCUTOS1nupxqCONmgZkMEUjRUNRiBXxpuT9bRhVj74k6fTGlkQg4xu8r6BAWNhSpod7a0vH4ufBiNT1GR_fxHbc0U5Vqr-xMw=@ajgrf.com' \
    --to=guix-patches@gnu.org \
    --cc=35674@debbugs.gnu.org \
    --cc=40411@debbugs.gnu.org \
    --cc=41863@debbugs.gnu.org \
    --cc=a@ajgrf.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).