unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Thomas Albers <thomas@thomaslabs.org>
Cc: 65152@debbugs.gnu.org
Subject: [bug#65152] [PATCH] services: Modify cgit-configuration fields
Date: Mon, 21 Aug 2023 19:22:18 +0200	[thread overview]
Message-ID: <875y588g51.fsf@gnu.org> (raw)
In-Reply-To: <20230808163710.22801-1-thomas@thomaslabs.org> (Thomas Albers's message of "Tue, 8 Aug 2023 18:37:10 +0200")

Hi,

Thomas Albers <thomas@thomaslabs.org> skribis:

> * gnu/services/cgit.scm (cgit-configuration)[root-readme]: Accept
> 'file-object' instead of only 'string'

[...]

>    (root-readme
> -   (string "")
> +   (file-object "")
>     "The content of the file specified with this option will be included
>  verbatim below the \"about\" link on the repository index page.")

I think it’s a good idea but (1) we should preserve backward
compatibility for users passing a string (file contents), and (2) update
the docstrings and its copy in the manual.

Could you send a second version to address these?  Let me know if
anything’s unclear.

Thanks,
Ludo’.




  reply	other threads:[~2023-08-21 17:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08 16:37 [bug#65152] [PATCH] services: Modify cgit-configuration fields Thomas Albers via Guix-patches via
2023-08-21 17:22 ` Ludovic Courtès [this message]
2023-08-22  9:18   ` Thomas Albers Raviola via Guix-patches via
2023-09-09 10:32     ` bug#65152: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875y588g51.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=65152@debbugs.gnu.org \
    --cc=thomas@thomaslabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).