From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id kEAVAYad42RhCQEASxT56A (envelope-from ) for ; Mon, 21 Aug 2023 19:23:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id YA6NO4Wd42RrCgEAG6o9tA (envelope-from ) for ; Mon, 21 Aug 2023 19:23:17 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6ED3A548C1 for ; Mon, 21 Aug 2023 19:23:17 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=IpDxkqD+; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1692638597; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ikphQIeCK6UkMb9Bbz8mWqd9z4p2Qdz+UzuLVMnFVVk=; b=Gqm8HxyXrG5EPiN2C3HrfSsjoO0X5+yY8IbfxABT/CXiRXf8DZdh+JvK/+v0atsK16+5g5 tLaxX6wMWO3+sEW3VaqDMA1n43IsunzxOJYIkAJWgviizLdt6z/OOazMCK3x2y097tGCnT kq2ZeX+MKJcGFCJjAifpFP/SvaYLhjTPO/9V+Of68F3ap6MS6zIwK2N3i1lMh9XjBW6+Cj 2P68Sz5V2s/9+GuxLFOvFtPzGlikz80V+xtSmZHgjO+CGjz9nLUvt2AODatsxWOtO2z6l6 UPb78xm6i4P8cInndwANcdWkC+44Y6CA83AFjMECeO1gVaCmFlRahPGAfT+ULQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=IpDxkqD+; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1692638597; a=rsa-sha256; cv=none; b=CEW6YstCZ5qXrlg9RwM2GO8j7siPFIN5Wr3g3o0+0Teszxm1i/L9FKW1AyeFZeWrxtJ1lc Ty34pPPcCKGYEkdM/d/btQ/u8mg4SF7DvdZAWJ0MXz3Zujb0WniOvmO8GTQT01NFJnM7mI 2WAlbF7HLNGYY6sWxR2h47lZftDnx6DhSDsPk0xvDpBKqpLX2PvxyeDwdPT8XEHngubwJp b4QnNFTTz1FCXKaYYasDqLpHDIxRvGTvlpeiaSMD2ds+Wg9OFQiohvLtD7UQPWvta0MXIz 5CsjGzQsgNURXjFGgtiW9ITOzSU1d4FUX3sdZwCuR3sddqwQ9JbcQYPrRHoblA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qY8cK-0002lC-Ab; Mon, 21 Aug 2023 13:23:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qY8cG-0002kE-SO for guix-patches@gnu.org; Mon, 21 Aug 2023 13:23:01 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qY8cG-0001Sf-IQ for guix-patches@gnu.org; Mon, 21 Aug 2023 13:23:00 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qY8cI-0006C5-AH for guix-patches@gnu.org; Mon, 21 Aug 2023 13:23:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65152] [PATCH] services: Modify cgit-configuration fields Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 21 Aug 2023 17:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65152 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Thomas Albers Cc: 65152@debbugs.gnu.org Received: via spool by 65152-submit@debbugs.gnu.org id=B65152.169263856023782 (code B ref 65152); Mon, 21 Aug 2023 17:23:02 +0000 Received: (at 65152) by debbugs.gnu.org; 21 Aug 2023 17:22:40 +0000 Received: from localhost ([127.0.0.1]:57642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY8bw-0006BW-5V for submit@debbugs.gnu.org; Mon, 21 Aug 2023 13:22:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY8bt-0006BF-9C for 65152@debbugs.gnu.org; Mon, 21 Aug 2023 13:22:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qY8bd-0001LY-P2; Mon, 21 Aug 2023 13:22:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=ikphQIeCK6UkMb9Bbz8mWqd9z4p2Qdz+UzuLVMnFVVk=; b=IpDxkqD+jW4lP6t+WkL7 HGXjgs5YNNBgnPM1KVjAxJzrbHTyKsuW56ysfhwygQshicVcyCYfOZ9cl3YtzzgEMTq7wCPVbn1z0 ejLOzlYPh115w3BxNGUZqYuA4qXYa6UI60Lu0824pYeDuXR+4cHbLlCYYCMqo2ogZ/T9uVUB73fBB 1KKYIdo1Q2eHp9yHc4emz+lNXN+zidZmlLx2+KR0wvZnw1hiGK8Chn2pPbwBbewbmgKEjyR/HyuyR NTiDhgNK/DOyOCaI0ZBrVz13+3oXjY6leSK/zu1NKbcublthPI9tRfOu65Zdf7fQlhmrDxHCHeIXU KHf00MPc6yVPUQ==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20230808163710.22801-1-thomas@thomaslabs.org> Date: Mon, 21 Aug 2023 19:22:18 +0200 In-Reply-To: <20230808163710.22801-1-thomas@thomaslabs.org> (Thomas Albers's message of "Tue, 8 Aug 2023 18:37:10 +0200") Message-ID: <875y588g51.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx2.migadu.com X-Migadu-Spam-Score: -6.90 X-Spam-Score: -6.90 X-Migadu-Queue-Id: 6ED3A548C1 X-TUID: oQBpJyGJBVdV Hi, Thomas Albers skribis: > * gnu/services/cgit.scm (cgit-configuration)[root-readme]: Accept > 'file-object' instead of only 'string' [...] > (root-readme > - (string "") > + (file-object "") > "The content of the file specified with this option will be included > verbatim below the \"about\" link on the repository index page.") I think it=E2=80=99s a good idea but (1) we should preserve backward compatibility for users passing a string (file contents), and (2) update the docstrings and its copy in the manual. Could you send a second version to address these? Let me know if anything=E2=80=99s unclear. Thanks, Ludo=E2=80=99.