unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Thomas Albers Raviola <thomas@thomaslabs.org>
Cc: 65152-done@debbugs.gnu.org
Subject: bug#65152: [PATCH] services: Modify cgit-configuration fields
Date: Sat, 09 Sep 2023 12:32:13 +0200	[thread overview]
Message-ID: <87sf7nzlg2.fsf_-_@gnu.org> (raw)
In-Reply-To: <87a5uj8mfm.fsf@alpha.mail-host-address-is-not-set> (Thomas Albers Raviola's message of "Tue, 22 Aug 2023 11:18:37 +0200")

Hi,

Thomas Albers Raviola <thomas@thomaslabs.org> skribis:

> in this context `file-object' is defined to be either a `file-like'
> object or a `string'. As such this wouldn't break backward compatibility
> but include a superset of possible values.
>
> Also the original string is not used as the contents of the readme file
> but as a file path.

Oh right, my bad, I had misunderstood that.  So it’s all good, applied!

Eventually we should probably replace ‘file-object’ by ‘file-like’,
unless there’s a clear use case for passing out-of-band file names (a
use case would be passwords, but probably not ‘README’ files).

Thanks!

Ludo’.




      reply	other threads:[~2023-09-09 10:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08 16:37 [bug#65152] [PATCH] services: Modify cgit-configuration fields Thomas Albers via Guix-patches via
2023-08-21 17:22 ` Ludovic Courtès
2023-08-22  9:18   ` Thomas Albers Raviola via Guix-patches via
2023-09-09 10:32     ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sf7nzlg2.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=65152-done@debbugs.gnu.org \
    --cc=thomas@thomaslabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).