From: ludo@gnu.org (Ludovic Courtès)
To: Eric Bavier <ericbavier@centurylink.net>
Cc: 28429@debbugs.gnu.org
Subject: [bug#28429] [PATCH] gnu: Add John the Ripper.
Date: Wed, 13 Sep 2017 23:22:21 +0200 [thread overview]
Message-ID: <874ls647le.fsf@gnu.org> (raw)
In-Reply-To: <20170913084627.535c4ec5@centurylink.net> (Eric Bavier's message of "Wed, 13 Sep 2017 08:46:27 -0500")
Heya,
Eric Bavier <ericbavier@centurylink.net> skribis:
> On Wed, 13 Sep 2017 10:10:39 +0200
[...]
>>
>> > + `(#:configure-flags
>> > + (list (string-append
>> > + "CFLAGS="
>>
>> Is this to clear CFLAGS? We should make sure to get “-O2 -g”.
>
> The macro definitions below must be put in CFLAGS, but yes, -O2 should
> be included.
OK.
>>
>> > + "-DJOHN_SYSTEMWIDE=1 "
>> > + "-DJOHN_SYSTEMWIDE_EXEC='\"" %output "/libexec/john\"' "
>> > + "-DJOHN_SYSTEMWIDE_HOME='\"" %output "/share/john\"'")
>> > + "--disable-native-tests"
>> > + "--disable-native-macro")
>>
>> Perhaps add a comment on these two flags.
>
> Sure. John supports a "cpu fallback" feature to match, at runtime, the
> current processor with an executable appropriate for its supported
> instruction set. This involves configuring and building multiple times
> with different optimization flags. I wanted to implement this later
> after getting the rest of things working, so these two flags turn off
> the "-march=native" flag and instruction set discovery during
> 'configure'.
Oh, I see. Thanks for explaining.
>> /etc/passwd in the build environment has this line (see
>> nix/libstore/build.cc:1859):
>>
>> nixbld:x:%1%:%2%:Nix build user:/:/noshell
>>
>> Isn’t it sufficient to have “/” as the home directory?
>
> It seems the build user noes not have sufficient permissions to create a
> directory there? The tests want to create "~/.john" (specifically
> "//.john").
And setting ‘HOME’ isn’t enough? (There are several packages where we
do that right before the ‘check’ phase.)
> From dd9795e5d63beaf06f2e3c76944e82a5564dc87d Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Mon, 11 Sep 2017 21:44:14 -0500
> Subject: [PATCH] gnu: Add John the Ripper.
>
> * gnu/packages/password-utils.scm (john-the-ripper-jumbo): New variable.
Perfect, thanks!
Ludo’.
next prev parent reply other threads:[~2017-09-13 21:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 2:50 [bug#28429] [PATCH] gnu: Add John the Ripper Eric Bavier
2017-09-13 8:10 ` Ludovic Courtès
2017-09-13 13:46 ` Eric Bavier
2017-09-13 21:22 ` Ludovic Courtès [this message]
2017-09-14 3:20 ` bug#28429: " Eric Bavier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ls647le.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=28429@debbugs.gnu.org \
--cc=ericbavier@centurylink.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).