From: ludo@gnu.org (Ludovic Courtès)
To: Eric Bavier <bavier@member.fsf.org>
Cc: 28429@debbugs.gnu.org
Subject: [bug#28429] [PATCH] gnu: Add John the Ripper.
Date: Wed, 13 Sep 2017 10:10:39 +0200 [thread overview]
Message-ID: <87vakn3tog.fsf@gnu.org> (raw)
In-Reply-To: <20170912025014.27269-1-bavier@member.fsf.org> (Eric Bavier's message of "Mon, 11 Sep 2017 21:50:14 -0500")
Hi Eric,
Eric Bavier <bavier@member.fsf.org> skribis:
> * gnu/packages/password-utils.scm (john-the-ripper-jumbo): New variable.
[...]
> + `(#:configure-flags
> + (list (string-append
> + "CFLAGS="
Is this to clear CFLAGS? We should make sure to get “-O2 -g”.
> + "-DJOHN_SYSTEMWIDE=1 "
> + "-DJOHN_SYSTEMWIDE_EXEC='\"" %output "/libexec/john\"' "
> + "-DJOHN_SYSTEMWIDE_HOME='\"" %output "/share/john\"'")
> + "--disable-native-tests"
> + "--disable-native-macro")
Perhaps add a comment on these two flags.
> + #:tests? #f ;tests assume /etc/passwd has a pw_dir for the build user
/etc/passwd in the build environment has this line (see
nix/libstore/build.cc:1859):
nixbld:x:%1%:%2%:Nix build user:/:/noshell
Isn’t it sufficient to have “/” as the home directory?
> + (description "John the Ripper is a fast password cracker. Its primary
> +purpose is to detect weak Unix passwords. Besides several crypt(3) password
Rather @code{crypt}.
Otherwise LGTM, thank you!
Ludo’.
next prev parent reply other threads:[~2017-09-13 8:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 2:50 [bug#28429] [PATCH] gnu: Add John the Ripper Eric Bavier
2017-09-13 8:10 ` Ludovic Courtès [this message]
2017-09-13 13:46 ` Eric Bavier
2017-09-13 21:22 ` Ludovic Courtès
2017-09-14 3:20 ` bug#28429: " Eric Bavier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vakn3tog.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=28429@debbugs.gnu.org \
--cc=bavier@member.fsf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).