From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39169) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsF7l-0007Xt-8t for guix-patches@gnu.org; Wed, 13 Sep 2017 17:23:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsF7k-0006Gv-7i for guix-patches@gnu.org; Wed, 13 Sep 2017 17:23:09 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:58524) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dsF7k-0006Gf-3k for guix-patches@gnu.org; Wed, 13 Sep 2017 17:23:08 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dsF7e-0005Tl-36 for guix-patches@gnu.org; Wed, 13 Sep 2017 17:23:02 -0400 Subject: [bug#28429] [PATCH] gnu: Add John the Ripper. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20170912025014.27269-1-bavier@member.fsf.org> <87vakn3tog.fsf@gnu.org> <20170913084627.535c4ec5@centurylink.net> Date: Wed, 13 Sep 2017 23:22:21 +0200 In-Reply-To: <20170913084627.535c4ec5@centurylink.net> (Eric Bavier's message of "Wed, 13 Sep 2017 08:46:27 -0500") Message-ID: <874ls647le.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Eric Bavier Cc: 28429@debbugs.gnu.org Heya, Eric Bavier skribis: > On Wed, 13 Sep 2017 10:10:39 +0200 [...] >>=20 >> > + `(#:configure-flags >> > + (list (string-append >> > + "CFLAGS=3D"=20=20 >>=20 >> Is this to clear CFLAGS? We should make sure to get =E2=80=9C-O2 -g=E2= =80=9D. > > The macro definitions below must be put in CFLAGS, but yes, -O2 should > be included. OK. >>=20 >> > + "-DJOHN_SYSTEMWIDE=3D1 " >> > + "-DJOHN_SYSTEMWIDE_EXEC=3D'\"" %output "/libexec/john= \"' " >> > + "-DJOHN_SYSTEMWIDE_HOME=3D'\"" %output "/share/john\"= '") >> > + "--disable-native-tests" >> > + "--disable-native-macro")=20=20 >>=20 >> Perhaps add a comment on these two flags. > > Sure. John supports a "cpu fallback" feature to match, at runtime, the > current processor with an executable appropriate for its supported > instruction set. This involves configuring and building multiple times > with different optimization flags. I wanted to implement this later > after getting the rest of things working, so these two flags turn off > the "-march=3Dnative" flag and instruction set discovery during > 'configure'. Oh, I see. Thanks for explaining. >> /etc/passwd in the build environment has this line (see >> nix/libstore/build.cc:1859): >>=20 >> nixbld:x:%1%:%2%:Nix build user:/:/noshell >>=20 >> Isn=E2=80=99t it sufficient to have =E2=80=9C/=E2=80=9D as the home dire= ctory? > > It seems the build user noes not have sufficient permissions to create a > directory there? The tests want to create "~/.john" (specifically > "//.john"). And setting =E2=80=98HOME=E2=80=99 isn=E2=80=99t enough? (There are severa= l packages where we do that right before the =E2=80=98check=E2=80=99 phase.) > From dd9795e5d63beaf06f2e3c76944e82a5564dc87d Mon Sep 17 00:00:00 2001 > From: Eric Bavier > Date: Mon, 11 Sep 2017 21:44:14 -0500 > Subject: [PATCH] gnu: Add John the Ripper. > > * gnu/packages/password-utils.scm (john-the-ripper-jumbo): New variable. Perfect, thanks! Ludo=E2=80=99.