unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: 30340@debbugs.gnu.org
Subject: [bug#30340] [PATCH 1/6] gnu: qtbase: Use the store paths for other packages and dynamically loaded libs.
Date: Sat, 17 Feb 2018 17:08:40 +0100	[thread overview]
Message-ID: <874lmflhtj.fsf@gnu.org> (raw)
In-Reply-To: <4fa3562d-7e3e-3008-e371-d5002370d533@crazy-compilers.com> (Hartmut Goebel's message of "Fri, 16 Feb 2018 19:49:54 +0100")

Hi Hartmut,

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> - Should I keep or drop these "Add note about a patch NixOS …" patches
> (2,3,5,6)

IMO yes.

> - If dropping: Should I use a short living branch as described in
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=30340#62

IMO no—as you know we keep the history linear whenever possible.

At the end of the day, what matters is that these patches get in.  We
shouldn’t spend so long rehashing our views on how to write comments.

Also, you have commit access because as a group we trust you to be able
to make simple decisions in line with the group conventions and
practices.  Once you’ve had initial feedback, you should feel empowered.

Thanks for working on this!

Ludo’.

  reply	other threads:[~2018-02-17 16:09 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-03 19:22 [bug#30340] [PATCH 0/6] Adopt NixOS patches for Qt5 Hartmut Goebel
2018-02-03 19:25 ` [bug#30340] [PATCH 1/6] gnu: qtbase: Use the store paths for other packages and dynamically loaded libs Hartmut Goebel
2018-02-03 19:25   ` [bug#30340] [PATCH 2/6] gnu: qtdeclarative: Add note about a patch NixOS has but we don't need Hartmut Goebel
2018-02-06  8:52     ` Danny Milosavljevic
2018-02-03 19:25   ` [bug#30340] [PATCH 3/6] gnu: qtscript: " Hartmut Goebel
2018-02-06  8:53     ` Danny Milosavljevic
2018-02-03 19:25   ` [bug#30340] [PATCH 4/6] gnu: qtserialport: Use the store paths for dynamically loaded libs Hartmut Goebel
2018-02-06  8:55     ` Danny Milosavljevic
2018-02-03 19:25   ` [bug#30340] [PATCH 5/6] gnu: qttools: Add note about a patch NixOS has but we don't need Hartmut Goebel
2018-02-06  8:54     ` Danny Milosavljevic
2018-02-03 19:25   ` [bug#30340] [PATCH 6/6] gnu: qtwebkit: " Hartmut Goebel
2018-02-06  8:57     ` Danny Milosavljevic
2018-02-06  9:00   ` [bug#30340] [PATCH 1/6] gnu: qtbase: Use the store paths for other packages and dynamically loaded libs Danny Milosavljevic
2018-02-06 11:57     ` Hartmut Goebel
2018-02-06 17:54       ` Danny Milosavljevic
2018-02-08 23:49         ` Hartmut Goebel
2018-02-07 16:16   ` Marius Bakke
2018-02-12 15:37     ` Hartmut Goebel
2018-02-13 22:48       ` Marius Bakke
2018-02-16 16:18         ` Hartmut Goebel
2018-02-16 16:49           ` Ludovic Courtès
2018-02-16 18:49             ` [bug#30340] " Hartmut Goebel
2018-02-17 16:08               ` Ludovic Courtès [this message]
2018-02-17 20:25                 ` Leo Famulari
2018-02-16 16:26         ` Hartmut Goebel
2018-02-16 16:36           ` Marius Bakke
2018-02-09 13:43   ` Ludovic Courtès
2018-02-12 15:59     ` Hartmut Goebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874lmflhtj.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=30340@debbugs.gnu.org \
    --cc=h.goebel@crazy-compilers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).