From: Hartmut Goebel <h.goebel@crazy-compilers.com>
To: Marius Bakke <mbakke@fastmail.com>, 30340@debbugs.gnu.org
Subject: [bug#30340] [PATCH 1/6] gnu: qtbase: Use the store paths for other packages and dynamically loaded libs.
Date: Mon, 12 Feb 2018 16:37:18 +0100 [thread overview]
Message-ID: <180a63cd-4939-4752-f3ba-dc7534465cc9@crazy-compilers.com> (raw)
In-Reply-To: <87k1voixl0.fsf@fastmail.com>
[-- Attachment #1: Type: text/plain, Size: 2358 bytes --]
Am 07.02.2018 um 17:16 schrieb Marius Bakke:
> Hartmut Goebel <h.goebel@crazy-compilers.com> writes:
>
>> Adobt the NixOS patches as of 2018-01-19:
> I don't see any patches in this series.
I only *adopted* what NixOs does with patches, not the patches itself. I
will rework this.
> FWIW I think we deviate enough
> from NixOS at this point that the comments are unnecessary.
Are you referring to patch (1/6)? Or do you mean patches 2, 3, 5 and 6
are unnecessary?
I do not care about the comments, but FMPOV it is important to document
somehow in the code or in the commits that all patches as of 2018-01-19
have been considered. an alternative would be to group these few commits
into a (very short) branch and documenting the fact in the merge-commit.
WDYT?
>> - src/corelib/tools/qtimezoneprivate_tz.cpp: NixOS uses $TZDIR, we use
>> hardcoded path to tzdata.
> Why hardcode the path? We set TZDIR as well in (gnu system).
The upstream code (qt.com) uses hard-coded path (/usr/share/zoneinfo/),
so for me it seems to be much more natural to simply change this - and
stay closer to upstream. NixOS seems to require TZDATA since some things
work differently compared to guix. E.g. nixos is deriving library search
paths from $PATH in some other patch. This is something guix does not need.
>> + (add-after 'unpack 'patch-paths
>> + ;; Use the absolute paths for dynamically loaded libs, otherwise
>> + ;; the lib will be searched in the actual executable's RUNPATH,
>> + ;; which may not include the requested lib.
> Is there any reason we cannot add these libraries to RUNPATH instead?
> The below approach seems somewhat fragile to me.
Rethinking this, this comment is wrong and I'll correct it. QLibrary
(which is used an all these cases) is documented with:
When loading the library, QLibrary
<http://doc.qt.io/qt-5/qlibrary.html> searches in all the
system-specific library locations (e.g. |LD_LIBRARY_PATH| on Unix),
unless the file name has an absolute path.
But guix does not set LD_LIBRARYPATH (e.g. in "guix environment"), thus
we need to have absolute paths for the libraries.
Does this make sense?
--
Regards
Hartmut Goebel
| Hartmut Goebel | h.goebel@crazy-compilers.com |
| www.crazy-compilers.com | compilers which you thought are impossible |
[-- Attachment #2: Type: text/html, Size: 3802 bytes --]
next prev parent reply other threads:[~2018-02-12 15:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-03 19:22 [bug#30340] [PATCH 0/6] Adopt NixOS patches for Qt5 Hartmut Goebel
2018-02-03 19:25 ` [bug#30340] [PATCH 1/6] gnu: qtbase: Use the store paths for other packages and dynamically loaded libs Hartmut Goebel
2018-02-03 19:25 ` [bug#30340] [PATCH 2/6] gnu: qtdeclarative: Add note about a patch NixOS has but we don't need Hartmut Goebel
2018-02-06 8:52 ` Danny Milosavljevic
2018-02-03 19:25 ` [bug#30340] [PATCH 3/6] gnu: qtscript: " Hartmut Goebel
2018-02-06 8:53 ` Danny Milosavljevic
2018-02-03 19:25 ` [bug#30340] [PATCH 4/6] gnu: qtserialport: Use the store paths for dynamically loaded libs Hartmut Goebel
2018-02-06 8:55 ` Danny Milosavljevic
2018-02-03 19:25 ` [bug#30340] [PATCH 5/6] gnu: qttools: Add note about a patch NixOS has but we don't need Hartmut Goebel
2018-02-06 8:54 ` Danny Milosavljevic
2018-02-03 19:25 ` [bug#30340] [PATCH 6/6] gnu: qtwebkit: " Hartmut Goebel
2018-02-06 8:57 ` Danny Milosavljevic
2018-02-06 9:00 ` [bug#30340] [PATCH 1/6] gnu: qtbase: Use the store paths for other packages and dynamically loaded libs Danny Milosavljevic
2018-02-06 11:57 ` Hartmut Goebel
2018-02-06 17:54 ` Danny Milosavljevic
2018-02-08 23:49 ` Hartmut Goebel
2018-02-07 16:16 ` Marius Bakke
2018-02-12 15:37 ` Hartmut Goebel [this message]
2018-02-13 22:48 ` Marius Bakke
2018-02-16 16:18 ` Hartmut Goebel
2018-02-16 16:49 ` Ludovic Courtès
2018-02-16 18:49 ` [bug#30340] " Hartmut Goebel
2018-02-17 16:08 ` Ludovic Courtès
2018-02-17 20:25 ` Leo Famulari
2018-02-16 16:26 ` Hartmut Goebel
2018-02-16 16:36 ` Marius Bakke
2018-02-09 13:43 ` Ludovic Courtès
2018-02-12 15:59 ` Hartmut Goebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=180a63cd-4939-4752-f3ba-dc7534465cc9@crazy-compilers.com \
--to=h.goebel@crazy-compilers.com \
--cc=30340@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).