From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39414) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1en52w-0002BI-O9 for guix-patches@gnu.org; Sat, 17 Feb 2018 11:09:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1en52s-0002Lx-OJ for guix-patches@gnu.org; Sat, 17 Feb 2018 11:09:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:40578) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1en52s-0002Lq-KR for guix-patches@gnu.org; Sat, 17 Feb 2018 11:09:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1en52s-0007bw-By for guix-patches@gnu.org; Sat, 17 Feb 2018 11:09:02 -0500 Subject: [bug#30340] [PATCH 1/6] gnu: qtbase: Use the store paths for other packages and dynamically loaded libs. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20180203192212.29173-1-h.goebel@crazy-compilers.com> <20180203192505.29516-1-h.goebel@crazy-compilers.com> <87k1voixl0.fsf@fastmail.com> <180a63cd-4939-4752-f3ba-dc7534465cc9@crazy-compilers.com> <87sha4wlot.fsf@fastmail.com> <23d7b29f-00ad-b167-c8ba-a8f5386f51e2@crazy-compilers.com> <87606wnale.fsf@gnu.org> <4fa3562d-7e3e-3008-e371-d5002370d533@crazy-compilers.com> Date: Sat, 17 Feb 2018 17:08:40 +0100 In-Reply-To: <4fa3562d-7e3e-3008-e371-d5002370d533@crazy-compilers.com> (Hartmut Goebel's message of "Fri, 16 Feb 2018 19:49:54 +0100") Message-ID: <874lmflhtj.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Hartmut Goebel Cc: 30340@debbugs.gnu.org Hi Hartmut, Hartmut Goebel skribis: > - Should I keep or drop these "Add note about a patch NixOS =E2=80=A6" pa= tches > (2,3,5,6) IMO yes. > - If dropping: Should I use a short living branch as described in > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D30340#62 IMO no=E2=80=94as you know we keep the history linear whenever possible. At the end of the day, what matters is that these patches get in. We shouldn=E2=80=99t spend so long rehashing our views on how to write comment= s. Also, you have commit access because as a group we trust you to be able to make simple decisions in line with the group conventions and practices. Once you=E2=80=99ve had initial feedback, you should feel empow= ered. Thanks for working on this! Ludo=E2=80=99.