From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: 47402@debbugs.gnu.org
Cc: qblade@protonmail.com
Subject: [bug#47402] gnu: Add emacs-sdcv
Date: Fri, 26 Mar 2021 15:03:27 +0100 [thread overview]
Message-ID: <874kgy3tcg.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <Fm5We2Wu-muqRnOwFgu3LuRa5F1pXOE3B2IbUVOO7ohhw_r_ccsAuf3WYjqa-bVEhzXETi9gc91rOPsuwzamXLFn8UnkqSiVzlfB_Bcr-9Y=@protonmail.com> (qblade via Guix-patches via's message of "Fri, 26 Mar 2021 06:18:50 +0000")
Hello,
qblade via Guix-patches via <guix-patches@gnu.org> writes:
> I submitted two patches, emacs-showtip is a dependency of emacs-sdcv.
Thank you. Some comments follow.
> +(define-public emacs-showtip
> + (package
> + (name "emacs-showtip")
> + (version "20090830.1040")
This is not the correct version number. Main file indicates "0.01".
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/emacsorphanage/showtip")
> + (commit
> + "930da302809a4257e8d69425455b29e1cc91949b")))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "01zak0zhha6dp7a2hm28d065gjnc462iwpsfyxhbxgfzcdlicqc7"))))
> + (build-system emacs-build-system)
> + (home-page "https://github.com/emacsorphanage/showtip")
> + (synopsis "Show tip at cursor")
> + (description
> + "This library export one function for elisp programer to show
> +tooltip near the cursor not the mouse.")
export -> exports or even, provides
I would also drop the "for Elisp programmer" part.
> +(define-public emacs-sdcv
> + (package
> + (name "emacs-sdcv")
> + (version "20190610.732")
The correct version number seems to be 1.5.2 on the GitHub repository,
and 2.9 on emacswiki. However, using Emacswiki as a source is not an
option, since there is no archival for outdated releases there, AFAICT.
Are we stuck with an old release?
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/stardiviner/sdcv.el")
> + (commit
> + "943ae3e90cc9a0a88a37cc710acd7424fd4defc4")))
Since you're targetting a specific commit, you need to add a commit and
a revision binding at the top of the definition. See, e.g.,
emacs-vterm-toggle.
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "0i1ylvw7p46pkf3yyyzcdmdhsspzymnnnvx8s0i7vynngr5x0vzh"))))
> + (build-system emacs-build-system)
> + (propagated-inputs
> + `(("emacs-popup" ,emacs-popup)
> + ("emacs-showtip" ,emacs-showtip)
> + ("emacs-pos-tip" ,emacs-pos-tip)))
> + (home-page
> + "https://www.emacswiki.org/emacs/download/sdcv.el")
> + (synopsis
> + "Emacs interface for sdcv")
Could you explain quickly what SDCV is in the synopsis?
> + (description
> + "Translate word by sdcv (console version of Stardict), and display
> +translation use popup tooltip or buffer.")
The description needs to consist of full sentences.
Could you send updated patches?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2021-03-26 14:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 6:18 [bug#47402] gnu: Add emacs-sdcv qblade via Guix-patches via
2021-03-26 14:03 ` Nicolas Goaziou [this message]
2021-03-27 11:42 ` [bug#47402] 回复: " qblade via Guix-patches via
2021-04-01 14:08 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kgy3tcg.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=47402@debbugs.gnu.org \
--cc=qblade@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).