* [bug#47402] gnu: Add emacs-sdcv
@ 2021-03-26 6:18 qblade via Guix-patches via
2021-03-26 14:03 ` Nicolas Goaziou
0 siblings, 1 reply; 4+ messages in thread
From: qblade via Guix-patches via @ 2021-03-26 6:18 UTC (permalink / raw)
To: 47402
[-- Attachment #1: Type: text/plain, Size: 69 bytes --]
I submitted two patches, emacs-showtip is a dependency of emacs-sdcv.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-emacs-showtip.patch --]
[-- Type: text/x-patch; name=0001-gnu-Add-emacs-showtip.patch, Size: 1827 bytes --]
From a224c70cf553261d1f7b1ef434d1f4c584dc9d8f Mon Sep 17 00:00:00 2001
From: qblade <qblade@protonmail.com>
Date: Fri, 26 Mar 2021 01:16:20 +0000
Subject: [PATCH 1/2] gnu: Add emacs-showtip
* gnu/packages/emacs-xyz.scm (emacs-showtip): New variable.
---
gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f45507c647..bf3cac7b44 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -95,6 +95,7 @@
;;; Copyright © 2021 Alexey Abramov <levenson@mmer.org>
;;; Copyright © 2021 Xinglu Chen <public@yoctocell.xyz>
;;; Copyright © 2021 Stefan Reichör <stefan@xsteve.at>
+;;; Copyright © 2021 qblade <qblade@protonmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -27350,3 +27351,26 @@ and prefered services can easily be configured.")
quasi-prefix map, with many useful bindings. These bindings are
shorter than usual, using mostly unprefixed keys.")
(license license:gpl3+)))
+
+(define-public emacs-showtip
+ (package
+ (name "emacs-showtip")
+ (version "20090830.1040")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/emacsorphanage/showtip")
+ (commit
+ "930da302809a4257e8d69425455b29e1cc91949b")))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "01zak0zhha6dp7a2hm28d065gjnc462iwpsfyxhbxgfzcdlicqc7"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/emacsorphanage/showtip")
+ (synopsis "Show tip at cursor")
+ (description
+ "This library export one function for elisp programer to show
+tooltip near the cursor not the mouse.")
+ (license license:gpl2+)))
--
2.31.0
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0002-gnu-Add-emacs-sdcv.patch --]
[-- Type: text/x-patch; name=0002-gnu-Add-emacs-sdcv.patch, Size: 1694 bytes --]
From 257b3463c7a1a4b35768bf8070d69ebe133b1ae5 Mon Sep 17 00:00:00 2001
From: qblade <qblade@protonmail.com>
Date: Fri, 26 Mar 2021 01:18:23 +0000
Subject: [PATCH 2/2] gnu: Add emacs-sdcv
* gnu/packages/emacs-xyz.scm (emacs-sdcv): New variable.
---
gnu/packages/emacs-xyz.scm | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index bf3cac7b44..5b7ce93a27 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -27374,3 +27374,32 @@ shorter than usual, using mostly unprefixed keys.")
"This library export one function for elisp programer to show
tooltip near the cursor not the mouse.")
(license license:gpl2+)))
+
+(define-public emacs-sdcv
+ (package
+ (name "emacs-sdcv")
+ (version "20190610.732")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/stardiviner/sdcv.el")
+ (commit
+ "943ae3e90cc9a0a88a37cc710acd7424fd4defc4")))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0i1ylvw7p46pkf3yyyzcdmdhsspzymnnnvx8s0i7vynngr5x0vzh"))))
+ (build-system emacs-build-system)
+ (propagated-inputs
+ `(("emacs-popup" ,emacs-popup)
+ ("emacs-showtip" ,emacs-showtip)
+ ("emacs-pos-tip" ,emacs-pos-tip)))
+ (home-page
+ "https://www.emacswiki.org/emacs/download/sdcv.el")
+ (synopsis
+ "Emacs interface for sdcv")
+ (description
+ "Translate word by sdcv (console version of Stardict), and display
+translation use popup tooltip or buffer.")
+ (license license:gpl3+)))
--
2.31.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#47402] gnu: Add emacs-sdcv
2021-03-26 6:18 [bug#47402] gnu: Add emacs-sdcv qblade via Guix-patches via
@ 2021-03-26 14:03 ` Nicolas Goaziou
2021-03-27 11:42 ` [bug#47402] 回复: " qblade via Guix-patches via
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Goaziou @ 2021-03-26 14:03 UTC (permalink / raw)
To: 47402; +Cc: qblade
Hello,
qblade via Guix-patches via <guix-patches@gnu.org> writes:
> I submitted two patches, emacs-showtip is a dependency of emacs-sdcv.
Thank you. Some comments follow.
> +(define-public emacs-showtip
> + (package
> + (name "emacs-showtip")
> + (version "20090830.1040")
This is not the correct version number. Main file indicates "0.01".
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/emacsorphanage/showtip")
> + (commit
> + "930da302809a4257e8d69425455b29e1cc91949b")))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "01zak0zhha6dp7a2hm28d065gjnc462iwpsfyxhbxgfzcdlicqc7"))))
> + (build-system emacs-build-system)
> + (home-page "https://github.com/emacsorphanage/showtip")
> + (synopsis "Show tip at cursor")
> + (description
> + "This library export one function for elisp programer to show
> +tooltip near the cursor not the mouse.")
export -> exports or even, provides
I would also drop the "for Elisp programmer" part.
> +(define-public emacs-sdcv
> + (package
> + (name "emacs-sdcv")
> + (version "20190610.732")
The correct version number seems to be 1.5.2 on the GitHub repository,
and 2.9 on emacswiki. However, using Emacswiki as a source is not an
option, since there is no archival for outdated releases there, AFAICT.
Are we stuck with an old release?
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/stardiviner/sdcv.el")
> + (commit
> + "943ae3e90cc9a0a88a37cc710acd7424fd4defc4")))
Since you're targetting a specific commit, you need to add a commit and
a revision binding at the top of the definition. See, e.g.,
emacs-vterm-toggle.
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "0i1ylvw7p46pkf3yyyzcdmdhsspzymnnnvx8s0i7vynngr5x0vzh"))))
> + (build-system emacs-build-system)
> + (propagated-inputs
> + `(("emacs-popup" ,emacs-popup)
> + ("emacs-showtip" ,emacs-showtip)
> + ("emacs-pos-tip" ,emacs-pos-tip)))
> + (home-page
> + "https://www.emacswiki.org/emacs/download/sdcv.el")
> + (synopsis
> + "Emacs interface for sdcv")
Could you explain quickly what SDCV is in the synopsis?
> + (description
> + "Translate word by sdcv (console version of Stardict), and display
> +translation use popup tooltip or buffer.")
The description needs to consist of full sentences.
Could you send updated patches?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#47402] 回复: Re: [bug#47402] gnu: Add emacs-sdcv
2021-03-26 14:03 ` Nicolas Goaziou
@ 2021-03-27 11:42 ` qblade via Guix-patches via
2021-04-01 14:08 ` Nicolas Goaziou
0 siblings, 1 reply; 4+ messages in thread
From: qblade via Guix-patches via @ 2021-03-27 11:42 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: 47402
[-- Attachment #1: Type: text/plain, Size: 3 bytes --]
OK.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-emacs-showtip.patch --]
[-- Type: text/x-patch; name=0001-gnu-Add-emacs-showtip.patch, Size: 1891 bytes --]
From de8f980187524dc311d6160e67f1abf077e209e2 Mon Sep 17 00:00:00 2001
From: qblade <qblade@protonmail.com>
Date: Sat, 27 Mar 2021 06:57:55 +0000
Subject: [PATCH 1/2] gnu: Add emacs-showtip.
* gnu/packages/emacs-xyz.scm (emacs-showtip): New variable.
---
gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f45507c647..ec810e2bca 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -95,6 +95,7 @@
;;; Copyright © 2021 Alexey Abramov <levenson@mmer.org>
;;; Copyright © 2021 Xinglu Chen <public@yoctocell.xyz>
;;; Copyright © 2021 Stefan Reichör <stefan@xsteve.at>
+;;; Copyright © 2021 qblade <qblade@protonmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -27350,3 +27351,27 @@ and prefered services can easily be configured.")
quasi-prefix map, with many useful bindings. These bindings are
shorter than usual, using mostly unprefixed keys.")
(license license:gpl3+)))
+
+(define-public emacs-showtip
+ (let ((commit "930da302809a4257e8d69425455b29e1cc91949b")
+ (revision "0"))
+ (package
+ (name "emacs-showtip")
+ (version (git-version "0.01" revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/emacsorphanage/showtip")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "01zak0zhha6dp7a2hm28d065gjnc462iwpsfyxhbxgfzcdlicqc7"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/emacsorphanage/showtip")
+ (synopsis "Show tip at cursor")
+ (description
+ "This library provide one function to show
+tooltip near the cursor.")
+ (license license:gpl2+))))
--
2.31.0
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0002-gnu-Add-emacs-sdcv.patch --]
[-- Type: text/x-patch; name=0002-gnu-Add-emacs-sdcv.patch, Size: 1774 bytes --]
From c3c36399e2ad7a0229dbec855f1bf3a7aaf0c169 Mon Sep 17 00:00:00 2001
From: qblade <qblade@protonmail.com>
Date: Sat, 27 Mar 2021 07:01:56 +0000
Subject: [PATCH 2/2] gnu: Add emacs-sdcv.
* gnu/packages/emacs-xyz.scm (emacs-sdcv): New variable.
---
gnu/packages/emacs-xyz.scm | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ec810e2bca..cfd5b83947 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -27375,3 +27375,33 @@ shorter than usual, using mostly unprefixed keys.")
"This library provide one function to show
tooltip near the cursor.")
(license license:gpl2+))))
+
+(define-public emacs-sdcv
+ (let ((commit "943ae3e90cc9a0a88a37cc710acd7424fd4defc4" )
+ (revision "0"))
+ (package
+ (name "emacs-sdcv")
+ (version (git-version "1.5.2" revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/stardiviner/sdcv.el")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0i1ylvw7p46pkf3yyyzcdmdhsspzymnnnvx8s0i7vynngr5x0vzh"))))
+ (build-system emacs-build-system)
+ (propagated-inputs
+ `(("emacs-popup" ,emacs-popup)
+ ("emacs-showtip" ,emacs-showtip)
+ ("emacs-pos-tip" ,emacs-pos-tip)))
+ (home-page
+ "https://www.emacswiki.org/emacs/download/sdcv.el")
+ (synopsis
+ "Emacs interface for $code{sdcv}")
+ (description
+ "This plugin translate word by @code{sdcv}, and display
+translation use popup tooltip or buffer.")
+ (license license:gpl3+))))
--
2.31.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#47402] 回复: Re: [bug#47402] gnu: Add emacs-sdcv
2021-03-27 11:42 ` [bug#47402] 回复: " qblade via Guix-patches via
@ 2021-04-01 14:08 ` Nicolas Goaziou
0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2021-04-01 14:08 UTC (permalink / raw)
To: qblade; +Cc: 47402-done, 47402
Hello,
qblade <qblade@protonmail.com> writes:
> OK.
Applied, with minor modifications.
Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-01 14:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-26 6:18 [bug#47402] gnu: Add emacs-sdcv qblade via Guix-patches via
2021-03-26 14:03 ` Nicolas Goaziou
2021-03-27 11:42 ` [bug#47402] 回复: " qblade via Guix-patches via
2021-04-01 14:08 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).