From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id EOoRF+7pXWBMCAEAgWs5BA (envelope-from ) for ; Fri, 26 Mar 2021 15:04:30 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id kKL4EO7pXWDmawAAB5/wlQ (envelope-from ) for ; Fri, 26 Mar 2021 14:04:30 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C8F3D279ED for ; Fri, 26 Mar 2021 15:04:29 +0100 (CET) Received: from localhost ([::1]:53530 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPn4e-0007wy-Jf for larch@yhetil.org; Fri, 26 Mar 2021 10:04:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49894) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPn4F-0007ve-4u for guix-patches@gnu.org; Fri, 26 Mar 2021 10:04:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58848) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lPn4E-0005C3-Tm for guix-patches@gnu.org; Fri, 26 Mar 2021 10:04:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lPn4E-00056j-Oi for guix-patches@gnu.org; Fri, 26 Mar 2021 10:04:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47402] gnu: Add emacs-sdcv Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 26 Mar 2021 14:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47402 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 47402@debbugs.gnu.org Cc: qblade@protonmail.com X-Debbugs-Original-To: qblade via Guix-patches via X-Debbugs-Original-Cc: 47402@debbugs.gnu.org, qblade Received: via spool by 47402-submit@debbugs.gnu.org id=B47402.161676741819587 (code B ref 47402); Fri, 26 Mar 2021 14:04:02 +0000 Received: (at 47402) by debbugs.gnu.org; 26 Mar 2021 14:03:38 +0000 Received: from localhost ([127.0.0.1]:42158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPn3p-00055q-Vn for submit@debbugs.gnu.org; Fri, 26 Mar 2021 10:03:38 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:56017) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPn3n-00055S-KX for 47402@debbugs.gnu.org; Fri, 26 Mar 2021 10:03:36 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id B7C36E000D; Fri, 26 Mar 2021 14:03:28 +0000 (UTC) From: Nicolas Goaziou References: Date: Fri, 26 Mar 2021 15:03:27 +0100 In-Reply-To: (qblade via Guix-patches via's message of "Fri, 26 Mar 2021 06:18:50 +0000") Message-ID: <874kgy3tcg.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616767469; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=9Nb4KypQ3jS1YnBzEZgz8YvYVTPeJvNRChjZbLw6VcU=; b=ARP1JCnJV9K23onS4yHuHasH+hU1d1VYzNc3JxOZWmXKYtAj+aScQ1D74t7BFMpHj/nkPD thHa8OzY2c9XBdd5FmbirgPGVUjYZERNcowwesdaysyIBXykNhNgegMrIq3oUxSOBPfo/v sPOE0HkZHKWW7scVnaR5NgwGD7u2oTicUOy0zlQfiCc1UqKVF9pTzTyycTOZmvOeBGv9UN VdlK+CGfapg6yd8hCzyO/TNHa5Ci44XaNtzoRvL3Y0oXKe/qtTq60HmlsZ8TDy7tNYrzRb Qlot3hbgPjc67TQWhAKIRmK8pWFdzn2/McEUBh4UT1B9qMZGcy1unrfYg69v5w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616767469; a=rsa-sha256; cv=none; b=FWMjTzJDUCS8wQaqBem1YFR+AhcobeMvoxGd84avQE4/TjY0WIUt8eRiwck9F1dReSCqW+ WTMwneBknEfmmwOurVKFsuzBNZ6jdUS3T96JU7lJX+FVxVLO0bgKT/U5Ffhx33R0mzSacK CyT3m0L9YEUPQ5XcKr9YPFmPTn0TnOAs53ZknTpx/bQAtMdDLSpn1pVmlmXuhMdBioT00Q LAx49lJj0YbedXZPCvNJzsog1iC5Z8dXNYxiWgFj4e4Rc1a3jcrXnFjaRNzZIF+dRcT/d7 u+pmX2vR2PrJHs3I5udV1dLD8uStp+zXN1gLPBT6dhtH6XOmLxrUx2fz5PRWMw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.97 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: C8F3D279ED X-Spam-Score: -2.97 X-Migadu-Scanner: scn0.migadu.com X-TUID: 7jUlUAeCwKMg Hello, qblade via Guix-patches via writes: > I submitted two patches, emacs-showtip is a dependency of emacs-sdcv. Thank you. Some comments follow. > +(define-public emacs-showtip > + (package > + (name "emacs-showtip") > + (version "20090830.1040") This is not the correct version number. Main file indicates "0.01". > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/emacsorphanage/showtip") > + (commit > + "930da302809a4257e8d69425455b29e1cc91949b"))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "01zak0zhha6dp7a2hm28d065gjnc462iwpsfyxhbxgfzcdlicqc7")))) > + (build-system emacs-build-system) > + (home-page "https://github.com/emacsorphanage/showtip") > + (synopsis "Show tip at cursor") > + (description > + "This library export one function for elisp programer to show > +tooltip near the cursor not the mouse.") export -> exports or even, provides I would also drop the "for Elisp programmer" part. > +(define-public emacs-sdcv > + (package > + (name "emacs-sdcv") > + (version "20190610.732") The correct version number seems to be 1.5.2 on the GitHub repository, and 2.9 on emacswiki. However, using Emacswiki as a source is not an option, since there is no archival for outdated releases there, AFAICT. Are we stuck with an old release? > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/stardiviner/sdcv.el") > + (commit > + "943ae3e90cc9a0a88a37cc710acd7424fd4defc4"))) Since you're targetting a specific commit, you need to add a commit and a revision binding at the top of the definition. See, e.g., emacs-vterm-toggle. > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0i1ylvw7p46pkf3yyyzcdmdhsspzymnnnvx8s0i7vynngr5x0vzh")))) > + (build-system emacs-build-system) > + (propagated-inputs > + `(("emacs-popup" ,emacs-popup) > + ("emacs-showtip" ,emacs-showtip) > + ("emacs-pos-tip" ,emacs-pos-tip))) > + (home-page > + "https://www.emacswiki.org/emacs/download/sdcv.el") > + (synopsis > + "Emacs interface for sdcv") Could you explain quickly what SDCV is in the synopsis? > + (description > + "Translate word by sdcv (console version of Stardict), and display > +translation use popup tooltip or buffer.") The description needs to consist of full sentences. Could you send updated patches? Regards, -- Nicolas Goaziou