* [bug#30925] [PATCH] gnu: Add emacs-puppet-mode.
@ 2018-03-24 15:59 Christopher Baines
2018-03-26 17:54 ` Marius Bakke
2018-06-11 18:46 ` Christopher Baines
0 siblings, 2 replies; 7+ messages in thread
From: Christopher Baines @ 2018-03-24 15:59 UTC (permalink / raw)
To: 30925
* gnu/packages/emacs.scm (emacs-puppet-mode): New variable.
---
gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index de0ee358d..a6dc5d866 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -2772,6 +2772,30 @@ This provides a basic API and common UI widgets such as popup tooltips
and popup menus.")
(license license:gpl3+)))
+(define-public emacs-puppet-mode
+ (let ((commit "b3ed5057166a4f49dfa9be638523a348b55a2fd2")
+ (revision "1"))
+ (package
+ (name "emacs-puppet-mode")
+ (version (git-version "0.3" revision commit))
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append
+ "https://raw.githubusercontent.com/voxpupuli/puppet-mode/"
+ commit "/puppet-mode.el"))
+ (sha256
+ (base32
+ "1indycxawsl0p2aqqg754f6735q3cmah9vd886rpn0ncc3ipi1xm"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/voxpupuli/puppet-mode")
+ (synopsis "Emacs major mode for the Puppet configuration language")
+ (description
+ "This package provides support for the Puppet configuration language,
+including syntax highlighting, indentation of expressions and statements,
+linting of manifests and integration with Puppet Debugger.")
+ (license license:gpl3+))))
+
(define-public emacs-god-mode
(let ((commit "6cf0807b6555eb6fcf8387a4e3b667071ef38964")
(revision "1"))
--
2.16.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* [bug#30925] [PATCH] gnu: Add emacs-puppet-mode.
2018-03-24 15:59 [bug#30925] [PATCH] gnu: Add emacs-puppet-mode Christopher Baines
@ 2018-03-26 17:54 ` Marius Bakke
2018-05-17 14:32 ` Christopher Baines
2018-06-11 18:54 ` Christopher Baines
2018-06-11 18:46 ` Christopher Baines
1 sibling, 2 replies; 7+ messages in thread
From: Marius Bakke @ 2018-03-26 17:54 UTC (permalink / raw)
To: Christopher Baines, 30925
[-- Attachment #1: Type: text/plain, Size: 1411 bytes --]
Christopher Baines <mail@cbaines.net> writes:
> * gnu/packages/emacs.scm (emacs-puppet-mode): New variable.
[...]
> +(define-public emacs-puppet-mode
> + (let ((commit "b3ed5057166a4f49dfa9be638523a348b55a2fd2")
> + (revision "1"))
> + (package
> + (name "emacs-puppet-mode")
> + (version (git-version "0.3" revision commit))
Maybe mention why we can't take the 0.3 tag?
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://raw.githubusercontent.com/voxpupuli/puppet-mode/"
> + commit "/puppet-mode.el"))
It would be nice to install the README too, but no strong opinion.
> + (sha256
> + (base32
> + "1indycxawsl0p2aqqg754f6735q3cmah9vd886rpn0ncc3ipi1xm"))))
> + (build-system emacs-build-system)
> + (home-page "https://github.com/voxpupuli/puppet-mode")
> + (synopsis "Emacs major mode for the Puppet configuration language")
> + (description
> + "This package provides support for the Puppet configuration language,
> +including syntax highlighting, indentation of expressions and statements,
> +linting of manifests and integration with Puppet Debugger.")
> + (license license:gpl3+))))
Perhaps mention in a comment that it includes ASL code, as mentioned in
puppet-mode.el.
LGTM otherwise.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#30925] [PATCH] gnu: Add emacs-puppet-mode.
2018-03-26 17:54 ` Marius Bakke
@ 2018-05-17 14:32 ` Christopher Baines
2018-06-11 18:54 ` Christopher Baines
1 sibling, 0 replies; 7+ messages in thread
From: Christopher Baines @ 2018-05-17 14:32 UTC (permalink / raw)
To: Marius Bakke; +Cc: 30925
[-- Attachment #1: Type: text/plain, Size: 1614 bytes --]
Marius Bakke <mbakke@fastmail.com> writes:
> Christopher Baines <mail@cbaines.net> writes:
>
>> * gnu/packages/emacs.scm (emacs-puppet-mode): New variable.
>
> [...]
>
>> +(define-public emacs-puppet-mode
>> + (let ((commit "b3ed5057166a4f49dfa9be638523a348b55a2fd2")
>> + (revision "1"))
>> + (package
>> + (name "emacs-puppet-mode")
>> + (version (git-version "0.3" revision commit))
>
> Maybe mention why we can't take the 0.3 tag?
>
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (string-append
>> + "https://raw.githubusercontent.com/voxpupuli/puppet-mode/"
>> + commit "/puppet-mode.el"))
>
> It would be nice to install the README too, but no strong opinion.
>
>> + (sha256
>> + (base32
>> + "1indycxawsl0p2aqqg754f6735q3cmah9vd886rpn0ncc3ipi1xm"))))
>> + (build-system emacs-build-system)
>> + (home-page "https://github.com/voxpupuli/puppet-mode")
>> + (synopsis "Emacs major mode for the Puppet configuration language")
>> + (description
>> + "This package provides support for the Puppet configuration language,
>> +including syntax highlighting, indentation of expressions and statements,
>> +linting of manifests and integration with Puppet Debugger.")
>> + (license license:gpl3+))))
>
> Perhaps mention in a comment that it includes ASL code, as mentioned in
> puppet-mode.el.
Hey Marius,
Thanks for taking a look at this. I don't follow about the ASL code
through, what's that?
Thanks,
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#30925] [PATCH] gnu: Add emacs-puppet-mode.
2018-03-26 17:54 ` Marius Bakke
2018-05-17 14:32 ` Christopher Baines
@ 2018-06-11 18:54 ` Christopher Baines
1 sibling, 0 replies; 7+ messages in thread
From: Christopher Baines @ 2018-06-11 18:54 UTC (permalink / raw)
To: Marius Bakke; +Cc: 30925
[-- Attachment #1: Type: text/plain, Size: 1574 bytes --]
Marius Bakke <mbakke@fastmail.com> writes:
> Christopher Baines <mail@cbaines.net> writes:
>
>> * gnu/packages/emacs.scm (emacs-puppet-mode): New variable.
>
> [...]
>
>> +(define-public emacs-puppet-mode
>> + (let ((commit "b3ed5057166a4f49dfa9be638523a348b55a2fd2")
>> + (revision "1"))
>> + (package
>> + (name "emacs-puppet-mode")
>> + (version (git-version "0.3" revision commit))
>
> Maybe mention why we can't take the 0.3 tag?
I've sent a new patch with a comment.
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (string-append
>> + "https://raw.githubusercontent.com/voxpupuli/puppet-mode/"
>> + commit "/puppet-mode.el"))
>
> It would be nice to install the README too, but no strong opinion.
I've gone for leaving it out for now, just to keep the package simple.
>> + (sha256
>> + (base32
>> + "1indycxawsl0p2aqqg754f6735q3cmah9vd886rpn0ncc3ipi1xm"))))
>> + (build-system emacs-build-system)
>> + (home-page "https://github.com/voxpupuli/puppet-mode")
>> + (synopsis "Emacs major mode for the Puppet configuration language")
>> + (description
>> + "This package provides support for the Puppet configuration language,
>> +including syntax highlighting, indentation of expressions and statements,
>> +linting of manifests and integration with Puppet Debugger.")
>> + (license license:gpl3+))))
>
> Perhaps mention in a comment that it includes ASL code, as mentioned in
> puppet-mode.el.
I've added this now :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#30925] [PATCH] gnu: Add emacs-puppet-mode.
2018-03-24 15:59 [bug#30925] [PATCH] gnu: Add emacs-puppet-mode Christopher Baines
2018-03-26 17:54 ` Marius Bakke
@ 2018-06-11 18:46 ` Christopher Baines
2018-06-11 19:03 ` Marius Bakke
1 sibling, 1 reply; 7+ messages in thread
From: Christopher Baines @ 2018-06-11 18:46 UTC (permalink / raw)
To: 30925
* gnu/packages/emacs.scm (emacs-puppet-mode): New variable.
---
gnu/packages/emacs.scm | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 9caa01a0f..039f52a56 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -3014,6 +3014,33 @@ This provides a basic API and common UI widgets such as popup tooltips
and popup menus.")
(license license:gpl3+)))
+(define-public emacs-puppet-mode
+ (let ((commit "b3ed5057166a4f49dfa9be638523a348b55a2fd2")
+ (revision "1"))
+ (package
+ (name "emacs-puppet-mode")
+ ;; The last release, 0.3 was several years ago, and there have been many
+ ;; commits since
+ (version (git-version "0.3" revision commit))
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append
+ "https://raw.githubusercontent.com/voxpupuli/puppet-mode/"
+ commit "/puppet-mode.el"))
+ (sha256
+ (base32
+ "1indycxawsl0p2aqqg754f6735q3cmah9vd886rpn0ncc3ipi1xm"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/voxpupuli/puppet-mode")
+ (synopsis "Emacs major mode for the Puppet configuration language")
+ (description
+ "This package provides support for the Puppet configuration language,
+including syntax highlighting, indentation of expressions and statements,
+linting of manifests and integration with Puppet Debugger.")
+ ;; Also incorporates work covered by the Apache License, Version 2.0
+ (license license:gpl3+))))
+
(define-public emacs-god-mode
(let ((commit "6cf0807b6555eb6fcf8387a4e3b667071ef38964")
(revision "1"))
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-06-12 6:59 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-24 15:59 [bug#30925] [PATCH] gnu: Add emacs-puppet-mode Christopher Baines
2018-03-26 17:54 ` Marius Bakke
2018-05-17 14:32 ` Christopher Baines
2018-06-11 18:54 ` Christopher Baines
2018-06-11 18:46 ` Christopher Baines
2018-06-11 19:03 ` Marius Bakke
2018-06-12 6:58 ` bug#30925: " Christopher Baines
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).