unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 30925@debbugs.gnu.org
Subject: [bug#30925] [PATCH] gnu: Add emacs-puppet-mode.
Date: Thu, 17 May 2018 15:32:10 +0100	[thread overview]
Message-ID: <87603mgxp1.fsf@cbaines.net> (raw)
In-Reply-To: <87370mk9j6.fsf@fastmail.com>

[-- Attachment #1: Type: text/plain, Size: 1614 bytes --]


Marius Bakke <mbakke@fastmail.com> writes:

> Christopher Baines <mail@cbaines.net> writes:
>
>> * gnu/packages/emacs.scm (emacs-puppet-mode): New variable.
>
> [...]
>   
>> +(define-public emacs-puppet-mode
>> +  (let ((commit "b3ed5057166a4f49dfa9be638523a348b55a2fd2")
>> +        (revision "1"))
>> +    (package
>> +      (name "emacs-puppet-mode")
>> +      (version (git-version "0.3" revision commit))
>
> Maybe mention why we can't take the 0.3 tag?
>
>> +      (source
>> +       (origin
>> +         (method url-fetch)
>> +         (uri (string-append
>> +               "https://raw.githubusercontent.com/voxpupuli/puppet-mode/"
>> +               commit "/puppet-mode.el"))
>
> It would be nice to install the README too, but no strong opinion.
>
>> +         (sha256
>> +          (base32
>> +           "1indycxawsl0p2aqqg754f6735q3cmah9vd886rpn0ncc3ipi1xm"))))
>> +      (build-system emacs-build-system)
>> +      (home-page "https://github.com/voxpupuli/puppet-mode")
>> +      (synopsis "Emacs major mode for the Puppet configuration language")
>> +      (description
>> +       "This package provides support for the Puppet configuration language,
>> +including syntax highlighting, indentation of expressions and statements,
>> +linting of manifests and integration with Puppet Debugger.")
>> +      (license license:gpl3+))))
>
> Perhaps mention in a comment that it includes ASL code, as mentioned in
> puppet-mode.el.

Hey Marius,

Thanks for taking a look at this. I don't follow about the ASL code
through, what's that?

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

  reply	other threads:[~2018-05-17 14:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-24 15:59 [bug#30925] [PATCH] gnu: Add emacs-puppet-mode Christopher Baines
2018-03-26 17:54 ` Marius Bakke
2018-05-17 14:32   ` Christopher Baines [this message]
2018-06-11 18:54   ` Christopher Baines
2018-06-11 18:46 ` Christopher Baines
2018-06-11 19:03   ` Marius Bakke
2018-06-12  6:58     ` bug#30925: " Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87603mgxp1.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=30925@debbugs.gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).