unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Hilton Chain via Guix-patches via <guix-patches@gnu.org>
To: Distopico <distopico@riseup.net>
Cc: Raghav Gururajan <rg@raghavgururajan.name>,
	Saku Laesvuori <saku@laesvuori.fi>,
	64748@debbugs.gnu.org
Subject: [bug#64748] [PATCH] gnu: webrtc-for-telegram-desktop: Update to a45d8b8
Date: Mon, 07 Aug 2023 17:38:57 +0800	[thread overview]
Message-ID: <87350vw5se.wl-hako@ultrarare.space> (raw)
In-Reply-To: <20230805030015.28796-1-distopico@riseup.net>

Hi,

Sorry for the late reply (in this thread).

On Sat, 05 Aug 2023 10:59:50 +0800,
Distopico wrote:
>
> * gnu/packages/telegram.scm (webrtc-for-telegram-desktop): Update to a45d8b8 revision commit
>
> Fixes `telegram-desktop` calls that are not working with OpenSSL 3.
> Now, `webrtc-for-telegram-desktop` uses sources from the Guix `libsrtp`
> package instead of the submodule in the `unpack-additional-sources` phase.
>
> see: https://github.com/telegramdesktop/tdesktop/issues/26108
>
> ---
> * gnu/packages/telegram.scm (webrtc-for-telegram-desktop): Update to a45d8b8 revision commit
>
> Fixes `telegram-desktop` calls that are not working with OpenSSL 3.
> Now, `webrtc-for-telegram-desktop` uses sources from the Guix `libsrtp`
> package instead of the submodule in the `unpack-additional-sources` phase.

Have you checked <https://github.com/desktop-app/tg_owt/pull/123>
(Unbundle libSRTP) yet?

`git grep include.*libsrtp' shows that `srtp_priv.h' is used, and it's
not present in libsrtp@2.4.2.  But since you have tested, I think it's
not an issue here.

For commit message, I think there's a 80-character limit and the long
sentences could be split into the [...] below as well.
--8<---------------cut here---------------start------------->8---
* gnu/packages/telegram.scm (...): ...
[snippet]: [...]
[#:phases]<unpack-additional-sources>: [...]
--8<---------------cut here---------------end--------------->8---

0-388.a45d8b8 can be used to describe the version if you prefer.

Patch LGTM, but if the aforementioned patch works, it's better to add
it.

Thanks




  reply	other threads:[~2023-08-07  9:54 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-20 17:18 [bug#64748] [PATCH] gnu: webrtc-for-telegram-desktop: Update to a45d8b8 Distopico
2023-07-20 19:33 ` Saku Laesvuori via Guix-patches via
2023-07-20 20:21   ` Distopico
2023-07-20 21:06     ` Saku Laesvuori via Guix-patches via
2023-07-20 23:09       ` Distopico
2023-07-21  7:22         ` Saku Laesvuori via Guix-patches via
2023-07-22  6:36           ` Raghav Gururajan via Guix-patches via
2023-07-22  8:25             ` Saku Laesvuori via Guix-patches via
2023-07-24 17:07               ` Distopico
2023-07-24 20:17                 ` Raghav Gururajan via Guix-patches via
2023-07-26  7:24                   ` Saku Laesvuori via Guix-patches via
2023-07-26 18:54                     ` Distopico
2023-07-20 23:26 ` [bug#64748] [PATCH v2] " Distopico
2023-07-26 18:54 ` [bug#64748] [PATCH v3] " Distopico
2023-07-26 19:13   ` Saku Laesvuori via Guix-patches via
2023-07-26 19:22     ` Distopico
2023-07-26 19:21 ` [bug#64748] [PATCH v4] " Distopico
2023-07-26 20:09   ` Saku Laesvuori via Guix-patches via
2023-08-05  2:59     ` [bug#64748] [PATCH] " Distopico
2023-08-07  9:38       ` Hilton Chain via Guix-patches via [this message]
2023-08-07 12:26         ` Hilton Chain via Guix-patches via
2023-08-28 13:30 ` [bug#64748] [PATCH v6 0/2] gnu: webrtc-for-telegram-desktop: Update to 0-389.0532942 Hilton Chain via Guix-patches via
2023-08-28 13:31   ` [bug#64748] [PATCH v6 1/2] gnu: libyuv-for-telegram-desktop: Update to 0-2439.77c2121 Hilton Chain via Guix-patches via
2023-08-28 13:31   ` [bug#64748] [PATCH v6 2/2] gnu: webrtc-for-telegram-desktop: Update to 0-389.0532942 Hilton Chain via Guix-patches via
2023-08-28 14:56 ` [bug#64748] [PATCH v7 0/2] " Hilton Chain via Guix-patches via
2023-08-28 15:00   ` [bug#64748] [PATCH v7 1/2] gnu: libyuv-for-telegram-desktop: Update to 0-2439.77c2121 Hilton Chain via Guix-patches via
2023-08-28 15:00   ` [bug#64748] [PATCH v7 2/2] gnu: webrtc-for-telegram-desktop: Update to 0-389.0532942 Hilton Chain via Guix-patches via
2023-08-29 18:13     ` Distopico
2023-09-01  9:01       ` bug#64748: " Hilton Chain via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87350vw5se.wl-hako@ultrarare.space \
    --to=guix-patches@gnu.org \
    --cc=64748@debbugs.gnu.org \
    --cc=distopico@riseup.net \
    --cc=hako@ultrarare.space \
    --cc=rg@raghavgururajan.name \
    --cc=saku@laesvuori.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).