From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id QNC5Okm/0GSd0wAASxT56A (envelope-from ) for ; Mon, 07 Aug 2023 11:54:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id mIy0Okm/0GT4eQAA9RJhRA (envelope-from ) for ; Mon, 07 Aug 2023 11:54:17 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4C5A349172 for ; Mon, 7 Aug 2023 11:54:17 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b=Ie1ciNjN; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1691402057; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=gwPOcdpBY/pOeSALuf+ylY6dESvs5Tt3x5tZPa3LeKQ=; b=P6tI7SlghjaHq2RN9nOPNob2K6v709/wwOAkuDpS2SNonPeZZ31X/KibAjliiwOp8VIili gcHcxaVHArQepp2pSp4DwkdE8x6rAA2cdQLdv1s5cg3qA2Q5n3hzut0bz79bt86GxokqNX M6wrGXtCEv2I+q1S0V/Wz+eKfP1Fr/QElAmh/H31emvc8kWIJ5IoTspbw8rPyDBUYpjCzo 9CfU5Hm2+9f1EHOTeQveEXdQVRW/DFty1CKLCEiY1sL4ldlUoWeEexJzJFiAKRjVfpkZEs 3ZFs5nDrcrJMbB23UBV+yi3pzAk6LryJ1f5hXE+7aVzXJ5cE4WTXVKErjeOZeA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1691402057; a=rsa-sha256; cv=none; b=kn8bk6m+sdnxwqfQ/lZEQ3xsbp/guQ1KvJhcfdL74cmQKlvlj2YDjpIgVsEFLR19eGmo+h wGc+XFabZHXlqcjn4RIH+NbpSyl5ZX1SLiCSRj5CVKnmNO/tlZCC7bLQp1kWXtUUSAFwpP 0Kwpao1UFVQFax/RW5dsRKm33JMAqihjbvGYN/+8n4fTSibLuBXY7NzBnZdhcFArNZB1rA +d1mUAcbzlck3Hgv0yefhJWqc7RzwqYEwvY9zh+81S8DNPUh6zjvHfg/aObNFfLq8kSeZf uQhPsLyjRh3jnxV9TNPnP1p9qC83D3feklIrcaDgTBvxnsxH5jj5oWTSXxlhfQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b=Ie1ciNjN; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qSwwA-00081k-DU; Mon, 07 Aug 2023 05:54:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSww6-00081K-MA for guix-patches@gnu.org; Mon, 07 Aug 2023 05:54:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qSww6-0004VE-Dr for guix-patches@gnu.org; Mon, 07 Aug 2023 05:54:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qSww6-0000O9-9N for guix-patches@gnu.org; Mon, 07 Aug 2023 05:54:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64748] [PATCH] gnu: webrtc-for-telegram-desktop: Update to a45d8b8 Resent-From: Hilton Chain Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 07 Aug 2023 09:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64748 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Distopico Cc: Raghav Gururajan , Saku Laesvuori , 64748@debbugs.gnu.org Received: via spool by 64748-submit@debbugs.gnu.org id=B64748.16914019981427 (code B ref 64748); Mon, 07 Aug 2023 09:54:02 +0000 Received: (at 64748) by debbugs.gnu.org; 7 Aug 2023 09:53:18 +0000 Received: from localhost ([127.0.0.1]:60634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSwvN-0000Mw-W2 for submit@debbugs.gnu.org; Mon, 07 Aug 2023 05:53:18 -0400 Received: from mail.boiledscript.com ([144.168.59.46]:51370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSwvK-0000Mk-8r for 64748@debbugs.gnu.org; Mon, 07 Aug 2023 05:53:15 -0400 Date: Mon, 07 Aug 2023 17:38:57 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1691401978; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gwPOcdpBY/pOeSALuf+ylY6dESvs5Tt3x5tZPa3LeKQ=; b=Ie1ciNjNuiGmxDz+TPlRr+EL334clXztq5s6NT7qrp77/+dLVsDSA5x4UoPHIdXFmNNs6n jYz0pMwQI6jll5NkPemkWDzZBCd2NAhxuLKHqpkCxjseUFIK4ylDr/lUxZu51eZ52Owkr0 iOAjN3LaK99FJeJnek3p3JZwGimqplSJjVuPoECCguh38xAboHYPZNRfJxBd7KyfXHXb5O 2EccTnZpHLGfkifbl/0mv77u998rRRe3ImvpF2xyFZV5RgRyWUbsd3mkGslIyCfaX94zBN SgANLMEBV0bY1C/41ScJpRY9o7J0mEErjWOkoxexy6lSRQevAs0p1Z72ngSsiQ== Message-ID: <87350vw5se.wl-hako@ultrarare.space> In-Reply-To: <20230805030015.28796-1-distopico@riseup.net> References: <20230726200916.rwmqmutv7ig5wmbp@X-kone> <20230805030015.28796-1-distopico@riseup.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spamd-Bar: / X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Hilton Chain X-ACL-Warn: , Hilton Chain via Guix-patches From: Hilton Chain via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 4C5A349172 X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -6.66 X-Spam-Score: -6.66 X-TUID: Fx6goqBK71eD Hi, Sorry for the late reply (in this thread). On Sat, 05 Aug 2023 10:59:50 +0800, Distopico wrote: > > * gnu/packages/telegram.scm (webrtc-for-telegram-desktop): Update to a45d8b8 revision commit > > Fixes `telegram-desktop` calls that are not working with OpenSSL 3. > Now, `webrtc-for-telegram-desktop` uses sources from the Guix `libsrtp` > package instead of the submodule in the `unpack-additional-sources` phase. > > see: https://github.com/telegramdesktop/tdesktop/issues/26108 > > --- > * gnu/packages/telegram.scm (webrtc-for-telegram-desktop): Update to a45d8b8 revision commit > > Fixes `telegram-desktop` calls that are not working with OpenSSL 3. > Now, `webrtc-for-telegram-desktop` uses sources from the Guix `libsrtp` > package instead of the submodule in the `unpack-additional-sources` phase. Have you checked (Unbundle libSRTP) yet? `git grep include.*libsrtp' shows that `srtp_priv.h' is used, and it's not present in libsrtp@2.4.2. But since you have tested, I think it's not an issue here. For commit message, I think there's a 80-character limit and the long sentences could be split into the [...] below as well. --8<---------------cut here---------------start------------->8--- * gnu/packages/telegram.scm (...): ... [snippet]: [...] [#:phases]: [...] --8<---------------cut here---------------end--------------->8--- 0-388.a45d8b8 can be used to describe the version if you prefer. Patch LGTM, but if the aforementioned patch works, it's better to add it. Thanks