unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Saku Laesvuori via Guix-patches via <guix-patches@gnu.org>
To: Distopico <distopico@riseup.net>
Cc: rg@raghavgururajan.name, 64748@debbugs.gnu.org, hako@ultrarare.space
Subject: [bug#64748] [PATCH] gnu: webrtc-for-telegram-desktop: Update to a45d8b8
Date: Fri, 21 Jul 2023 10:22:42 +0300	[thread overview]
Message-ID: <20230721072242.eso6juxdbhpdkgex@X-kone> (raw)
In-Reply-To: <87zg3q897e.fsf@riseup.net>

[-- Attachment #1: Type: text/plain, Size: 1458 bytes --]

> > You would probably have to patch the `CMakeLists.txt` so it doesn't try
> > to build libsrtp from source, see what I did with crc32c in the
> > mentioned commit for reference. It is quite possible that telegram
> > doesn't actually need the source code and they are simply using a git
> > submodule to simplify their own dependency versioning and development.
> >
> > You might also have to add a new libsrtp version because the one
> > packaged in Guix is not configured to use openssl unlike telegram
> > expects. I'd still try the packaged version first if compiling telegram
> > a few more times isn't a big problem for you.
>
> I tried but didn't work, this change is similar to **libyuv**, that have
> reference to the source code of that external library: example
> https://github.com/desktop-app/tg_owt/blob/83-sdk/src/api/video/i010_buffer.cc#L17
> 
> So the case of **libsrtp** is similar, check for example:
> - https://github.com/desktop-app/tg_owt/blob/master/src/pc/srtp_session_unittest.cc#L25
> - https://github.com/desktop-app/tg_owt/blob/master/src/pc/external_hmac.cc#L18
> - https://github.com/desktop-app/tg_owt/blob/master/src/pc/BUILD.gn#L174
> 
> So change that will require patch several files, not just
> `CMakeLists.txt`, patch all those file will be make this package hard to
> maintain.

I see. I think libsrtp is small enough that unbundling it is not worth
the effort of patching all those files.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2023-07-21  7:23 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-20 17:18 [bug#64748] [PATCH] gnu: webrtc-for-telegram-desktop: Update to a45d8b8 Distopico
2023-07-20 19:33 ` Saku Laesvuori via Guix-patches via
2023-07-20 20:21   ` Distopico
2023-07-20 21:06     ` Saku Laesvuori via Guix-patches via
2023-07-20 23:09       ` Distopico
2023-07-21  7:22         ` Saku Laesvuori via Guix-patches via [this message]
2023-07-22  6:36           ` Raghav Gururajan via Guix-patches via
2023-07-22  8:25             ` Saku Laesvuori via Guix-patches via
2023-07-24 17:07               ` Distopico
2023-07-24 20:17                 ` Raghav Gururajan via Guix-patches via
2023-07-26  7:24                   ` Saku Laesvuori via Guix-patches via
2023-07-26 18:54                     ` Distopico
2023-07-20 23:26 ` [bug#64748] [PATCH v2] " Distopico
2023-07-26 18:54 ` [bug#64748] [PATCH v3] " Distopico
2023-07-26 19:13   ` Saku Laesvuori via Guix-patches via
2023-07-26 19:22     ` Distopico
2023-07-26 19:21 ` [bug#64748] [PATCH v4] " Distopico
2023-07-26 20:09   ` Saku Laesvuori via Guix-patches via
2023-08-05  2:59     ` [bug#64748] [PATCH] " Distopico
2023-08-07  9:38       ` Hilton Chain via Guix-patches via
2023-08-07 12:26         ` Hilton Chain via Guix-patches via
2023-08-28 13:30 ` [bug#64748] [PATCH v6 0/2] gnu: webrtc-for-telegram-desktop: Update to 0-389.0532942 Hilton Chain via Guix-patches via
2023-08-28 13:31   ` [bug#64748] [PATCH v6 1/2] gnu: libyuv-for-telegram-desktop: Update to 0-2439.77c2121 Hilton Chain via Guix-patches via
2023-08-28 13:31   ` [bug#64748] [PATCH v6 2/2] gnu: webrtc-for-telegram-desktop: Update to 0-389.0532942 Hilton Chain via Guix-patches via
2023-08-28 14:56 ` [bug#64748] [PATCH v7 0/2] " Hilton Chain via Guix-patches via
2023-08-28 15:00   ` [bug#64748] [PATCH v7 1/2] gnu: libyuv-for-telegram-desktop: Update to 0-2439.77c2121 Hilton Chain via Guix-patches via
2023-08-28 15:00   ` [bug#64748] [PATCH v7 2/2] gnu: webrtc-for-telegram-desktop: Update to 0-389.0532942 Hilton Chain via Guix-patches via
2023-08-29 18:13     ` Distopico
2023-09-01  9:01       ` bug#64748: " Hilton Chain via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230721072242.eso6juxdbhpdkgex@X-kone \
    --to=guix-patches@gnu.org \
    --cc=64748@debbugs.gnu.org \
    --cc=distopico@riseup.net \
    --cc=hako@ultrarare.space \
    --cc=rg@raghavgururajan.name \
    --cc=saku@laesvuori.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).