From: pukkamustard <pukkamustard@posteo.net>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 49868@debbugs.gnu.org
Subject: [bug#49868] [PATCH 0/2] guix: dune-build-system: Add a profile parameter.
Date: Tue, 07 Sep 2021 18:11:24 +0000 [thread overview]
Message-ID: <86lf48xifn.fsf@posteo.net> (raw)
In-Reply-To: <20210907150330.31124799@tachikoma.lepiller.eu>
Julien Lepiller <julien@lepiller.eu> writes:
> Unfortunately, this is breaking our ocaml4.07-* packages, because the
> --release flag doesn't exist in the version we use for ocaml4.07-dune.
Whoops. Seems like the --release flag was only added in dune 2.5.0
(https://github.com/ocaml/dune/blob/main/CHANGES.md#250-09042020;
ocaml4.07-dune is at 1.11.3).
> I think the easiest would be to add a flag #:release? and set it to #f
> in package-with-ocaml4.07.
That would work. But I think it would be better if we built everything
in release mode.
Unfortunately the way to do that with old dune is by expclity with '-p
PACKAGE1,PACKAGE2'. That means we need to rename the #:package argument
to #:packages, allow it to take a list and add explicit packages to all
OCaml4.07 packages.
Another way would be to write-out the flags for which -p and --release
are short-hand for. Unfortunately this is different in dune 2.9.0 and
1.11.3 (taken from the --help):
2.9.0:
--8<---------------cut here---------------start------------->8---
--root . --ignore-promoted-rules --no-config --profile release
--always-show-command-line --promote-install-files --default-target
@install
--8<---------------cut here---------------end--------------->8---
1.11.3:
--8<---------------cut here---------------start------------->8---
--root . --ignore-promoted-rules --no-config ----profile release
--8<---------------cut here---------------end--------------->8---
Can we check the version of dune in dune-build-system and either use
--release or the set of 1.11.3 flags?
I just tried doing this in (guix build dune-build-system). Didn't work
as I couldn't use (guix package). After reading up, I guess this needs
to be done in (guix build-system dune) and lowered down as an argument -
maybe as 'dune-release-flags'? Would that be ok?
next prev parent reply other threads:[~2021-09-07 20:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 8:04 [bug#49868] [PATCH 0/2] guix: dune-build-system: Add a profile parameter pukkamustard
2021-08-04 8:08 ` [bug#49868] [PATCH 1/2] " pukkamustard
2021-08-04 8:08 ` [bug#49868] [PATCH 2/2] gnu: ocaml4.07-base: Remove unnecessary arguments pukkamustard
2021-08-09 2:17 ` [bug#49868] [PATCH 0/2] guix: dune-build-system: Add a profile parameter Julien Lepiller
2021-08-09 7:17 ` pukkamustard
2021-08-09 7:19 ` [bug#49868] [PATCH v2 1/2] " pukkamustard
2021-08-09 7:19 ` [bug#49868] [PATCH v2 2/2] gnu: ocaml4.07-base: Remove unnecessary arguments pukkamustard
2021-08-20 22:09 ` bug#49868: [PATCH 0/2] guix: dune-build-system: Add a profile parameter Julien Lepiller
2021-08-24 6:52 ` [bug#49868] " pukkamustard
2021-08-24 7:13 ` pukkamustard
2021-08-24 7:51 ` pukkamustard
2021-09-07 9:33 ` pukkamustard
2021-09-07 11:06 ` Julien Lepiller
2021-09-07 11:46 ` pukkamustard
2021-09-07 13:03 ` Julien Lepiller
2021-09-07 18:11 ` pukkamustard [this message]
2021-09-07 22:03 ` Julien Lepiller
2021-09-08 8:24 ` pukkamustard
2021-09-08 11:45 ` Julien Lepiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86lf48xifn.fsf@posteo.net \
--to=pukkamustard@posteo.net \
--cc=49868@debbugs.gnu.org \
--cc=julien@lepiller.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).