From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +J/pCrjFN2EDhwAAgWs5BA (envelope-from ) for ; Tue, 07 Sep 2021 22:04:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id KHBtBLjFN2FcPwAA1q6Kng (envelope-from ) for ; Tue, 07 Sep 2021 20:04:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 405B8CDE5 for ; Tue, 7 Sep 2021 22:04:07 +0200 (CEST) Received: from localhost ([::1]:35982 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNhKA-0001Cn-Ao for larch@yhetil.org; Tue, 07 Sep 2021 16:04:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44188) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNhK6-0001CN-A6 for guix-patches@gnu.org; Tue, 07 Sep 2021 16:04:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46332) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNhK6-0003vP-2k for guix-patches@gnu.org; Tue, 07 Sep 2021 16:04:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mNhK5-0002b9-T8 for guix-patches@gnu.org; Tue, 07 Sep 2021 16:04:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49868] [PATCH 0/2] guix: dune-build-system: Add a profile parameter. Resent-From: pukkamustard Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 07 Sep 2021 20:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49868 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: 49868@debbugs.gnu.org Received: via spool by 49868-submit@debbugs.gnu.org id=B49868.16310449849922 (code B ref 49868); Tue, 07 Sep 2021 20:04:01 +0000 Received: (at 49868) by debbugs.gnu.org; 7 Sep 2021 20:03:04 +0000 Received: from localhost ([127.0.0.1]:57878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNhJA-0002Zy-D8 for submit@debbugs.gnu.org; Tue, 07 Sep 2021 16:03:04 -0400 Received: from mout01.posteo.de ([185.67.36.65]:56819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNhJ8-0002ZQ-8j for 49868@debbugs.gnu.org; Tue, 07 Sep 2021 16:03:03 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 8069824006C for <49868@debbugs.gnu.org>; Tue, 7 Sep 2021 22:02:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1631044975; bh=UqiDtOGreKltfDa9w8C0n4SePL2kJ07HEAJmLWyIOuE=; h=From:To:Cc:Subject:Date:From; b=pYPN+Nvti4qy9OJJy5Ft2fruWGdMeGm6pWwG9acm/Q3EYGhqSlXmkNdplrABuaGRe 4MGVfX1+oALK+dedDUkq5+N0fmbOXAHvoUB2G0/EFhTMzsDl3ZfS6AmUitysFfzEev vdaNGSEXtV1grSEpT1NMZL7SC7snGIJ/R8sooJQEwco+nygm7Gof3RUCOcMbl/v6Ow JnBLXRcI9Mr3CQIHnf7PHCCXSAbNmfORmipdjtHTGoFlJJiAKoBEkZAL1IlUu6bgM0 D7ZYoNWilbCZJuNHwJgmE85rZTjNj5xyiN3pFB48Lq51N3PopdqFQCOESdu1rgytSn NwF5EHK3sAzWw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4H3x5T6FmNz9rxT; Tue, 7 Sep 2021 22:02:53 +0200 (CEST) References: <20210804080423.3533-1-pukkamustard@posteo.net> <20210821000926.00deacf3@tachikoma.lepiller.eu> <868s0r72rb.fsf@posteo.net> <865yvv71sw.fsf@posteo.net> <86zgt75lhe.fsf@posteo.net> <86y288yavn.fsf@posteo.net> <36A316B4-720C-4753-AFFC-DBC68DBE5EF4@lepiller.eu> <86pmtky4yu.fsf@posteo.net> <20210907150330.31124799@tachikoma.lepiller.eu> From: pukkamustard Date: Tue, 07 Sep 2021 18:11:24 +0000 In-reply-to: <20210907150330.31124799@tachikoma.lepiller.eu> Message-ID: <86lf48xifn.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631045047; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=+4lc5QvhbR+OCW5BEaOFq61SK+3a4hRyrqO9zsHMadY=; b=AUC+dXzkwG/BaJiqxlucAMjfnfxEg2Psz9ixsIgPlU6t01GjTVoQBWbm83EGj3XOauoLlE B5A5KvD6yLMpRP3Hbw01AlHvrQ2y1jlk1U5BRFrCwvG4nq0uR5nQHFF7gyD/nHF40EuCeH tMrQpg6/A5DDa2OzedW/Mm3ykykSkmlaEU7UlbyS4TJfkbEhzaDG1ozkN8xeosAaDewXtA Qbp1ch0LLIu5fpq7x14y8crFQNucdPLmhBaryt6DPpt4rKY1B901r/C9M7u4Ag7yjzZMrD HcfH9uoMbM8EaSjwZFI0xhZJ4cQup4RugB6tNZ2rzi5DoHAL5ALgv0ctXdyxOA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631045047; a=rsa-sha256; cv=none; b=l+3LtcAk159u25kWRqPqv9+Hf+W6geNqAb/cO7FH5a9CXHpezunVivWXo7m69YXSchXRov 3GqzI2OijWHvo40urnWdVDob0yrpe80jFZspeb4iarWdoVTluhqMyi/Ez+76pJyXz2ty4I 8c2RVsfL7Wgi9R+c7P0gcIzHNMYNfx18t9/l5JuVK+T19mtrdvAG8Ta0+fswrdZqzLr25x 6FOBcLRRmzAEosiEWFi3P5rbLrTOiBpJDWWbinB66uoMzwaQR2OTxoNXEZ/pNZWG63sI/T 6CLiC/WRqlb89J7srjEHFTpSl9kLNrRlrm6oN2ikXImbpQYji4HI+kDZK6BFCA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=pYPN+Nvt; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.19 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=pYPN+Nvt; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 405B8CDE5 X-Spam-Score: 0.19 X-Migadu-Scanner: scn1.migadu.com X-TUID: dLCBJ63ax6KW Julien Lepiller writes: > Unfortunately, this is breaking our ocaml4.07-* packages, because the > --release flag doesn't exist in the version we use for ocaml4.07-dune. Whoops. Seems like the --release flag was only added in dune 2.5.0 (https://github.com/ocaml/dune/blob/main/CHANGES.md#250-09042020; ocaml4.07-dune is at 1.11.3). > I think the easiest would be to add a flag #:release? and set it to #f > in package-with-ocaml4.07. That would work. But I think it would be better if we built everything in release mode. Unfortunately the way to do that with old dune is by expclity with '-p PACKAGE1,PACKAGE2'. That means we need to rename the #:package argument to #:packages, allow it to take a list and add explicit packages to all OCaml4.07 packages. Another way would be to write-out the flags for which -p and --release are short-hand for. Unfortunately this is different in dune 2.9.0 and 1.11.3 (taken from the --help): 2.9.0: --8<---------------cut here---------------start------------->8--- --root . --ignore-promoted-rules --no-config --profile release --always-show-command-line --promote-install-files --default-target @install --8<---------------cut here---------------end--------------->8--- 1.11.3: --8<---------------cut here---------------start------------->8--- --root . --ignore-promoted-rules --no-config ----profile release --8<---------------cut here---------------end--------------->8--- Can we check the version of dune in dune-build-system and either use --release or the set of 1.11.3 flags? I just tried doing this in (guix build dune-build-system). Didn't work as I couldn't use (guix package). After reading up, I guess this needs to be done in (guix build-system dune) and lowered down as an argument - maybe as 'dune-release-flags'? Would that be ok?